Repository navigation
Conversation
Explicitly request the published FFmpeg runtime and require factory release identity for the command and all seven libraries. Keep the working OpenH264 path until native decoder builds are published. Hive-Run: projectbluefin#12 Hive-Plan: Dakota codec set / Utah factory identity assertions Hive-Spec: issue-12#factory-parity Assisted-by: openai/gpt-6.1-sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mendezr the hive has adopted this PR ( |
There was a problem hiding this comment.
The code change looks correct to me. One thing to fix before merge: the PR body will close #12, which this PR says stays open.
Package contract (verified):
- The eight names land in
[parity](packages/utah.toml:116) and in[factory] parity(packages/utah.toml:1000). verify_parity_origin(scripts/verify-rpm-contract.py:492) requires.bfinfor factory-parity packages.baselines/utah/rpms.tsv:204,544-549,769-770already records all eight as9.0.1-2.hum1.bfin. The new assertion matches what the image ships today, so it should not break the build.- The README and
site/data/packages.jsoncounts rise by exactly 8 (345 to 353, 402 to 410). - Moving the doc reference from #383 to #12 is fine, because #383 is closed.
Issue link conflicts with the stated scope. Two lines in the body disagree:
- The body says
Refs #12 - partial: native H.264/HEVC, VC-1 and VVC decoder capability checks and the OpenH264 removal remain unfinished. - The new doc text in
docs/skills/package-contract.md:147saysKeep #12 open for that remaining capability work. - The body also ends with
Closes #12, so GitHub will close #12 on merge.
That would drop the remaining decoder and hardware-proof work this PR deliberately leaves open. Suggested fix: remove the trailing Closes #12 and keep the Refs #12 line.
CI: the two build_kernel nvidia jobs were still pending when I looked, and everything else was green or skipped.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
-- hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. stage 100-merge-queue → 074-adopted-by-hive: conflicting |
Summary: Utah’s audio and video libraries already come from its package factory, but the build did not explicitly require or check all of them. This change makes those libraries required and rejects replacements that were not built by the factory. It keeps the working video decoder in place rather than claiming support the current packages do not provide.
What changed
ffmpeg-freeand all seven runtime libraries in[parity], and require.bfinrelease identity through[factory].parity.Scope and evidence
Refs #12 — partial: native H.264/HEVC, VC-1 and VVC decoder capability checks and the OpenH264 removal remain unfinished until suitable factory builds are published.
This follows the approved reversible direction to retain the published FFmpeg build. All eight names already appear in
baselines/utah/rpms.tsvas9.0.1-2.hum1.bfin; this makes their installation and identity explicit rather than relying on dependency resolution. The existing verifier records their NEVRAs and checks their factory release identity.The current factory spec at
projectbluefin/utah-packagescommitb92a400d9194c392c3e2ce07591dc630c33440b0still uses the encoder/decoder allowlists and--disable-decoder="h264,hevc,vc1,vvc". Removing OpenH264 or asserting those native decoders now would break the current supported path. The existingopenh264decanddav1ddecload checks remain unchanged. The already-merged plugin work in #1307 is not duplicated.Verification
python3 -m unittest discover -s tests -p test_verify_rpm_contract.py(201 tests).--checkcommands againstpackages/base.toml.git diff --check.just check: its 1,421-test suite ended with four failures and three errors outside this change: missing externalkillexecutable (three ISO tests), unsupported hostcp --updatesyntax (three Ghostty tests), and an end-to-end deadline test exceeding its timeout. Checks preceding the suite passed; the complete gate did not pass.pre-commit run --all-files:pre-commitis not installed.just check-repos: Podman is not installed, so transaction resolution could not run here. CI must validate the pinned transaction.-- hive: backend=pi model=openai/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:405e131