Skip to content

fix: protect the installed video libraries from replacement - #1382

Open
mendezr wants to merge 1 commit into
projectbluefin:mainfrom
mendezr:fix/factory-media-decoders
Open

mendezr wants to merge 1 commit into
projectbluefin:mainfrom
mendezr:fix/factory-media-decoders

Conversation

@mendezr

@mendezr mendezr commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary: Utah’s audio and video libraries already come from its package factory, but the build did not explicitly require or check all of them. This change makes those libraries required and rejects replacements that were not built by the factory. It keeps the working video decoder in place rather than claiming support the current packages do not provide.


What changed

  • Explicitly request ffmpeg-free and all seven runtime libraries in [parity], and require .bfin release identity through [factory].parity.
  • Cover both missing declarations and rejected Hummingbird/Fedora substitutes with a regression test; accept the factory release.
  • Refresh generated package data and counts, and document the distinction between package identity and codec capability in the package-contract skill.
  • No repository configuration, package-image pin, or decoder selection changes.

Scope and evidence

Refs #12 — partial: native H.264/HEVC, VC-1 and VVC decoder capability checks and the OpenH264 removal remain unfinished until suitable factory builds are published.

This follows the approved reversible direction to retain the published FFmpeg build. All eight names already appear in baselines/utah/rpms.tsv as 9.0.1-2.hum1.bfin; this makes their installation and identity explicit rather than relying on dependency resolution. The existing verifier records their NEVRAs and checks their factory release identity.

The current factory spec at projectbluefin/utah-packages commit b92a400d9194c392c3e2ce07591dc630c33440b0 still uses the encoder/decoder allowlists and --disable-decoder="h264,hevc,vc1,vvc". Removing OpenH264 or asserting those native decoders now would break the current supported path. The existing openh264dec and dav1ddec load checks remain unchanged. The already-merged plugin work in #1307 is not duplicated.

Verification

  • Passed: python3 -m unittest discover -s tests -p test_verify_rpm_contract.py (201 tests).
  • Passed: install and RPM verifier --check commands against packages/base.toml.
  • Passed: generated package data/count checks, skill catalog and installed-agent catalog checks, workflow-output checks, skill frontmatter/index checks, and git diff --check.
  • Ran just check: its 1,421-test suite ended with four failures and three errors outside this change: missing external kill executable (three ISO tests), unsupported host cp --update syntax (three Ghostty tests), and an end-to-end deadline test exceeding its timeout. Checks preceding the suite passed; the complete gate did not pass.
  • Attempted pre-commit run --all-files: pre-commit is not installed.
  • Attempted just check-repos: Podman is not installed, so transaction resolution could not run here. CI must validate the pinned transaction.
  • No image build, boot, or hardware codec verification performed.

-- hive: backend=pi model=openai/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: 405e131

Explicitly request the published FFmpeg runtime and require factory release identity for the command and all seven libraries. Keep the working OpenH264 path until native decoder builds are published.

Hive-Run: projectbluefin#12
Hive-Plan: Dakota codec set / Utah factory identity assertions
Hive-Spec: issue-12#factory-parity
Assisted-by: openai/gpt-6.1-sol via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@mergeraptor
mergeraptor Bot requested review from ahmedadan and daegalus November 20, 2026 12:13
@mergeraptor

mergeraptor Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 20, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 20, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks correct to me. One thing to fix before merge: the PR body will close #12, which this PR says stays open.

Package contract (verified):

  • The eight names land in [parity] (packages/utah.toml:116) and in [factory] parity (packages/utah.toml:1000).
  • verify_parity_origin (scripts/verify-rpm-contract.py:492) requires .bfin for factory-parity packages.
  • baselines/utah/rpms.tsv:204,544-549,769-770 already records all eight as 9.0.1-2.hum1.bfin. The new assertion matches what the image ships today, so it should not break the build.
  • The README and site/data/packages.json counts rise by exactly 8 (345 to 353, 402 to 410).
  • Moving the doc reference from #383 to #12 is fine, because #383 is closed.

Issue link conflicts with the stated scope. Two lines in the body disagree:

  • The body says Refs #12 - partial: native H.264/HEVC, VC-1 and VVC decoder capability checks and the OpenH264 removal remain unfinished.
  • The new doc text in docs/skills/package-contract.md:147 says Keep #12 open for that remaining capability work.
  • The body also ends with Closes #12, so GitHub will close #12 on merge.

That would drop the remaining decoder and hardware-proof work this PR deliberately leaves open. Suggested fix: remove the trailing Closes #12 and keep the Refs #12 line.

CI: the two build_kernel nvidia jobs were still pending when I looked, and everything else was green or skipped.

Confidence: 3/5 (needs attention) — 1 perspective requested changes

-- hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327

@hivecommons-hive hivecommons-hive Bot added the role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) label Nov 20, 2026
@hivecommons-hive
hivecommons-hive Bot added this pull request to the merge queue Nov 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
@hivecommons-hive hivecommons-hive Bot added stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Nov 20, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

stage 100-merge-queue → 074-adopted-by-hive: conflicting

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window labels Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant