Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7314ab4
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @hanthor, head
Hive did not add the |
|
@hanthor this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (10 waiting): fixes are handed out before new work as soon as you have capacity. |
Danathar
left a comment
There was a problem hiding this comment.
Changes requested at 212c891, for one concrete fix you can make now. The rest is the factory-publish wait you already note.
contract fails on stale documented counts (the first error, before the repo resolve runs):
error: documented package counts are stale. Regenerate with `python3 scripts/generate-site-data.py` and `python3 scripts/check-doc-counts.py --write`:
README.md Genuinely unavailable: documented 4, manifests say 7
package-contract.md base manifest installed: documented 1, manifests say 61
main's contract is green, so this comes from this PR's manifest changes. Run the two commands the message names and commit the result. The "base manifest installed: documented 1" line also suggests the regeneration has a moved section to pick up; please check that the regenerated package-contract.md reads correctly.
After that, contract will resolve the new [parity]/[factory].parity set against whatever factory pin this PR is on. #1112 merged at 11:52 PM and #1147 at 1:44 AM, and the Renovate pin bump to 80672fd (#1310) is approved. Rebase onto it once it lands; the resolve result then tells us whether all fifteen extension RPMs (and dakota-config-tailscale-setup for tailscale-qs) made it into that publish. The 4:19 AM factory run lost 57 packages to the Hummingbird outage.
I haven't reviewed the submodule removals and script changes line by line yet; I'll do that on the next push.
There was a problem hiding this comment.
Summary: This change stops building most of the desktop's GNOME Shell add-ons (the dock, tiling, blur, Caffeine and others) from bundled source code, and installs them as ready-made packages instead, matching the sister image Dakota. It also adds the battery-colour add-on and drops three add-ons Dakota doesn't ship, as the owner decided. It looks sound overall. One known safety check went away in the move: a test that caught a dock version which doesn't load on GNOME 51. The image never tests for that now.
What I need from you: Add the dock check back as a check on the built image (patch below), and fix one outdated comment.
Reviewed at head 212c891. I read the diff, issue #1235 with the owner's decision, scripts/verify-gnome-extensions.py, the Containerfile build step and the dconf keyfiles from both Utah and common. I could not check what the factory RPMs actually contain, because #1112 and #1147 are not published yet. That covers whether each package owns its UUID directory for rpm -qf, whether its schema path= matches the keyfile sections, and its file modes. The PR says no image was built. The installed verifier fails loudly on each of those, so a bad package would break the build rather than ship.
correctness
- The Dash to Dock GNOME 51 check is deleted, and nothing replaces it (
tests/test_gnome_extensions.py, removedtest_dash_to_dock_does_not_import_the_removed_pointer_watcher). That test caught Dash to Dock v106, which importsui/pointerWatcher.js. GNOME 51 removed that file, so the dock never loaded. Dash to Dock now comes from Fedora's recipe (scripts/verify-gnome-extensions.py:33). The PR keepsdisable-extension-version-validation=truebecause several RPMs declare only GNOME 50, so an older dock that still importspointerWatcherwould install and pass every check. The dock would then be missing at login. This is the same failure the deleted test was written for. Run the check against the installed tree instead. It goes beside the new dconf check atscripts/verify-gnome-extensions.py:224:
failures += dconf_section_errors(args.root)
+ # Dash to Dock v106 imported ui/pointerWatcher.js, which GNOME 51
+ # removed, so the dock never loaded. Version validation is off, so an
+ # older RPM would install silently; catch it here.
+ removed = re.compile(r"\bPointerWatcher\b|ui/pointerWatcher\.js")
+ for js in sorted((base / "dash-to-dock@micxgx.gmail.com").rglob("*.js")):
+ if removed.search(js.read_text(errors="replace")):
+ failures.append(f"{js}: uses pointerWatcher.js, which GNOME 51 removed; the dock will not load")Add a matching case to InstalledExtensionTests: write a dash-to-dock@micxgx.gmail.com/docking.js containing PointerWatcher and assert that the verify fails.
docs-currency
- The libgda comment still names Copyous (
packages/base.toml:81):# Runtime dependencies for the maintained Copyous extension (#1210).This PR removes Copyous (and itsbuild-gnome-extensions.shcomment pointing here), so the comment now gives a wrong reason forlibgda/libgda-sqlite. They stay because they are in Bluefin's base list (#106 indocs/bluefin-package-gaps.md).
# Bluefin base packages (libgda #106); Copyous, their former consumer, is no longer shipped (#1235).
No findings from: security, intent-alignment, style. Intent: the extension set matches the owner's decision on #1235. That means power-status-color is added as opt-in, copyous, quick-settings-audio-panel and bluefin-bling are dropped, and the extensions move to factory RPMs. The enabled set is still Dakota's 11 (contracts/bluefin-desktop.toml:415). Security: the five download-and-unzip release archives go away and are replaced by signed repo packages, which shrinks the build's network inputs.
Confidence: 3/5 (needs attention) — 1 medium finding; 2 perspectives requested changes
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
c26333d to
ca362ec
Compare
Match what Dakota's elements/bluefin/common.bst actually ships (#1266): - Ship both monthly-wallpaper units (ublue-wallpaper-month from wallpaper-month.bst, bluefin-wallpaper-month and its sync helper from files/wallpaper-month) and enable them. zz0 keeps common's value, because Dakota's repoint sed matches nothing (projectbluefin/dakota#1902). A guarded check fails the build if common ever names 12-bluefin.xml. - Drop common's weekly-stats fastfetch lines as patch 0006 does, and retire bluefin-stats-refresh, its user and its fastfetch rewrite. - Ghostty skel follows light/dark (patch 0002). - os-release LOGO=img-logo-icon, plus the four img-logo-icon*.svg wordmarks from projectbluefin/artwork, byte-identical to Dakota's pins. Closes #1266 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Dakota remaps keys with kanata (bluefin/kanata.bst) and ships ydotool (bluefin/ydotool.bst); it has no input-remapper. Install the factory's kanata and ydotool and drop input-remapper with its enablement and contract entry. kanata.service stays opt-in, as Dakota's 80-kanata.preset keeps it: Utah's preset, configure-services.sh and the contract's disabled list agree, and the e2e checks the unit loads without failing. Closes #1222 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
…y RPMs Dakota installs sixteen extensions (elements/bluefin/gnome-shell-extensions.bst). Fifteen now come from factory RPMs instead of vendored submodules and build-time downloads: Fedora's recipes for AppIndicator, Blur my Shell, Caffeine and Dash to Dock, and the factory's gnome-shell-extension-* recipes for Bluefin's eleven, including power-status-color (opt-in). GSConnect stays a pinned submodule built with meson. - Remove sixteen submodules, among them copyous, quick-settings-audio-panel, bluefin-bling and rehhouari's syncthing toggle; the Sync Folder toggle is bling's syncthing-toggle@projectbluefin.io, as on Dakota. - build-gnome-extensions.sh builds only GSConnect; the release-zip downloads and the schema relocation are gone, and [build] drops sassc and unzip. - verify-gnome-extensions.py maps each UUID to its package, checks the manifest requests it, records the owning RPM's NEVRA as provenance, and checks extension dconf defaults against installed schema paths in the image (replacing the submodule-reading test). - disable-extension-version-validation=true stays. Closes #1235 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Copyous is dropped with the move to factory extension RPMs; libgda and libgda-sqlite stay as Bluefin base packages (#106). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
ca362ec to
ebe87ba
Compare
212c891 to
7314ab4
Compare
|
Closing per the owner decision above (2026-11-18): Utah keeps GNOME Shell extensions as git submodules, not factory RPMs, for flexibility and hot fixes. The extension contract on main is unchanged. |
Owner decision on #1235: Dakota's installed extension set (
elements/bluefin/gnome-shell-extensions.bst), with the extensions moving to factory RPMs.[parity]+[factory].parity): Fedora's recipes for AppIndicator, Blur my Shell, Caffeine and Dash to Dock (import: Rawhide recipes for Dakota parity (59 packages) utah-packages#1147, ex-chore(deps): update ghcr.io/projectbluefin/utah-packages:latest docker digest to bab7195 #1023) and the factory's elevengnome-shell-extension-*recipes pinned to Dakota's element refs (feat: package Dakota's Bluefin GNOME Shell extensions as RPMs utah-packages#1112, ex-docs: refresh verified ISO screenshots #1028): bazaar-companion, budslink-companion, custom-command-menu, fuzzy-application-search, gradia-capture, power-status-color (new, opt-in), quicksettings-audio-devices-hider/-renamer, syncthing-toggle, tailscale-qs, tilingshell.gnome-shell-extension-gsconnectis v72 while Dakota and Utah run v74 (bump in fix(drift): align 11 recipes with Dakota's elements (upstream bumps) utah-packages#1132).syncthing-toggle@projectbluefin.io, as on Dakota. It labels itself "Sync Folder" upstream, so Utah's rename of rehhouari's strings is gone;ci-workflows/references/testsuite-triage.mdnotes the smoke expectation (rehhouari's UUID is a testsuite retarget, not a Utah gap).build-gnome-extensions.shbuilds only GSConnect; the release-zip downloads (tilingshell, qsap, hider, renamer, copyous), the in-tree builds and the schema relocation loop are gone.[build]dropssasscandunzip;configure-services.shremoves the remaining three.verify-gnome-extensions.py:PACKAGED_EXTENSIONSmaps each UUID to its package;--sourcechecks the manifest requests every package;--record-provenancerecords the owning RPM's NEVRA (rpm -qfmust name the expected package) next to GSConnect's gitlink; installed mode checks every UUID, no localschemas/, file modes, and that eachorg/gnome/shell/extensions/*section in/etc/dconf/db/distro.dnames apath=an installed schema declares (moved fromtest_dakota_extension_defaults.py, which read submodule schemas).disable-extension-version-validation=truestays (several RPMs declare only GNOME 50, as on Dakota). Enabled set unchanged (Dakota's 11).desktop-contract.mdextension section, extension-schemas / extension-dconf-defaults / dakota-desktop-defaults references, containerfile provenance, ci-workflows, package-contract.Status: blocked on factory publish of #1112 and #1147, then the Renovate factory pin.
tailscale-qsrequiresdakota-config-tailscale-setup(published with projectbluefin/utah-packages#1018's subpackages).Stacked on #1295.
Closes #1235
Verification:
umask 022; just checkpasses (1323 tests); targeted extension/provenance/contract tests pass. Not built as an image.