Skip to content

feat(extensions): install Dakota's GNOME Shell extensions from factory RPMs - #1296

Closed
hanthor wants to merge 4 commits into
feat/dakota-config-packagesfrom
feat/dakota-extension-rpms
Closed

hanthor wants to merge 4 commits into
feat/dakota-config-packagesfrom
feat/dakota-extension-rpms

Conversation

@hanthor

@hanthor hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member

Owner decision on #1235: Dakota's installed extension set (elements/bluefin/gnome-shell-extensions.bst), with the extensions moving to factory RPMs.

  • Fifteen extensions from RPMs ([parity] + [factory].parity): Fedora's recipes for AppIndicator, Blur my Shell, Caffeine and Dash to Dock (import: Rawhide recipes for Dakota parity (59 packages) utah-packages#1147, ex-chore(deps): update ghcr.io/projectbluefin/utah-packages:latest docker digest to bab7195 #1023) and the factory's eleven gnome-shell-extension-* recipes pinned to Dakota's element refs (feat: package Dakota's Bluefin GNOME Shell extensions as RPMs utah-packages#1112, ex-docs: refresh verified ISO screenshots #1028): bazaar-companion, budslink-companion, custom-command-menu, fuzzy-application-search, gradia-capture, power-status-color (new, opt-in), quicksettings-audio-devices-hider/-renamer, syncthing-toggle, tailscale-qs, tilingshell.
  • Submodules removed: those fifteen plus copyous, quick-settings-audio-panel, bluefin-bling and rehhouari's syncthing toggle (owner decision). GSConnect stays a pinned submodule: the factory's gnome-shell-extension-gsconnect is v72 while Dakota and Utah run v74 (bump in fix(drift): align 11 recipes with Dakota's elements (upstream bumps) utah-packages#1132).
  • Sync Folder toggle: bling's syncthing-toggle@projectbluefin.io, as on Dakota. It labels itself "Sync Folder" upstream, so Utah's rename of rehhouari's strings is gone; ci-workflows/references/testsuite-triage.md notes the smoke expectation (rehhouari's UUID is a testsuite retarget, not a Utah gap).
  • build-gnome-extensions.sh builds only GSConnect; the release-zip downloads (tilingshell, qsap, hider, renamer, copyous), the in-tree builds and the schema relocation loop are gone. [build] drops sassc and unzip; configure-services.sh removes the remaining three.
  • verify-gnome-extensions.py: PACKAGED_EXTENSIONS maps each UUID to its package; --source checks the manifest requests every package; --record-provenance records the owning RPM's NEVRA (rpm -qf must name the expected package) next to GSConnect's gitlink; installed mode checks every UUID, no local schemas/, file modes, and that each org/gnome/shell/extensions/* section in /etc/dconf/db/distro.d names a path= an installed schema declares (moved from test_dakota_extension_defaults.py, which read submodule schemas).
  • disable-extension-version-validation=true stays (several RPMs declare only GNOME 50, as on Dakota). Enabled set unchanged (Dakota's 11).
  • Docs: desktop-contract.md extension section, extension-schemas / extension-dconf-defaults / dakota-desktop-defaults references, containerfile provenance, ci-workflows, package-contract.

Status: blocked on factory publish of #1112 and #1147, then the Renovate factory pin. tailscale-qs requires dakota-config-tailscale-setup (published with projectbluefin/utah-packages#1018's subpackages).

Stacked on #1295.

Closes #1235

Verification: umask 022; just check passes (1323 tests); targeted extension/provenance/contract tests pass. Not built as an image.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor
7314ab4

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head 7314ab437b38) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • test_removal — deletes 2 test file(s) (Deletes test files or guts test coverage)
    • tests/test_bling_extensions.py
    • tests/test_dakota_extension_defaults.py

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

@hanthor this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (10 waiting): fixes are handed out before new work as soon as you have capacity.

@hanthor hanthor mentioned this pull request Nov 16, 2026
1 of 30 tasks

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested at 212c891, for one concrete fix you can make now. The rest is the factory-publish wait you already note.

contract fails on stale documented counts (the first error, before the repo resolve runs):

error: documented package counts are stale. Regenerate with `python3 scripts/generate-site-data.py` and `python3 scripts/check-doc-counts.py --write`:
  README.md Genuinely unavailable: documented 4, manifests say 7
  package-contract.md base manifest installed: documented 1, manifests say 61

main's contract is green, so this comes from this PR's manifest changes. Run the two commands the message names and commit the result. The "base manifest installed: documented 1" line also suggests the regeneration has a moved section to pick up; please check that the regenerated package-contract.md reads correctly.

After that, contract will resolve the new [parity]/[factory].parity set against whatever factory pin this PR is on. #1112 merged at 11:52 PM and #1147 at 1:44 AM, and the Renovate pin bump to 80672fd (#1310) is approved. Rebase onto it once it lands; the resolve result then tells us whether all fifteen extension RPMs (and dakota-config-tailscale-setup for tailscale-qs) made it into that publish. The 4:19 AM factory run lost 57 packages to the Hummingbird outage.

I haven't reviewed the submodule removals and script changes line by line yet; I'll do that on the next push.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change stops building most of the desktop's GNOME Shell add-ons (the dock, tiling, blur, Caffeine and others) from bundled source code, and installs them as ready-made packages instead, matching the sister image Dakota. It also adds the battery-colour add-on and drops three add-ons Dakota doesn't ship, as the owner decided. It looks sound overall. One known safety check went away in the move: a test that caught a dock version which doesn't load on GNOME 51. The image never tests for that now.

What I need from you: Add the dock check back as a check on the built image (patch below), and fix one outdated comment.


Reviewed at head 212c891. I read the diff, issue #1235 with the owner's decision, scripts/verify-gnome-extensions.py, the Containerfile build step and the dconf keyfiles from both Utah and common. I could not check what the factory RPMs actually contain, because #1112 and #1147 are not published yet. That covers whether each package owns its UUID directory for rpm -qf, whether its schema path= matches the keyfile sections, and its file modes. The PR says no image was built. The installed verifier fails loudly on each of those, so a bad package would break the build rather than ship.

correctness

  • The Dash to Dock GNOME 51 check is deleted, and nothing replaces it (tests/test_gnome_extensions.py, removed test_dash_to_dock_does_not_import_the_removed_pointer_watcher). That test caught Dash to Dock v106, which imports ui/pointerWatcher.js. GNOME 51 removed that file, so the dock never loaded. Dash to Dock now comes from Fedora's recipe (scripts/verify-gnome-extensions.py:33). The PR keeps disable-extension-version-validation=true because several RPMs declare only GNOME 50, so an older dock that still imports pointerWatcher would install and pass every check. The dock would then be missing at login. This is the same failure the deleted test was written for. Run the check against the installed tree instead. It goes beside the new dconf check at scripts/verify-gnome-extensions.py:224:
         failures += dconf_section_errors(args.root)
+        # Dash to Dock v106 imported ui/pointerWatcher.js, which GNOME 51
+        # removed, so the dock never loaded. Version validation is off, so an
+        # older RPM would install silently; catch it here.
+        removed = re.compile(r"\bPointerWatcher\b|ui/pointerWatcher\.js")
+        for js in sorted((base / "dash-to-dock@micxgx.gmail.com").rglob("*.js")):
+            if removed.search(js.read_text(errors="replace")):
+                failures.append(f"{js}: uses pointerWatcher.js, which GNOME 51 removed; the dock will not load")

Add a matching case to InstalledExtensionTests: write a dash-to-dock@micxgx.gmail.com/docking.js containing PointerWatcher and assert that the verify fails.

docs-currency

  • The libgda comment still names Copyous (packages/base.toml:81): # Runtime dependencies for the maintained Copyous extension (#1210). This PR removes Copyous (and its build-gnome-extensions.sh comment pointing here), so the comment now gives a wrong reason for libgda/libgda-sqlite. They stay because they are in Bluefin's base list (#106 in docs/bluefin-package-gaps.md).
    # Bluefin base packages (libgda #106); Copyous, their former consumer, is no longer shipped (#1235).

No findings from: security, intent-alignment, style. Intent: the extension set matches the owner's decision on #1235. That means power-status-color is added as opt-in, copyous, quick-settings-audio-panel and bluefin-bling are dropped, and the extensions move to factory RPMs. The enabled set is still Dakota's 11 (contracts/bluefin-desktop.toml:415). Security: the five download-and-unzip release archives go away and are replaced by signed repo packages, which shrinks the build's network inputs.

Confidence: 3/5 (needs attention) — 1 medium finding; 2 perspectives requested changes

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

hanthor and others added 3 commits November 18, 2026 12:59
Match what Dakota's elements/bluefin/common.bst actually ships (#1266):

- Ship both monthly-wallpaper units (ublue-wallpaper-month from
  wallpaper-month.bst, bluefin-wallpaper-month and its sync helper from
  files/wallpaper-month) and enable them. zz0 keeps common's value, because
  Dakota's repoint sed matches nothing (projectbluefin/dakota#1902). A
  guarded check fails the build if common ever names 12-bluefin.xml.
- Drop common's weekly-stats fastfetch lines as patch 0006 does, and
  retire bluefin-stats-refresh, its user and its fastfetch rewrite.
- Ghostty skel follows light/dark (patch 0002).
- os-release LOGO=img-logo-icon, plus the four img-logo-icon*.svg wordmarks
  from projectbluefin/artwork, byte-identical to Dakota's pins.

Closes #1266

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
Dakota remaps keys with kanata (bluefin/kanata.bst) and ships ydotool
(bluefin/ydotool.bst); it has no input-remapper. Install the factory's
kanata and ydotool and drop input-remapper with its enablement and
contract entry. kanata.service stays opt-in, as Dakota's 80-kanata.preset
keeps it: Utah's preset, configure-services.sh and the contract's
disabled list agree, and the e2e checks the unit loads without failing.

Closes #1222

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
…y RPMs

Dakota installs sixteen extensions (elements/bluefin/gnome-shell-extensions.bst).
Fifteen now come from factory RPMs instead of vendored submodules and
build-time downloads: Fedora's recipes for AppIndicator, Blur my Shell,
Caffeine and Dash to Dock, and the factory's gnome-shell-extension-* recipes
for Bluefin's eleven, including power-status-color (opt-in). GSConnect stays
a pinned submodule built with meson.

- Remove sixteen submodules, among them copyous, quick-settings-audio-panel,
  bluefin-bling and rehhouari's syncthing toggle; the Sync Folder toggle is
  bling's syncthing-toggle@projectbluefin.io, as on Dakota.
- build-gnome-extensions.sh builds only GSConnect; the release-zip downloads
  and the schema relocation are gone, and [build] drops sassc and unzip.
- verify-gnome-extensions.py maps each UUID to its package, checks the
  manifest requests it, records the owning RPM's NEVRA as provenance, and
  checks extension dconf defaults against installed schema paths in the
  image (replacing the submodule-reading test).
- disable-extension-version-validation=true stays.

Closes #1235

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
@hivecommons-hive hivecommons-hive Bot removed the stage/stalled In its current stage longer than expected label Nov 18, 2026
Copyous is dropped with the move to factory extension RPMs; libgda and
libgda-sqlite stay as Bluefin base packages (#106).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
Base automatically changed from feat/dakota-common-edits to feat/dakota-config-packages November 18, 2026 22:21
@hanthor

hanthor commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

Closing per the owner decision above (2026-11-18): Utah keeps GNOME Shell extensions as git submodules, not factory RPMs, for flexibility and hot fixes. The extension contract on main is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parity(dakota): GNOME Shell extension set (power-status-color, Utah-only extensions)

2 participants