Repository navigation
feat(fonts): add Noto Serif CJK and Symbols Nerd Font, as on Dakota - #1295
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hanthor this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (9 waiting): fixes are handed out before new work as soon as you have capacity. |
🐝 Possible duplicateThis PR changes exactly the same files as #1278, which was opened first:
Evidence — identical changed-file set (6 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving. Both choices match Dakota and GNOME OS: the noto-cjk element ships Serif as well as Sans, and the Symbols Nerd Font follows nerd-fonts-symbols.bst, with the contract asserting both fontconfig paths and the family name. Don't merge yet: google-noto-serif-cjk-vf-fonts (utah-packages#1147) and nerd-fonts-symbols (#1129) aren't in the factory, so the pin has to move after they publish. The red contract here comes from the stack's older copy of #1248 (factory pin 523507b8), so rebase onto the current #1248 (0b0664cb) before reading it.
There was a problem hiding this comment.
Summary: This change adds two fonts that Bluefin's Dakota image already ships: a serif font for Chinese, Japanese and Korean text, and a small icon font that terminal tools use for symbols. The change looks right and does what the issue asked. The one check that fails today fails only because the two new font packages haven't been published yet, which the description already says.
correctness (info, not blocking)
The failing contract job on this head (job 133104722877, head c26333d1) is just check-repos reporting No match for argument: google-noto-serif-cjk-vf-fonts and No match for argument: nerd-fonts-symbols. That's the factory-publish block the PR body describes. Both recipe PRs (projectbluefin/utah-packages#1129 and #1147) are merged, but the pinned factory image doesn't include their builds yet. The same job also can't find power-profiles-daemon, gnome-os-config-*, baobab and sushi. Those come from the base branch this PR is stacked on (#1294), not from this diff. The unit and doc-count checks in that job pass (Ran 1330 tests ... OK). Once the factory pin moves, this job should pass without further changes.
I checked the rest of the change and found no problems:
- The new contract paths (
contracts/bluefin-desktop.toml:172-173) match what the factory spec installs:conf.avail/10-nerd-font-symbols.confplus a relative/etc/fonts/conf.dsymlink, with%config(noreplace).scripts/verify-desktop-contract.py:278,315usesPath.is_file(), which follows that symlink, so thefile_containscheck on theconf.dpath is valid. - Both packages appear in
[parity](packages/utah.toml:221-222) and[factory].parity(packages/utah.toml:1021-1022). The count bumps from 261 to 263 and from 322 to 324 match the two additions.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
|
Note for this stack (#1295–#1308): none of it is folded into #1309. But its base, Reviewed on behalf of @hanthor with Claude Code |
|
The hive's GitHub App lacks |
|
Needs a decision, not a merge: the hive's GitHub App is not permitted to rerun shared ci (GitHub answered 403 Resource not accessible by integration); the Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
GNOME OS ships Noto Serif CJK beside the Sans CJK set Utah already carries, and Dakota's bluefin/nerd-fonts-symbols.bst adds the icon-only Symbols Nerd Font as the fallback for common's fastfetch config. Install both factory packages. nerd-fonts-symbols ships 10-nerd-font-symbols.conf in conf.avail and enables it from /etc/fonts/conf.d itself, as the element does; the desktop contract asserts both paths. Closes #1240 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @hanthor was auto-promoted after 5 clean merged PRs in this hive's repositories. |
Owner decision on #1240: adopt GNOME OS's Noto Serif CJK and Dakota's Symbols Nerd Font.
google-noto-serif-cjk-vf-fontsandnerd-fonts-symbols([parity]+[factory].parity).nerd-fonts-symbols(feat(nerd-fonts-symbols): add the Symbols Nerd Font icon fallback utah-packages#1129, written from Dakota'selements/bluefin/nerd-fonts-symbols.bst) ships10-nerd-font-symbols.confin/usr/share/fontconfig/conf.availand enables it with the same/etc/fonts/conf.dlink the element creates, so Utah adds no fontconfig file of its own. The desktop contract asserts both paths and theSymbols Nerd Fontfamily.desktop-contract/references/dakota-system-defaults.md.Factory: both publish at the c288398 pin (#1347) and resolve with
check-repo-availability.py. Rebased onto main after #1297 (one commit).Closes #1240
Verification:
umask 022; just checkpasses.