Skip to content

fix: restore the bluefin.toml parity contract - #108

Closed
hanthor wants to merge 1 commit into
mainfrom
claude/restore-bluefin-parity
Closed

hanthor wants to merge 1 commit into
mainfrom
claude/restore-bluefin-parity

Conversation

@hanthor

@hanthor hanthor commented Sep 17, 2026

Copy link
Copy Markdown
Member

just check-parity is red on main, and every open PR inherits the failure — #94 and #105 among them. This fixes it.

The drift

packages/bluefin.toml is meant to be a byte-for-byte copy of upstream's build_files/packages/base.toml. utah.toml says so outright: "it is the parity contract, and any drift there is a parity bug." Four hunks had accumulated — firefox moved into [fedora], and libgda, libgda-sqlite, ppp missing.

Why a bare sync would have been worse than the failure

All three missing names are absent from both repositories the image enables, measured by reading their repodata directly:

package pinned factory image public-hummingbird-x86_64-rpms
libgda absent absent
libgda-sqlite absent absent
ppp absent absent, and nothing Provides it

So curl upstream > packages/bluefin.toml hands three unresolvable names to the install transaction and converts a failing lint into a failing image build. The sync and the [unavailable] entries have to land together — hence one commit.

Tracking issues, as that list requires

#106 — libgda, libgda-sqlite. Upstream added both for the maintained Copyous extension (bluefin#1210). Hummingbird carries no package whose name contains gda at all. One factory recipe covers both: libgda-sqlite is a subpackage of the libgda SRPM, not its own source — Fedora's libgda.spec declares %package sqlite alongside ui, tools, sqlcipher, mysql and postgres.

#107 — ppp. This one turned out to matter more than dial-up trivia. Hummingbird ships NetworkManager-ppp (1.58.0-1.hum1 and 1.58.1-1.hum1) whose metadata carries Requires: ppp. With ppp nowhere in the enabled set, that plugin is uninstallable from Hummingbird's own repository, so NetworkManager's PPPoE and PPTP paths cannot be installed at all. Same shape as avahi (#104) and nautilus (#100): a plugin shipped without the daemon behind it. Probably worth reporting upstream to Hummingbird regardless of what Utah decides.

firefox needed no handling — it's already in [unavailable], and contract() filters that set out of every section, so moving it between sections can't put it back in the image. That matters: Utah ships org.mozilla.firefox as a Flatpak, and re-adding the RPM would regress that decision.

This installs nothing and removes nothing

Proven rather than argued — contract() run over main's two files and over this branch's both return the same 74 packages, no additions, no removals:

install set on main   : 74 packages
install set on branch : 74 packages
IDENTICAL: True
added  : (none)
removed: (none)
  libgda           in install set: False
  libgda-sqlite    in install set: False
  ppp              in install set: False
  firefox          in install set: False

Verification

  • Parity diff against upstream is now empty.
  • 23 tests, 45 subtests pass.
  • RPM contract check: 58 Bluefin, 10 GNOME, 5 service packages.
  • install-packages.py's own overlap guard confirms no [unavailable] package appears in the install set.

One thing I noticed but did not change

evolution-ews-core, fish and zsh predate this and carry no issue reference, so the file's "every entry MUST carry a tracking issue" rule isn't enforced by anything today. Worth a guard, but not in a commit whose job is restoring the contract — happy to add it separately if you want it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M


Generated by Claude Code

packages/bluefin.toml is meant to be a byte-for-byte copy of upstream
Bluefin's build_files/packages/base.toml. utah.toml says so in as many words
-- "it is the parity contract, and any drift there is a parity bug" -- and
just check-parity exists to make that loud. It has drifted, so that check is
red on main today and every open pull request inherits the failure, #94 and
#105 among them.

The drift is four hunks: firefox moved into [fedora], and libgda,
libgda-sqlite and ppp missing.

Syncing the file alone would have been worse than the failure it fixes. All
three missing names were measured against both repositories the image
actually enables -- the digest-pinned factory metadata layer from
Containerfile, and public-hummingbird-x86_64-rpms:

    libgda           absent from both
    libgda-sqlite    absent from both
    ppp              absent from both, and nothing Provides it

So a bare sync hands three unresolvable names to the install transaction and
turns a failing lint into a failing image build. The sync and the
[unavailable] entries have to land together, which is why they are one
commit.

Each entry carries a tracking issue, as that list requires:

  libgda, libgda-sqlite (#106)
    Upstream added both for the maintained Copyous extension
    (bluefin#1210). Hummingbird carries no package whose name contains gda
    at all. One factory recipe covers both, because libgda-sqlite is a
    subpackage of the libgda SRPM rather than its own source -- Fedora's
    libgda.spec declares %package sqlite alongside ui, tools, sqlcipher,
    mysql and postgres.

  ppp (#107)
    Worth more than dial-up trivia. Hummingbird ships NetworkManager-ppp,
    both 1.58.0-1.hum1 and 1.58.1-1.hum1, and its metadata carries
    Requires: ppp. With ppp nowhere in the enabled set that plugin is
    uninstallable from Hummingbird's own repository, so NetworkManager's
    PPPoE and PPTP paths cannot be installed at all. It is the same shape as
    avahi (#104) and nautilus (#100): a plugin shipped without the daemon
    behind it.

firefox needed no handling. It is already in [unavailable], and contract()
filters that set out of every section, so moving it between sections cannot
put it back in the image -- which matters, because Utah ships
org.mozilla.firefox as a Flatpak and re-adding the RPM would regress that
decision.

This change installs nothing new and removes nothing. Proven rather than
argued: contract() over main's two files and over this branch's both return
the same 74 packages, with no additions and no removals, and libgda,
libgda-sqlite, ppp and firefox are each absent from the resulting set.

23 tests pass, 45 subtests pass. The parity diff against upstream is now
empty, the RPM contract check reports 58 Bluefin, 10 GNOME and 5 service
packages, and install-packages.py's own guard confirms no [unavailable]
package appears in the install set.

Noted but deliberately not changed: evolution-ews-core, fish and zsh predate
this and carry no issue reference, so the "every entry MUST carry a tracking
issue" rule is not currently enforced by anything. Worth a guard, but not in
a commit whose job is restoring the contract.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

@castrojo could you review/approve? just check-parity is red on main and every open PR inherits it; this restores it with no change to the install set. Blocked only on the "approval from someone other than the last pusher" rule.

Note #110 (hive scanner) is the same fix — approving either one is enough; I'll close the other once one lands.


Generated by Claude Code

@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

Superseded by #110, which carried the identical change and merged as 83ad691. check-parity is green on main again.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants