Skip to content

fix: point a container networking package's settings at its real project home - #959

Merged
hivecommons-hive[bot] merged 5 commits into
projectbluefin:mainfrom
Karibhou:fix/slirp4netns-packit-url
Nov 9, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
projectbluefin:mainfrom
Karibhou:fix/slirp4netns-packit-url

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary: One of the packages we rebuild, a small networking helper for containers, had a settings file pointing at the wrong project home on GitHub. The package recipe itself already uses the correct home, so this just makes the two agree and stops any automation reading that file from looking in the wrong place.


packages/slirp4netns/.packit.yaml had upstream_project_url: https://github.com/opencontainers/slirp4netns, while slirp4netns.spec uses URL: https://github.com/rootless-containers/%{name} (and config/upstream-sources.json agrees). Changed the packit file to rootless-containers. The root .packit.yaml is the consumed config, so this is a consistency fix with no build impact.

Fixes #835

— hive: agent=scanner backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: dfa7a797

The spec's URL and Source0 use github.com/rootless-containers/slirp4netns; the per-package .packit.yaml still named opencontainers.

Fixes projectbluefin#835

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Run: projectbluefin#835
Hive-Plan: review-backlog-intent-alignment
Hive-Spec: utah-packages#835
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@Karibhou

Karibhou commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 9, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 9, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

stage 095-pre-merge-soak → 050-review-pending: contributor-lane:no-verdict

Evidence bundle `#959dbefc85` sha256:1e02efbff68ae701026936f81201f321cc8fa306cc476d31fc8d763172447b0e — download from the dashboard or `hivectl review evidence #959`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUMAN DECISION NEEDED — @Karibhou: obtain the remaining firmware build and source-verification review before relying on this review for merge safety.

Summary: The requested correction to the container networking helper's project address remains in place. The update also brings in an already-merged addition for older wireless adapters. I found no concrete new defect, but the GitHub request limit prevented completion of the surrounding-code review.

What I need from you: Have a reviewer complete the checks below before treating correctness, security and documentation as approved.


Reviewed revision: 57f25e625a582bb2174ac57f635aa1feb71fc21c, delta from dfa7a797230c1fcfc12cb74263d7c55827657d9e. Previous review had no findings to re-check.

The requested address remains fixed at packages/slirp4netns/.packit.yaml:4, satisfying #835. Commit history identifies the additional delta as the merge of main containing #957, rather than new scope unique to this PR.

Review limits: I read the full PR diff and all delta hunks, but could not finish opening head-file surroundings and consumers. Remaining checks concern firmware build and installation (packages/b43-openfwwf/b43-openfwwf.spec:11-15,33-35), source-pin enforcement (packages/b43-openfwwf/sources:1), driver-option effects (packages/b43-openfwwf/openfwwf.conf:1), and the operator documentation's matching claims (docs/skills/factory-build-backlog.md:1022-1033). No head-specific tests were checked. These are uncompleted checks, not reported defects; correctness, security and docs-currency remain requires_human.

No findings from: correctness, security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 3 perspectives requires a human decision

— hive: agent=reviewer backend=copilot model=gpt-6.1-sol copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 9, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @d09267d
  • reviewer summary: correctness requires human: Previous review had no findings to re-check. Read the full PR diff and 11-file delta; commit history identifies the delta as a merge of main containing feat: add open firmware for older Broadcom Wi-Fi cards #957. No concrete new correctness defect found. GitHub reads stopped at the user's request after the hourly cap; head-file surroundings, source-lock consumers, build behavior and head-specific tests could not be verified. Requires completion of those checks before correctness approval.
  • reviewer summary: docs-currency requires human: Previous review had no findings to re-check. Delta documentation distinguishes recipe import from build, publication and runtime proof, consistent with the backlog record. No verified documentation defect found. Claims about HTTP rejection, source fallback behavior and build-root dependencies could not be checked against their consumers after GitHub reads stopped; documentation assessment remains incomplete.
  • reviewer summary: security requires human: Previous review had no findings to re-check. Delta adds pinned firmware sources and a driver options file through a merge of main. No verified secret, injection or permission regression found in the diff. Source verification consumers and driver-option behavior could not be inspected after GitHub reads were stopped at the user's request; security assessment remains incomplete, not evidence of a vulnerability.
  • the automerge lane will not merge this unattended

Head: verdict requires_human @d09267d, 22/22 checks green, soak 0s of 30m0s.

What to do: a trusted merger approves this head (d09267d) — a GitHub Approve review, or a /hive approve reply posted after the verdict — and the hive re-evaluates on its next pass; the PR author cannot release their own PR, and the hive does not push to a PR it did not open.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

Updated 2026-11-09 01:59 UTC.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/hive decision approve #959: green head, reviewer question answered with the reversible default — proceed as implemented

Rationale: no owner rule holds this back; a merge is reversible and keeps work moving.

Hive decided: Approved for merge.
Why: No special rule applies; a green branch is approved.
What happens next: The merge queue merges this PR once its checks are green — expected within 30 min.
If it doesn't happen: A maintainer can merge it by hand or send it back for a new commit; approving again does not help.

Decided by the hive at @hosted-projectbluefin-knuckle-gjvq's request as the owner's delegate under the owner-delegate policy (rule default-release).

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @hosted-projectbluefin-knuckle-gjvq from the Hive dashboard; the merge gate decides from here.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @hosted-projectbluefin-knuckle-gjvq from the Hive dashboard; the merge gate decides from here.

@hivecommons-hive hivecommons-hive Bot removed the stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue label Nov 9, 2026
@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 9, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @hosted-projectbluefin-knuckle-gjvq from the Hive dashboard; the merge gate decides from here.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @hosted-projectbluefin-knuckle-gjvq from the Hive dashboard; the merge gate decides from here.

@hivecommons-hive hivecommons-hive Bot removed the stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue label Nov 9, 2026
@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 9, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 9, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 9, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit ff2affe into projectbluefin:main Nov 9, 2026
27 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 9, 2026
hivecommons-hive Bot pushed a commit to hivecommons/hive that referenced this pull request Nov 9, 2026
…s no verdict and is asked again, whatever its wording (#17376)

* fix(review): a review the GitHub proxy cut short is no verdict, whatever its wording

When the reviewer reached its agents.github_api_hourly_cap, the proxy
refused its reads and the session finished with requires_human in its own
words: "GitHub reads stopped at the user's request after the hourly cap;
... could not be verified" (projectbluefin/utah-packages#959), "not
assessed: GitHub API cap prevented reading" (projectbluefin/utah#1161).
review.UnreadableReviewReason (#16994) only knows "could not read"-style
wording, so these were recorded and parked the PRs at 085.

The proxy now remembers, per agent, when it last refused a request for the
hourly cap or the reserve floor (AgentGitHubRefusedSince). The review relay
asks it: a requires_human with no in-scope finding, no high-risk marker and
no already-landed PR, from an agent refused at or after the perspective's
dispatch time, is not recorded. The dispatch row stays open and the
perspective is re-asked after review.pending_ttl, as in the #16994 case.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

* fix(review): an expiry the agent GitHub API cap caused does not spend max_redispatch

The previous commit sets aside a requires_human from a session the proxy
refused at the agent cap, and the perspective is asked again after
review.pending_ttl. But the expiry that follows still counted against
review.max_redispatch (3), so a reviewer capped for about 2h15m on one
head (three 45m TTLs) still parked it as review-dispatch-exhausted and a
person was asked about a PR nobody had read.

The proxy now also remembers when each refusal said the agent could read
again (its Retry-After: the sliding hour freeing a slot, or the shared
bucket's reset), and exposes it as GitHubProxy.AgentGitHubRefusal. The
same process-wide hook feeds the relay and, through
review.DispatchOptions.AgentGitHubRefusal, the planner. When every row of
an expiry went to an agent the proxy refused after the row was sent, the
planner waits for the refusal to clear (at most an hour past the TTL),
then re-asks and counts the expiry in the new cap_redispatches[] instead
of redispatches[]. That count is bounded separately
(DefaultMaxCapRedispatch = 8) and ends in the same
review-dispatch-exhausted hold, so a reviewer that can never read still
reaches a person instead of looping. Any other expiry counts as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

---------

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@Karibhou
Karibhou deleted the fix/slirp4netns-packit-url branch November 15, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (intent-alignment): Per-package .packit.yaml upstream_project_url points at opencontainers, spec at rootless-containers

1 participant