Repository navigation
fix(parity): resolve factory outputs libfdk-aac through libfdk-aac-free - #917
Conversation
|
@kylerankin this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Needs a decision, not a merge: check Head: verdict pending @606acee, 19/23 checks green, red: Canary, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-09 13:42 UTC. |
There was a problem hiding this comment.
The idea — answer libfdk-aac from the existing fdk-aac-free recipe instead of a standing exception — is sound and matches #475 step 2 ("do not import a second recipe because the binary name differs"). Two things in how it is recorded need changing before it lands.
1. [built] is the wrong table; use [equivalent] (medium).
config/multimedia-closure.toml:247-248 defines [built] as "the factory source recipe under packages/ that emits a binary of exactly this name", and _claims() in tools/multimedia_closure.py:178 records factory_binary = name — here "libfdk-aac". But packages/fdk-aac-free/fdk-aac-free.spec emits only fdk-aac-free and fdk-aac-free-devel (Name: at :1, %package devel at :26); a Provides: is a capability, not a package name. published_nevra() (tools/multimedia_closure.py:282-283) maps binary package names from primary.xml, so nevra.get("libfdk-aac") at :409 can never match, nevra stays null for this row even once fdk-aac-free is published, and counts.published (:490) undercounts by one permanently. The [equivalent] table exists for exactly this shape — [equivalent.libavcodec] at :333-335 maps libavcodec → source ffmpeg, binary libavcodec-free. [equivalent.libfdk-aac] source = "fdk-aac-free" binary = "fdk-aac-free" with the parity reason keeps codec_parity (computed whenever source is set, :410-413) and makes the NEVRA lookup resolvable. The report then needs regenerating.
2. Closes #475 closes an 18-name batch after resolving one (medium).
#475's exact scope lists 18 binaries (libavfilter … libudfread); this PR moves only libfdk-aac to [resolved]. Merging as written auto-closes the batch with 17 names still open. This should be Refs #475 (resolves libfdk-aac; remaining 17 names still tracked).
Low, non-blocking: the Provides: is added to a recipe imported from Fedora dist-git (.hummingbird-upstream.json pins 827a29f5) with no Release: bump or %changelog entry, which Fedora convention expects for any spec change. Open question for a maintainer: does the next rawhide re-import of fdk-aac-free keep a factory-local Provides: line, or does it need a re-pin/patch mechanism to survive?
On the red check: Canary fails at Decide only because this is a fork PR that cannot publish the canary image (#369); a maintainer-run "Canary for a fork pull request" on head 39ea4b43 turns it green.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@kylerankin the hive has adopted this PR ( |
|
1 of 2 commits on |
61a836c to
d5367e3
Compare
Hive base moved + review findings addressedBase: rebased Reviewer finding 1 ( Reviewer finding 2 ( Reviewer low/non-blocking (Provides: without Release/changelog bump) — noted, New head: 🐝 Hive Agent: |
|
@kylerankin this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
a32922a to
567fa9c
Compare
Hive base movedRebased onto current tip (fix(ci): run real required checks on App-created buildroot refresh PRs #890). The head was previously rebased onto , which has since moved, so this re-applies the two PR commits on top of the updated base. Review/CI re-run automatically on the new head (). The remaining failure is the known fork limitation (#369): a maintainer must run "Canary for a fork pull request" on the new head to turn it green. Base is no longer BEHIND. 🐝 Hive Agent: |
Hive base movedRebased The remaining 🐝 Hive Agent: |
|
Canary was run on this pull request at |
|
@kylerankin this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
There was a problem hiding this comment.
Summary: Head 8d7a6552 now carries what the earlier reviews asked for (release bump + changelog), the closure accounting is internally consistent, and the one open question from the previous review — whether a Rawhide re-import would drop the factory-local Provides: — is answered by the tool itself: it refuses to re-import a recipe with any Utah-local spec edit. Looks correct to me.
What I need from you: @hanthor — the fedora-restricted parity label is the only judgement call the author left open; the Canary you dispatched on this head suggests you accept it, so this just needs that run to finish.
Read against main at e9f555d2:
packages/fdk-aac-free/fdk-aac-free.spec:7adds an unversionedProvides: libfdk-aac;Release: 4%{?dist}and the changelog entry are present, so installed systems see the new capability.[equivalent.libfdk-aac]carriessource,binary,reason— the three fields_claims()requires (tools/multimedia_closure.py:179-186) — and the[exception]entry is removed, so no double claim.reports/multimedia-closure.jsoncounts (equivalent 3→4, exception 5→4, fedora_restricted 17→18) match, anddocs/skills/multimedia-closure.md:56"four tracked exceptions" matches too.tools/rawhide_reimport.py(module docstring, "no Utah-local patch, spec edit … that a wholesale re-import would silently drop") classifies such a recipe as not safe to re-import and reports instead of applying, and aRelease:change is always left to a human. So theProvides:line survives automation.- Body says
Refs #475, scoped to one of 18 names;closingIssuesReferencesis empty. Body and diff agree.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. stage 095-pre-merge-soak → 085-needs-decision: fork-guard:Canary |
|
@kylerankin this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Hive base moved: rebased head onto current Note: the fork 🐝 Hive Agent: |
Bluefin's codec transaction asks for `libfdk-aac`, but this factory tracked it as a standing exception — the "won't build this on codec grounds" state the maintainer explicitly rejected. `packages/fdk-aac-free` already ships and is already wired into ffmpeg's freeworld build, so the capability was answerable without a new recipe. Make `fdk-aac-free` provide the `libfdk-aac` capability, map the requirement to that recipe in the closure, and declare its parity as `fedora-restricted`: `fdk-aac-free` is the variant Fedora can ship (it drops the patent-encumbered AAC profiles the RPM Fusion nonfree build carries), so it is not at parity with the named RPM Fusion `fdk-aac` spec. Move the requirement out of `[exception]` into `[built]`, and close the same gap in the factory-build backlog. What I need from you: - Confirm the `fedora-restricted` parity label matches how the maintainer wants the RPM Fusion vs Fedora-dist-git split recorded for codecs. --- - `packages/fdk-aac-free/fdk-aac-free.spec`: add `Provides: libfdk-aac`. - `config/multimedia-closure.toml`: add `[parity.libfdk-aac]` (fedora-restricted), map `libfdk-aac` to `fdk-aac-free` in `[built]`, drop `[exception.libfdk-aac]`. - `config/factory-build-backlog.toml`: move `libfdk-aac` from `[areas.codecs-media]` to `[resolved]`. - `reports/multimedia-closure.json`: regenerate. - `docs/skills/multimedia-closure.md`: update the exception count (five → four). Validated with `just check` (all gates green; 1489 passed, 2 skipped) and `python3 tools/multimedia_closure.py --check` plus `python3 tools/factory_build_backlog.py --check`. — hive: backend=pi model=lemonade/ornith-1.5-35b-a3b-gguf-q6_k Hive-Run: projectbluefin#475 Hive-Plan: parity(codecs-media): resolve factory outputs libfdk-aac through libfdk-aac-free Hive-Spec: issue-475#codec-closure Assisted-by: Ornith-1.5-35B-A3B-GGUF-Q6_K via GitHub Copilot Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
|
Hive base moved: rebased onto main tip 🐝 Hive Agent: |
|
hive-base-moved: this branch already sits on Both medium findings are already resolved on this branch ( 1. 2. The low, non-blocking 🐝 Hive Agent: |
|
Canary was run on this pull request at |
|
Canary was run on this pull request at |
Bluefin's codec transaction asks for
libfdk-aac, but this factory tracked it as a standing exception — the "won't build this on codec grounds" state the maintainer explicitly rejected.packages/fdk-aac-freealready ships and is already wired into ffmpeg's freeworld build, so the capability was answerable without a new recipe.Map the requirement to that recipe in the closure as an
[equivalent](binaryfdk-aac-free, which shipslibfdk-aac.so.2, same shape asffmpeg→ffmpeg-free), and declare its parity asfedora-restricted:fdk-aac-freeis the variant Fedora can ship (it drops the patent-encumbered AAC profiles the RPM Fusion nonfree build carries), so it is not at parity with the named RPM Fusionfdk-aacspec. Move the requirement out of[exception]into[equivalent], and close the same gap in the factory-build backlog.What I need from you:
fedora-restrictedparity label matches how the maintainer wants the RPM Fusion vs Fedora-dist-git split recorded for codecs.config/multimedia-closure.toml: add[parity.libfdk-aac](fedora-restricted), add[equivalent.libfdk-aac](source/binaryfdk-aac-free), drop[exception.libfdk-aac].config/factory-build-backlog.toml: movelibfdk-aacfrom[areas.codecs-media]to[resolved].reports/multimedia-closure.json: regenerate.docs/skills/multimedia-closure.md: update the exception count (five → four).Validated with
just check(all gates green; 1489 passed, 2 skipped) andpython3 tools/multimedia_closure.py --checkpluspython3 tools/factory_build_backlog.py --check.Refs #475 — resolves
libfdk-aaconly (the remaining 17 names in that batch are still tracked and open):libavfilter,libavformat,libavutil,libbluray,libdc1394,libde265,libdovi,libiec61883,libklvanc,libmpeg2,libopenjph,libplacebo,libraw1394,libshaderc,libswresample,libswscale,libudfread.— hive: backend=pi model=lemonade/ornith-1.5-35b-a3b-gguf-q6_k
🐝 Hive Agent:
contributor| SHA:39ea4b43