Repository navigation
Conversation
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@mendezr the hive has adopted this PR ( |
hanthor
left a comment
There was a problem hiding this comment.
Needs a rebase and a hosted build. xmlsec1-openssl-devel, libtirpc, rpcgen and procps-devel have no recipes here, so please confirm the build root provides them. Also check that the run-vmblock\x2dfuse.mount source is staged correctly.
|
The hive adopted this PR ( Blocker: this PR comes from a fork ( Moving to |
|
Merged current |
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Follow-up |
|
stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:no-verdict |
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@mendezr the hive has adopted this PR ( |
|
@mendezr this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Import the open-vm-tools source family and its required libmspack library. Lock upstream release archives, register both recipes and reconcile the three audit names. Keep hosted build, publication and guest runtime acceptance outstanding on projectbluefin#488. Assisted-by: openai-codex/gpt-6.1-sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Run: projectbluefin#488 Hive-Plan: VMware guest integration source-family import Hive-Spec: issue-488#implementation-3 Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Regenerate architecture counts and backlog totals from the combined PR inventory. Document that automatic conflict-free merges do not refresh generated inventory. Assisted-by: GPT-5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mendezr <mendezr@users.noreply.github.com>
460d779 to
db0fd8b
Compare
There was a problem hiding this comment.
Summary: Re-review after the branch was rebuilt on top of the latest main. The earlier problem (the architecture document clashing with main) is fixed: the branch now merges cleanly and its package counts match what is actually in the tree. One thing left: the pull request description still says it adds the archive-reading library, but that library already landed on main separately and this branch no longer adds it, so the description overstates what will merge.
What I need from you: Trim the description so it only claims the VMware guest-tools import.
Reviewed at head db0fd8b (the queued head 460d779 was replaced by a rebase; the PR now carries two commits, 8b2a490f + db0fd8b2). Previous finding — docs/architecture.md merge conflict with main: fixed (mergeable: MERGEABLE; docs/architecture.md:81,133,137-139,144,163 now read 702, and the head tree has 702 packages/* directories, 702 .packit.yaml entries and 702 config/upstream-sources.json entries).
intent-alignment
- (low) PR body "## Change" still claims: "Import required
libmspack0.11 from dist-git commitc5b36307…" and "Download both upstream archives … Register HTTPS source locks". The diff against main touches nopackages/libmspack/*file and adds exactly one lock entry (config/upstream-sources.json:4-10,open-vm-toolsonly).libmspackis already on main via #846, and this PR's own skill text says so (docs/skills/factory-build-backlog.md:343-345: "already imported onmainby #846 … do not retain #812's older duplicate lock or catalog record"). Update the body (and the body's "three audited names" / "both archives" wording) to describe only theopen-vm-tools+open-vm-tools-desktopimport.
No findings from: correctness, security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@mendezr the hive has adopted this PR ( |
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#861:2/7:0/0:.packit.yaml,factory-build-backlog.toml,upstream-sources.json,architecture.md,+15 |
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: check-pending |
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: pending: head pushed 1m42s ago (< min_head_age) |
|
hive: rebase onto main touches .github/workflows/ and the hive App cannot push workflow changes; a maintainer must rebase this PR. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 |
|
hive: rebase onto main done locally but push rejected: rebased history includes main's changes to 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 |
|
The hive adopted this PR ( Blocker: this PR comes from a fork ( Moving to |
|
Re-homed to #892 as an in-repo branch ( |
* feat: add VMware guest tools and CAB extraction recipes Import the open-vm-tools source family and its required libmspack library. Lock upstream release archives, register both recipes and reconcile the three audit names. Keep hosted build, publication and guest runtime acceptance outstanding on #488. Assisted-by: openai-codex/gpt-6.1-sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Run: #488 Hive-Plan: VMware guest integration source-family import Hive-Spec: issue-488#implementation-3 Signed-off-by: mendezr <mendezr@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com> * docs(factory-build-backlog): record the VMware guest-tools build-root providers Re-homing #812 onto main: libmspack is already a published factory recipe (#846), so the skill no longer tells an importer to bring it in. Answer the open review question on #812: Hummingbird provides xmlsec1-openssl-devel, libtirpc-devel and procps-ng-devel (procps-devel), Fedora 44 provides rpcgen, and the factory provides gtkmm4.0-devel, so no provider recipe is needed. Assisted-by: Claude Opus via omp Signed-off-by: James Reilly <jreilly1821@gmail.com> --------- Signed-off-by: mendezr <mendezr@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com> Co-authored-by: mendezr <mendezr@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* fix: fetch two Python packages from their publisher Move python-argcomplete and python-dasbus to their verified PyPI source archives. Keep the existing SHA-512 locks and Fedora URLs as fallbacks. Hive-Run: #42 Hive-Plan: supply-chain source-lock migration batch Hive-Spec: issue-42#upstream-release-provenance Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com> * docs: explain fork Canary approval for source migrations Document the maintainer-run proof required for fork source-lock changes and why local checks or another fork run cannot replace approval. Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com> * docs(lane-validation): record re-homing a fork PR whose Canary proof cannot survive A fork pull request whose fork Canary proof is discarded by every merge from main (or that changes .github/) cannot stay green as a fork PR. Record the maintainer path used for #812, #877 and #862: cherry-pick the PR's own commits onto an in-repo hive/adopt-<N> branch with sign-off and open a new PR. Assisted-by: Claude Opus via omp Signed-off-by: James Reilly <jreilly1821@gmail.com> --------- Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com> Co-authored-by: mrbobbytables <mrbobbytables@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Fill published_run/published_nevra for all 17 #488 outputs observed in ghcr.io/projectbluefin/utah-packages@sha256:11318e23d0f093c58fa8136e48ae7c8acae9e849c272152055473b707aff5d72 (run 42559053279, revision ff2affe): mtr, nano, nfs-client-utils, nfs-common-utils, nfs-utils, nfsv3-client-utils, nfsv4-client-utils, nilfs-utils, ntfs-3g-system-compression, nvme-cli, nvtop, oddjob, oddjob-mkhomedir, open-vm-tools, open-vm-tools-desktop, pinentry, pinentry-gnome3. Point nilfs-utils and open-vm-tools* at their merged adoption PRs (#715, #892) instead of the closed proposals (#702, #812). Record that the image's factory-state label marks mtr, ntfs-3g-system-compression and open-vm-tools as failed at their current input digest, so their published RPMs are retained older builds. Runtime proof stays open on the issue. Refs #488 Assisted-by: Claude Opus via omp Hive-Run: #488 Hive-Plan: factory-build-backlog dev-tools reconciliation Hive-Spec: issue-488#acceptance-publication-evidence Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: Karibhou <Karibhou@users.noreply.github.com>
… base changed workflows (#17549) A fork PR the hive cannot finish because its base changed .github/workflows/ parked at 085 (adoption-stalled:fork-rehome-refused) with a general "bring it into the repository yourself or close it" ask. GitHub refuses any App push to a fork that carries a workflow change, whatever the App is granted on the base repository, so the one action is a person's branch update. The note now reads the fork's maintainer_can_modify and the base-side workflow change when it is posted and names that action (Update branch / gh pr update-branch, or a local merge on a conflict), or the author's step when maintainer edits are off. Refs projectbluefin/common#1611, projectbluefin/utah-packages#812 Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary: This prepares packages that help Utah work inside VMware virtual machines, including communication with the host and desktop integration. The archive-reading library those tools need is already on
main(#846). The build instructions and verified source downloads are ready for review, but successful builds and working guest integration have not yet been demonstrated.What I need from you: Review the imports and run a scoped hosted build before merging.
Refs #488 — partial recipe work only; hosted builds, publication, permitted-repository installation and runtime acceptance remain outstanding. Consumer tracking: projectbluefin/utah#392.
Change
open-vm-tools13.1.0 from Fedora Rawhide commitfde796d78f05621fce6852be53b70558ddb7f14e. Its unconditional desktop subpackage coversopen-vm-tools-desktop; no duplicate source recipe.libmspack(suppliespkgconfig(libmspack)) is already imported onmainby feat: add build instructions for the Microsoft CAB archive library #846; this PR does not touch it. The dependency graph orders it before the guest tools without a manual stage.open-vm-toolsarchive and verify its SHA-512 against the importedsourcesfile. Register its HTTPS source lock, regenerate Packit configuration and architecture counts, move the two audited namesopen-vm-toolsandopen-vm-tools-desktopto[resolved], and regenerate the backlog report. The original audit name set is preserved.%check; its existing comment explains the documentation-font regeneration problem. No tests were disabled here.libmspackdependency (feat: add build instructions for the Microsoft CAB archive library #846) and guest-only runtime checks.dce44b5a6b2eec5037b83b20d1ff16504ff9b005records both guest-tool outputs asplanned, not waived. No consumer files are changed.Batch dispositions
Publication observations below come from one factory image, not from this PR's unbuilt recipes. Each existing catalog record is retained unchanged.
mtrmtr, #5872:0.96-2.hum1.bfin.x86_64nanonano, #5140:9.2-1.hum1.bfin.x86_64nfs-client-utils,nfs-common-utils,nfs-utils,nfsv3-client-utils,nfsv4-client-utilsnfs-utils, #5241:2.9.2-1.rc1.hum1.bfin.1.x86_64nilfs-utilsnilfs-utils, #7020:2.2.11-9.hum1.bfin.x86_64ntfs-3g-system-compression0:1.1-5.hum1.bfin.x86_64nvme-clinvme-cli, #5870:2.16-6.hum1.bfin.x86_64nvtopnvtop, #4100:3.3.2-1.hum1.bfin.x86_64oddjob,oddjob-mkhomediroddjob, merged #784open-vm-tools,open-vm-tools-desktopopen-vm-tools, this PRpinentry,pinentry-gnome3pinentry, #5240:1.3.3-1.hum1.bfin.x86_64Required cross-area dependency:
libmspackalready has a recipe-only closing record from #846; this PR leaves it unchanged. Its publication and runtime closure also remain outstanding.Repository evidence
Observed 2026-10-29:
sha256:9e51f9ec56c06e689c6a5cdd36be51fe26b029f608bdd67cfdb94a21cd0565e2; publishing run https://github.com/projectbluefin/utah-packages/actions/runs/40867605194. Primary metadata checksum:1091d24d76fb4ae03ad69b8085a77cd0138921aef1e60d4ac03cc7fed557218f.tools/package_index.py, then read each binary's own version, architecture and source RPM from primary metadata fetched by that digest. Neither this factory snapshot nor Hummingbird containsopen-vm-tools,open-vm-tools-desktoporlibmspack.df2598e809f5d2527d4ad1f521cccc521370f54507c5aac9f4d42ec3ec08996d. It provides the explicit runtime requirementscoreutils,fuse3,grep,iproute,sed,tar,util-linux,whichandxmlsec1-openssl; the factory providespciutils, GTK4 and gtkmm4. This is a static preflight, not a successful dependency transaction or a complete generated-RPM dependency audit.07086e2403bc4ab9727822ccfb7152e479f326a1d33c533bdcfb38b5ade8aa2ed3bc244130ab794ad5b99d9a0b3c3caecf0f37e2e1695bd97213f2236490bbb4.Validation
python3 tools/factory_build_backlog.py --check: passed, 207 remaining entries / 194 pending.just check: passed, including configuration validation and 1396 tests passed / 2 skipped.just test: passed separately, 1396 passed / 2 skipped.pre-commit run --all-files: unavailable becausepre-commitis not installed on this host.Remaining acceptance
No hosted build run, resulting binary NEVRA, new publication digest, installation transaction or VMware payload test is claimed for this import. A scoped production-backend build must include
libmspack(from #846) andopen-vm-tools. Inspect the built RPM requirements, resolve installation using only Hummingbird plus the factory, then verifyvmtoolsd,vmware-toolbox-cmd stat hosttime, desktop resizing and clipboard transfer in a VMware guest. The batch stays open: the other outputs' publication observations above also do not prove their runtime acceptance, and oddjob is not yet present in the observed image.— hive: backend=pi model=openai-codex/gpt-6.1-sol