Skip to content

fix: fetch two Python packages from their publisher - #909

Merged
hivecommons-hive[bot] merged 7 commits into
mainfrom
hive/adopt-862
Nov 6, 2026
Merged

hivecommons-hive[bot] merged 7 commits into
mainfrom
hive/adopt-862

Conversation

@hanthor

@hanthor hanthor commented Nov 6, 2026

Copy link
Copy Markdown
Member

Summary: Two Python libraries now download their build files from the Python package publisher instead of Fedora. Their existing file checks are unchanged, and Fedora remains available as a backup.

What I need from you: Review it. This branch lives in the repository, so its own Canary supplies the proof.

Re-homed from #862 by a maintainer: the fork could not be updated by the hive (fork guard / workflow permission), and every merge from main discarded the fork Canary proof. Original author: @mrbobbytables.


Changes

  • Move python-argcomplete and python-dasbus to their PyPI source archives.
    • Each archive was streamed and its SHA-512 matches the existing lock.
    • Versions, filenames, feeds and digests are unchanged; each Fedora URL is kept as a fallback.
  • Remove both packages from config/fedora-primary-sources.txt.
  • Document how to find and verify a PyPI source archive in the supply-chain guidance.
  • Document how a maintainer supplies Canary proof for a fork PR via canary-fork-pr.yml.

Re-home notes

Verification

  • just check passed: validated 730 source RPMs, 1491 tests and 3019 subtests.
  • just factory-check passed.

Remaining work

  • python-typing-inspection stays on the list. Its fixed native Canary availability contract requires a separate source change and native-runner validation.
  • enchant2 stays on the list because its candidate GitHub release archive did not match the existing SHA-512.
  • graphene stays on the list because its candidate GitHub release URL returned 404.
  • kde-filesystem (teamnames) and kf5 (macros.kf5) remain Fedora-primary. They are Fedora package metadata and RPM macros, not upstream release archives, and their URLs are already pinned to fixed Fedora commits.
  • Other entries remain unchanged and need individual source verification.

Refs #42 — this batch moves two locks; the rest of the Fedora-primary list remains, so the issue stays open.

mrbobbytables and others added 3 commits November 6, 2026 10:46
Move python-argcomplete and python-dasbus to their verified PyPI source archives. Keep the existing SHA-512 locks and Fedora URLs as fallbacks.

Hive-Run: #42
Hive-Plan: supply-chain source-lock migration batch
Hive-Spec: issue-42#upstream-release-provenance
Assisted-by: Auto mode via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
Document the maintainer-run proof required for fork source-lock changes and why local checks or another fork run cannot replace approval.

Assisted-by: Auto mode via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
…cannot survive

A fork pull request whose fork Canary proof is discarded by every merge from
main (or that changes .github/) cannot stay green as a fork PR. Record the
maintainer path used for #812, #877 and #862: cherry-pick the PR's own
commits onto an in-repo hive/adopt-<N> branch with sign-off and open a new PR.

Assisted-by: Claude Opus via omp
Signed-off-by: James Reilly <jreilly1821@gmail.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against main and the validator it has to satisfy. Looks correct to me.

What I verified:

  • Streamed both new primary URLs and hashed them: argcomplete-3.6.3.tar.gz → d07756a8…fa43a0a, dasbus-1.7.tar.gz → ccf575d2…3d8a873. Both match the unchanged sha512 locks in config/upstream-sources.json, so this is a transport-only move as the body says.
  • fallback_urls is the established key (443 entries already use it; tools/source_pipeline.py consults it after an upstream transport failure), and the Fedora lookaside URL is preserved there verbatim.
  • tools/validate.py:162 check_fedora_primary_sources is a shrink-only ratchet: it fails if a name stays in config/fedora-primary-sources.txt after its primary URL leaves Fedora. Removing the two lines is therefore required by the lock change, not optional cleanup.
  • .github/workflows/canary-fork-pr.yml exists at this head, so the new supply-chain-provenance.md link resolves.

Refs #42 is the right citation: the rest of the Fedora-primary list remains and the body says so.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 6, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the two lock entries against the tree and the pipeline that consumes them. Looks correct to me.

Verified

  • Streamed both PyPI archives and hashed them: argcomplete-3.6.3.tar.gz → d07756a8…fa43a0a, dasbus-1.7.tar.gz → ccf575d2…3d8a873. Both match the unchanged sha512 in config/upstream-sources.json (lines 5069/5094 as patched), so this is a transport-only move.
  • fallback_urls is already a first-class key: tools/source_pipeline.py:337-351 validates it and feeds fetch_with_fallbacks([url, *fallback_urls], …); 441 existing entries use it. Keeping the Fedora lookaside URL there is the established shape, not a new mechanism.
  • Removing the two names from config/fedora-primary-sources.txt is consistent with the primary URL no longer being a Fedora host (the list is what tools/canary.py:83 and the validator key off).
  • Checks on c238719: 70 pass, 99 skipped, 0 failing; mergeable CLEAN.

Docs additions (supply-chain-provenance.md, lane-validation.md) describe the procedure actually used here; Refs #42 is right since the list still has entries.

Nothing blocking from my side.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Nov 6, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 6, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 95a3c59 into main Nov 6, 2026
169 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#90974207c9` sha256:c17419961e4b75b6a09b3ee111f4c7e98cd1be4552da58eb85495e5bdd2e527b — download from the dashboard or `hivectl review evidence #909`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @hanthor was auto-promoted after 5 clean merged PRs in this hive's repositories.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants