Skip to content

feat: add build recipes for the VM networking and streaming-video libraries - #789

Merged
hanthor merged 3 commits into
mainfrom
hive/503-libslirp-librtmp
Oct 30, 2026
Merged

hanthor merged 3 commits into
mainfrom
hive/503-libslirp-librtmp

Conversation

@Danathar

@Danathar Danathar commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary: Utah is the Bluefin desktop build. It gets its software from a small "factory" in this repository, which rebuilds the packages that Red Hat's minimal base system doesn't provide. This change adds build recipes for two more missing pieces: a library that gives virtual machines network access without special permissions, and a library that streaming-video tools use to receive live streams. Neither project publishes a ready-made download, so the factory now rebuilds their source code from the projects' own version history in a way anyone can repeat and check. This is one more step in a batch that earlier added a disk/network library, a serial file-transfer tool (#742) and two other libraries (#756). The batch issue stays open.

What I need from you: Review it. This branch is in the main repository, so its build check can run.


Refs #503 (partial: 2 of the 5 names still outstanding in this batch; see "Remaining" below)

What changed

Binary Source recipe Disposition Evidence
libslirp libslirp 4.9.6-1 (Fedora Rawhide f92164cc, also builds -devel) imported, [resolved] Source0 is a generate entry: tag v4.9.6 of https://gitlab.freedesktop.org/slirp/libslirp.git, pinned to commit 392af902…, run through git archive and xz preset 6. The output SHA-512 66cf1461…c00be49 equals Fedora's dist-git pin, so sources is unchanged.
librtmp rtmpdump 2.6-6 (Fedora Rawhide 4d382e19, also builds rtmpdump, librtmp-devel) imported, [resolved] Source0 is a generate entry: tag v2.6 of https://git.ffmpeg.org/rtmpdump.git, pinned to commit 138fdb25… (the spec's own %global commit). The decompressed tar is byte-identical to Fedora's lookaside tarball. Fedora's gzip stream is zlib-ng output, which neither GNU gzip nor Python's zlib can reproduce, so the archive is gzip -n -9 and sources is repinned to 423d7c94…ff7b9913. Generated twice: same bytes.

How it works: tools/generated_sources.py now has GIT_ARCHIVE_SOURCES. For each entry it fetches only refs/tags/<tag> into an empty repository, refuses to continue if the tag no longer resolves to the pinned commit, and writes git archive --format=tar --prefix=<name>-<version>/. It fetches only the tag because git.ffmpeg.org advertises refs that point at the all-zero object, and a plain git clone fails on them (upload-pack: not our ref 0000…).

Build dependencies, checked against Hummingbird's current repodata: nettle-devel 4.0 (which rtmpdump-nettle4.patch needs), gnutls-devel 3.8.13, libgcrypt-devel 1.12.4, glib2-devel 2.90.1, meson 1.12.1, git-core 2.56.0. No cross-batch blockers.

Also included: .packit.yaml, docs/architecture.md and reports/factory-build-backlog.json regenerated; libslirp and librtmp moved to [resolved]; new tests in tests/test_generated_sources_generate.py (a local tagged repository: xz/gz output, reproducibility, moved-tag refusal, an unpinned version refused before git runs); and the method written up in docs/skills/factory-build-backlog.md.

Not yet proven

Remaining in #503

  • lilv-libs: needs the lv2/serd/sord/sratom chain (zix is already a recipe).
  • libreport-filesystem: large source package; not started.
  • lockdev: no upstream serves its MD5-pinned 2011 snapshot. Moving it to [wontfix] needs a linked maintainer decision.

Validation

  • python3 tools/generated_sources.py libslirp|rtmpdump packages/<name> <out>: digests above
  • python3 tools/factory_build_backlog.py --check: consistent (227 entries, 213 pending)
  • just check: pass
  • just test: 1395 passed, 2 skipped
  • pre-commit isn't installed here; CI runs it.

🤖 Generated with Claude Code

— hive: backend=claude model=claude-opus-5-5


🐝 Hive Agent: contributor | SHA: fcc4cfce

Danathar added a commit that referenced this pull request Oct 28, 2026
Refs #503

Hive-Run: #503
Hive-Plan: issue #503 Implementation step 5 (backlog reconciliation)
Hive-Spec: factory-build-backlog#closing-a-backlog-gap
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity.

@Danathar
Danathar force-pushed the hive/503-libslirp-librtmp branch from 30fe811 to 37a4842 Compare October 28, 2026 15:34
Danathar added a commit that referenced this pull request Oct 28, 2026
Refs #503

Hive-Run: #503
Hive-Plan: issue #503 Implementation step 5 (backlog reconciliation)
Hive-Spec: factory-build-backlog#closing-a-backlog-gap
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, and I reproduced the generator's claims rather than taking them from the comments:

  • libslirp: ran the exact sequence in tools/generated_sources.py:1047-1065 by hand (git fetch --depth 1 … refs/tags/v4.9.6 → rev-parse FETCH_HEAD^{commit} = 392af902… → git archive --prefix=libslirp-4.9.6/ → lzma xz/CRC64/preset 6). SHA-512 is 66cf1461af28…, which is both the new lock entry in config/upstream-sources.json and Fedora's own sources digest at the imported dist-git commit. The "byte for byte" comment at generated_sources.py:986-989 holds.
  • rtmpdump: the git archive tar of 138fdb25… is cmp-identical to Fedora's lookaside rtmpdump-2.6.tar.gz once gunzipped, and gzip -n -9 over it gives 423d7c94…, the digest the PR pins in packages/rtmpdump/sources. So the re-pin away from Fedora's gzip digest (7ebe4fe5…) is justified exactly as generated_sources.py:989-991 describes — same tar, different deflate stream.
  • Both specs are byte-identical to Fedora dist-git at the commits in .hummingbird-upstream.json.
  • _git_archive_generate fails closed on a moved tag before writing anything (:1059-1061), and tests/test_generated_sources_generate.py:329-402 covers the unpinned-version, moved-tag, gz-reproducibility and metadata paths against a local repo, so the suite does not depend on network.

One thing worth stating for the record, not a defect: both locks now depend on git archive's tar writer and the xz/gzip encoders staying stable across tool versions (I reproduced with git 2.47.3 / gzip 1.13). If a future runner image changes either, the pipeline will fail closed with a digest mismatch rather than ship different bytes, which is the right failure — just expect that to be the symptom.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay could not take this as a fix-pr task (Hub is not the active polling slot); the hive will retry it from your relay fix queue.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (4 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (5 waiting): fixes are handed out before new work as soon as you have capacity.

1 similar comment
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (5 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 29, 2026

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. It only needs a rebase onto main and regenerated counts.

@hivecommons-hive hivecommons-hive Bot added the stage/stalled In its current stage longer than expected label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you (stage/074-adopted-by-hive → stage/072-returned-to-contributor). It will nudge again if CI stays red.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) stage/stalled In its current stage longer than expected labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read tools/generated_sources.py against the existing generators and the two new recipes; this looks correct to me.

What I verified:

  • _git_archive_generate (tools/generated_sources.py, new block after _bluefin_artwork_generate) fetches only refs/tags/<tag>, peels FETCH_HEAD^{commit}, and raises before writing anything if the tag no longer resolves to the pinned commit. The unpinned-version check runs before any subprocess call. Both paths are covered in tests/test_generated_sources_generate.py::GitArchiveGenerateTests.
  • gzip -n -9 strips the mtime, so the rtmpdump archive is reproducible; the test asserts bytes 4–8 are zero and that two runs are identical.
  • config/upstream-sources.json generate entries carry the same digests as packages/libslirp/sources and packages/rtmpdump/sources, and rtmpdump.spec:1 pins the same %global commit 138fdb25… that GIT_ARCHIVE_SOURCES does.
  • libslirp.spec:11 has BuildRequires: git-core, which %autosetup -S git_am (line 31) needs.

One clarification for whoever merges, since the green checks can read as more than they are: the pass1/pass6 jobs on this PR built the Canary's fixed smoke set (libical, vulkan-headers, vulkan-loader) — not libslirp or rtmpdump. The body's "Hosted build: not run yet" is still accurate after CI; the [resolved] entries record the recipe import only, as the body says.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak → 072-returned-to-contributor: conflicting

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 30, 2026
Danathar and others added 3 commits October 30, 2026 13:52
…raries

Import Fedora Rawhide libslirp 4.9.6 (user-mode networking for virtual
machines) and rtmpdump 2.6 (builds librtmp) for long-tail batch #503.

Neither project publishes a release file. Add a git-archive generator to
tools/generated_sources.py: fetch the upstream tag, require that it still
resolves to the pinned commit, and `git archive` it under <name>-<version>/.

- libslirp: xz preset 6 over the git archive tar reproduces Fedora's
  pinned tar.xz byte for byte, so `sources` is unchanged.
- rtmpdump: the tar is byte-identical to Fedora's, but the packager's
  zlib-ng gzip stream is not reproducible, so the archive is `gzip -n -9`
  and `sources` is repinned to the generated digest.

Move libslirp and librtmp to [resolved], regenerate .packit.yaml, the
architecture counts and the backlog report, and record the method in the
factory-build-backlog skill.

Refs #503

Hive-Run: #503
Hive-Plan: issue #503 Implementation steps 2-5 (long-tail batch)
Hive-Spec: factory-build-backlog#closing-a-backlog-gap
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Refs #503

Hive-Run: #503
Hive-Plan: issue #503 Implementation step 5 (backlog reconciliation)
Hive-Spec: factory-build-backlog#closing-a-backlog-gap
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Signed-off-by: hanthor <hanthor@users.noreply.github.com>
@hanthor
hanthor force-pushed the hive/503-libslirp-librtmp branch from 62d1891 to 81b8a97 Compare October 30, 2026 13:53
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you (stage/074-adopted-by-hive → stage/072-returned-to-contributor). It will nudge again if CI stays red.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 30, 2026
@hanthor
hanthor merged commit e62e2c4 into main Oct 30, 2026
169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants