Repository navigation
feat: prepare libraries for audio plugin discovery - #831
Conversation
There was a problem hiding this comment.
Summary: This change adds build recipes for four audio-plugin libraries. The recipes themselves look sound and follow how the two sibling libraries already in this repository are packaged. Two bookkeeping problems remain: the description tells GitHub to close the whole 18-package tracking issue even though only 3 of its packages are addressed here, and the catalog entries leave out the pull-request number that the project's own guide asks for.
What I need from you: Remove the closing line from the description and add the PR number to the three catalog entries.
intent-alignment
- high — PR body ends with
Closes #503while the same body says "Refs #503 — partial: …libreport-filesystemandlockdevremain outstanding". #503 lists 18 outputs; this PR resolves 3 (config/factory-build-backlog.toml:755-757), and the issue's Boundaries say "this batch closes only when every named output is resolved or explicitly blocked by a linked decision". Merging as-is auto-closes #503 with 15 outputs still pending. Earlier partial PRs on this issue (#742, #756, #789) deliberately usedRefsonly. Fix: delete theCloses #503line from the PR description (keepRefs #503).
style
- low — The three new
[resolved]records (config/factory-build-backlog.toml:755-757) are the only entries in the file without aprfield.docs/skills/factory-build-backlog.md:83-85says: "Once the import PR has a number, populateprbefore requesting review; … For a recipe-only record, use{ name = "<n>", pr = <n> }". Siblingslibslirp/librtmpdirectly below carrypr = 789.{ name = "lilv-libs", pr = 831 }, { name = "sord", pr = 831 }, { name = "sratom", pr = 831 },
No findings from: correctness, security, docs-currency.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: conflicting |
|
@mendezr the hive has adopted this PR ( |
38b7b55 to
c49a4c2
Compare
Import lilv, lv2, sord and sratom recipes with upstream release locks. Reuse serd and zix and let BuildRequires determine build order. Record recipe availability separately from publication and runtime acceptance. Assisted-by: GPT-6.1-sol via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Hive-Run: projectbluefin#503 Hive-Plan: issue-503-source-family-closure Hive-Spec: issue-503#implementation-3 Signed-off-by: mendezr <mendezr@users.noreply.github.com>
c49a4c2 to
831d8fc
Compare
|
@mendezr this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
Summary: This repository builds extra software for the Utah desktop. This change adds a library that helps audio applications find and use sound-processing plugins, along with the libraries it needs. It prepares those packages for building; it does not yet prove that they are published or installable.
What I need from you: Review the recipes and arrange the trusted hosted build and installation checks.
What changed
Refs #503 — partial: this adds the
lilv-libssource family;libreport-filesystemandlockdevremain outstanding, and publication/runtime acceptance is still required.lilvlilv-libs, discovery commands and development/Python packages1fe06afae139572627bab1bbe12b914406b9a923lv2671afbf29d5c9b88bd97da27daa33b1f6664fe14sord0f082e929d3771870124b429be1a43a255968919sratom8017f9361be83cece153c07d14348560a900d1dbtools/import_rawhide.py, preserving recipe provenance, patches, signing keys and signature checks.sourcespins.gpgvagainst the dearmored upstream key: good signatures from David Robillard, fingerprint907D226E7E13FA337F014A083672782A9BF368F3.serdandzixrecipes. BuildRequires supplies the acyclic dependency order; no manual stages added.lilv-libs,sordandsratomto the catalog's recipe-available[resolved]list, explicitly without publication claims.Validation
python3 tools/factory_build_backlog.py --check: passed.just check: passed.just test: 1,408 passed, 2 skipped.packages/powerstat/packit.yamland ShellCheck SC2129 in.github/workflows/rebuild-rpms.yml.git diff --checkreports whitespace in those unchanged imports.Acceptance still owed
No binary build, published NEVRA, repository OCI digest or runtime installation result is claimed. The recipes still need the GitHub-hosted hermetic Mock workflow using the digest-pinned factory buildroot. No publication gate was bypassed.
After publication, resolve the runtime dependency set with Hummingbird plus the factory only, install
lilvandlilv-libs, runlv2ls, and loadliblilv-0.so.0. Record exact commands/results, built NEVRAs, run URLs and the published digest against consumer issue projectbluefin/utah#263. The imported recipes retain their existing test configuration; this change does not disable additional tests.— hive: backend=pi model=openai-codex/gpt-6.1-sol
Refs #503
🐝 Hive Agent:
contributor| SHA:38b7b55d