Skip to content

feat: prepare security key sign-in packages - #776

Merged
hanthor merged 7 commits into
projectbluefin:mainfrom
Karibhou:hive/478-pam-u2f-20261028
Oct 30, 2026
Merged

hanthor merged 7 commits into
projectbluefin:mainfrom
Karibhou:hive/478-pam-u2f-20261028

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Summary: This prepares software that lets people use a security key when signing in. It adds the build instructions for both the sign-in component and its setup tool. The packages still need a hosted build and a real sign-in test before users can rely on them.

What I need from you: Review the recipe and run the hosted build and authentication checks.


Refs #478 — partial: adds recipe coverage for pam-u2f and pamu2fcfg; the other outstanding outputs, publication, dependency resolution and authentication proof remain open. Consumer tracking: projectbluefin/utah#389.

  • Import Fedora Rawhide pam-u2f 1.4.0-9 at commit 5b713d39c3a349036b81234c96c7a83cfcd1bdbc, retaining its signing keyring, signature verification and tests. The recipe produces both requested binaries.
  • Lock the upstream archive to SHA-512 6ee4c5538a3b290748fae3b8c285b20a784fe2c0fdeff3a0bf250ec9b03659c6ddda4ea2d668c93d606f810e4f68cf3fc4130584a8532db9c9833a684d78f51f. The detached signature matches the SHA-512 in sources and verifies with the imported keyring; the key's identity was not independently verified.
  • Register the recipe in Packit, record recipe-level coverage in the backlog, refresh generated inventories, and document the shared source family. The original audited name set is preserved.
  • Hummingbird's x86_64 primary metadata contains libfido2, libfido2-devel, pam and pam-devel; this is metadata evidence, not a dependency solver transaction. Factory image sha256:20af10a9313f5aaaebbba78ffee1fc4fe2a63e6bd1fb69497cb333cb929318ec (revision 4e8f6e81a61a821406291d4f7d2a51f74011916c, run 40667554565) does not contain either requested binary.

Validation:

  • python3 tools/source_pipeline.py pam-u2f: archive and bundled signature accepted against SHA-512; the signature downloaded directly from Yubico matches and verifies against the bundled keyring.
  • python3 tools/factory_build_backlog.py --check, just check, and just test passed; each test run reported 1,390 passed, 2 skipped and 2,833 subtests passed.
  • git diff --check passed. pre-commit was unavailable.
  • The digest-pinned hosted build, resulting NEVRAs, factory publication, runtime dependency transaction, pamu2fcfg invocation and real security-key authentication remain unverified. No runtime completion is claimed.

— hive: backend=codex

Karibhou and others added 2 commits October 28, 2026 12:09
Import the pam-u2f source family and record its two binary outputs as recipe-covered. Hosted build and authentication evidence remain outstanding.

Hive-Run: projectbluefin#478
Hive-Plan: vpn package source families
Hive-Spec: factory-build-backlog#closing-a-backlog-gap
Assisted-by: Codex via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Hive-Run: projectbluefin#478
Hive-Plan: vpn package source families
Hive-Spec: factory-build-backlog#closing-a-backlog-gap
Assisted-by: Codex via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (6 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds the build recipe for a security-key sign-in component and its setup tool, copied from Fedora. I checked it from five angles. The copied files match Fedora exactly and the source checks are wired the same way as the other recipes, so nothing blocks it. The only note is that the new sentence in the backlog guide was placed under an unrelated heading.


style

  • docs/skills/factory-build-backlog.md:719-721 — the new pam-u2f/pamu2fcfg paragraph is appended under ### GNOME apps batch #484: terminal outputs and publication reconciliation (line 702), separated by a double blank line (717-718). The Yubico source-family guidance it belongs with is at line 392. Low; move it beside that text or give it its own ### heading.

Verified (not findings): packages/pam-u2f/{pam-u2f.spec,sources,yubico-release-gpgkeys.asc,.gitignore} are byte-identical to src.fedoraproject.org/rpms/pam-u2f at 5b713d39; the .sig Source1 is locked in packages/pam-u2f/sources:2 and fetched from the lookaside by tools/source_pipeline.py:162-190 (bundled_sources), matching how other recipes handle non-upstream sources.

No findings from: correctness, security, intent-alignment, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head 579c6c860253 has not moved for 3h1m and the hive has nothing it can push: adoption-stalled:conflicting.

Blocker: lane reason conflicting on this head and nothing changed.

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/scanner: conflicts with main; not resolved by hive because PR lacks stage/074-adopted-by-hive — contributor please merge main.


🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: 9170788

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 28, 2026
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged main at 76ed1d97fefd5a1cb90b240c596a1237a3819328; reconciled source and backlog entries and regenerated reports.

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

Moved the pam-u2f guidance beside the Yubico source guidance in a79112e. Both just check and just test pass.

— hive: backend=codex

@hivecommons-hive hivecommons-hive Bot added role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) and removed role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (4 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the openpgpverify handling is correct. It only needs a rebase onto main. Nit: the two new resolved entries are missing the "remain on #478" comment that the neighbouring entries have.

Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged main at 5454aad and resolved the shared configuration conflicts.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you (stage/074-adopted-by-hive → stage/072-returned-to-contributor). It will nudge again if CI stays red.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 30, 2026
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

Added the remaining #478 evidence note in 9a054bb; the branch also includes the current main base.

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (6 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Re-review of the changes since the last look at this security-key sign-in packaging change. The new commits only merge the main branch in and add one clarifying comment; the packaging itself is unchanged. One thing blocks merging: the main branch moved again right after that merge, so the branch now conflicts and its package-count figures in the architecture document are one short.
What I need from you: Merge main once more and bump the counts to 658 (653 rawhide).


Reviewed delta a79112e…9a054bba (merge of main through 5454aad plus one comment in config/factory-build-backlog.toml:310). No packages/pam-u2f/* file changed; the previous approval of the recipe stands.

docs-currency

  • docs/architecture.md:81,133,137-139,144,163 set the recipe count to 657 (652 rawhide). That was right against merge-base 5454aad, but main has since landed libpinyin (#796, main 995f68b0) and already reads 657 — GitHub reports this PR as CONFLICTING. After the next merge of main the figures must be 658 / 653 rawhide; the same six files touched by #796 (.packit.yaml, config/*.toml|json, reports/factory-build-backlog.json) will need conflict resolution.
    -asserts the package list is non-empty, which a list of 657 satisfies while
    +asserts the package list is non-empty, which a list of 658 satisfies while
    -validated 657 source RPMs (652 rawhide, 5 upstream)
    +validated 658 source RPMs (653 rawhide, 5 upstream)
    (and the 657→658 in the table rows and the 94 of 657 line).

style (advisory, carried from previous review — still present)

  • docs/skills/factory-build-backlog.md:455-460: the Yubico and pam-u2f paragraphs still sit under ### Compression measurements on Btrfs (line 439); the next heading is at 462. Give them their own heading:
    ### Security key sign-in (Yubico)
    
    Yubico C releases (`libyubikey`, `ykclient`, `ykpers`) still declare `http://opensource.yubico.com/...` `Source0` URLs in Fedora Rawhide, and `libyubikey` and `ykclient` still carry legacy MD5 `sources` lines: repin `sources` to `SHA512 (<file>) = <hex>`, lock `https://opensource.yubico.com/...` as the primary `url`, and pair `https://developers.yubico.com/<project>/Releases/<file>` with Fedora's `/md5/<md5>/` lookaside path in `fallback_urls`. `ykpers` builds and links against `libyubikey` (`libyubikey.so.0`), so import `libyubikey` in the same PR. When a recipe carries a committed OpenPGP keyring whose filename does not match `*key*.asc`, `*keyring*.asc`, or `[0-9A-F]*.asc` (`packages/pkcs11-provider/simo_redhat.asc`, `packages/bc/kevin_pizzini.asc`), unignore it explicitly in the root `.gitignore` (`!packages/<pkg>/<name>.asc`) so `git add` tracks `SourceN` for `%{openpgpverify}`. By contrast, `yubikey-manager` (`python3-yubikey-manager`) is a `pyproject` package whose `[project].dependencies` generate runtime `python3dist(...)` `Requires` across multiple backlog areas (`python3-click`, `python3-fido2`, `python3-keyring` plus `secretstorage`/`jeepney`/`jaraco` in `dev-tools`, and `python3-pyscard`, `python3-pskc` in `long-tail`); keep `yubikey-manager` and `python3-yubikey-manager` pending until those Python runtime providers land in the factory.
    
    (replacing line 455 only; the pam-u2f paragraph at 457-460 then follows under the new heading.)

No findings from: correctness, security, intent-alignment.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 30, 2026
Merge origin/main (libpinyin) into the pam-u2f branch, keeping both
source-lock entries, and regenerate the derived counts: architecture.md
now reports 658 recipes (653 rawhide) and the factory build backlog
snapshot is refreshed. Give the Yubico/pam-u2f guidance its own
heading instead of leaving it under the Btrfs compression section.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 30, 2026
@hanthor
hanthor merged commit 03c140b into projectbluefin:main Oct 30, 2026
21 checks passed
@Karibhou
Karibhou deleted the hive/478-pam-u2f-20261028 branch November 15, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants