Repository navigation
feat: add build support for VPN and smart-card authentication tools - #825
hivecommons-hive[bot] merged 3 commits into
Conversation
|
@kylerankin this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
**Summary:** This prepares two pieces of software that help people keep their networks private and secure. openpace lets Linux machines connect to corporate VPN gateways that read electronic travel documents, and opensc lets them use smart cards and security keys to prove who they are. Both add verified build instructions for components that were missing, though they still need a hosted build and a live connection test before users can rely on them. **What I need from you:** Review the two recipes and run the digest-pinned hosted build; the vpnc decision below also needs your call. --- - Import Fedora Rawhide `openpace` 1.1.4 and `opensc` 0.27.1 with `tools/import_rawhide.py`, retaining each recipe, patches, `sources`, tests, and dist-git provenance. `opensc`'s `%package libs` subpackage provides the requested `opensc-libs` output, so one import resolves both outputs. - Lock the upstream archives at SHA-512 (verified against the `sources` manifest for both) and register each recipe in `.packit.yaml`. - Move `openpace`, `opensc`, and `opensc-libs` from `[areas.vpn]` to `[resolved]` in the backlog and regenerate `.packit.yaml`, `docs/architecture.md`, and `reports/factory-build-backlog.json`. - **vpnc left pending (maintainer decision):** `NetworkManager-vpnc` and `NetworkManager-vpnc-gnome` are not imported here. Fedora retired the vpnc plugin for privilege-escalation vulnerabilities, and current NetworkManager (1.58.1) Obsoletes/Conflicts them. Importing a dead, unsafe plugin would contradict repo precedent; an explicit decision is required. Refs projectbluefin#478 -- partial: resolves `openpace`, `opensc`, and `opensc-libs`; the two vpnc outputs remain pending a maintainer decision. Consumer tracking: projectbluefin/utah#120. Validation: - `just check` and `just test` passed (1,401 passed, 2 skipped); each archive was accepted by `python3 tools/source_pipeline.py` against its SHA-512. - `git diff --check` passed. - No hosted build, binary NEVRA, factory publication, dependency transaction, or VPN connection test is claimed. Hive-Run: projectbluefin#478 Hive-Plan: vpn package source families Hive-Spec: factory-build-backlog#closing-a-backlog-gap Signed-off-by: Danathar <berths-purger-0g@icloud.com> — hive: backend=Ornith-1.5-35B-A3B-GGUF-Q6_K
bab5a7e to
52bd925
Compare
|
@kylerankin this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
**Summary:** This prepares two pieces of software that help people keep their networks private and secure. openpace lets Linux machines connect to corporate VPN gateways that read electronic travel documents, and opensc lets them use smart cards and security keys to prove who they are. Both add verified build instructions for components that were missing, though they still need a hosted build and a live connection test before users can rely on them. **What I need from you:** Review the two recipes and run the digest-pinned hosted build; the vpnc decision below also needs your call. --- - Import Fedora Rawhide `openpace` 1.1.4 and `opensc` 0.27.1 with `tools/import_rawhide.py`, retaining each recipe, patches, `sources`, tests, and dist-git provenance. `opensc`'s `%package libs` subpackage provides the requested `opensc-libs` output, so one import resolves both outputs. - Lock the upstream archives at SHA-512 (verified against the `sources` manifest for both) and register each recipe in `.packit.yaml`. - Move `openpace`, `opensc`, and `opensc-libs` from `[areas.vpn]` to `[resolved]` in the backlog and regenerate `.packit.yaml`, `docs/architecture.md`, and `reports/factory-build-backlog.json`. - **vpnc left pending (maintainer decision):** `NetworkManager-vpnc` and `NetworkManager-vpnc-gnome` are not imported here. Fedora retired the vpnc plugin for privilege-escalation vulnerabilities, and current NetworkManager (1.58.1) Obsoletes/Conflicts them. Importing a dead, unsafe plugin would contradict repo precedent; an explicit decision is required. Refs projectbluefin#478 -- partial: resolves `openpace`, `opensc`, and `opensc-libs`; the two vpnc outputs remain pending a maintainer decision. Consumer tracking: projectbluefin/utah#120. Validation: - `just check` and `just test` passed (1,401 passed, 2 skipped); each archive was accepted by `python3 tools/source_pipeline.py` against its SHA-512. - `git diff --check` passed. - No hosted build, binary NEVRA, factory publication, dependency transaction, or VPN connection test is claimed. Hive-Run: projectbluefin#478 Hive-Plan: vpn package source families Hive-Spec: factory-build-backlog#closing-a-backlog-gap Signed-off-by: Danathar <berths-purger-0g@icloud.com> — hive: backend=Ornith-1.5-35B-A3B-GGUF-Q6_K
52bd925 to
4e02ffa
Compare
|
@kylerankin this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Summary: This change imports two build recipes (a smart-card library and the passport-protocol library it depends on) faithfully from Fedora, and the imports check out. One problem: the pull request is written as partial work, but it ends with a line that would automatically close the whole tracking issue when merged, even though four of that issue's packages are still unfinished. That line needs to be changed before merging.
What I need from you: Replace the closing keyword with Refs #478 in the PR body.
intent-alignment
-
Closes #478will auto-close a batch issue that is still open — PR body (last paragraph) saysRefs #478 -- partialand then ends withCloses #478. #478 still listsNetworkManager-vpnc,NetworkManager-vpnc-gnome,python3-yubikey-manager,yubikey-manageras pending (config/factory-build-backlog.toml:81-84at 4e02ffa), and its acceptance criteria (hosted build run URLs, NEVRAs, runtime transaction) are explicitly unclaimed in this PR body. The repo's own convention forbids this:docs/skills/factory-build-backlog.md:57-63("For a partial batch PR, useRefs #<issue>… an automatically added footer can contradict an earlier partial-progress statement") and:232-236. The sibling partial PR #776 correctly usedRefsonly. The vpnc "maintainer decision" is also only raised in prose, not as a linked decision, so it does not satisfy the issue's "explicitly blocked by a linked decision" close condition. Fix (PR body, not a file):-Closes #478 +Refs #478
Then re-read the live body with
gh pr view 825 --json body --jq .bodyto confirm no generated footer re-adds a closing keyword. -
(info) PR body describes openpace as letting machines "connect to corporate VPN gateways that read electronic travel documents". Per
packages/openpace/openpace.spec:16-21it implements BSI TR-03110 EAC (PACE/TA/CA) for eID/ePassport chips and is pulled in as aBuildRequiresof opensc (packages/opensc/opensc.spec:40); it is in thevpnbacklog area by grouping, not function. Worth correcting so the record is accurate.
Verified (no findings): both SHA-512 locks in packages/*/sources and config/upstream-sources.json match freshly downloaded upstream archives; every imported file under packages/opensc/ and packages/openpace/ is byte-identical to Fedora dist-git at the commits recorded in .hummingbird-upstream.json; tools/factory_build_backlog.py --check and tools/validate.py pass at head (660 recipes); the NetworkManager 1.58.1 Obsoletes: NetworkManager-vpnc claim is accurate (Fedora NetworkManager.spec:210-214).
No findings from: correctness, security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
hanthor
left a comment
There was a problem hiding this comment.
The recipes match Fedora rawhide HEAD unchanged (diff -r shows only .hummingbird-upstream.json added), and both upstream SHA-512s match their locks.
Before merge:
- The PR body ends with
Closes #478, which would close #478 even thoughNetworkManager-vpnc,NetworkManager-vpnc-gnomeandyubikey-managerare still pending. Please change it toRefs #478. - It needs a rebase. The conflicts are in
upstream-sources.json(both sides append at the end),docs/architecture.mdandreports/factory-build-backlog.json. Regenerate the last two rather than hand-merging.
On vpnc: I recommend [wontfix]. Fedora retired NetworkManager-vpnc after the plugin privilege-escalation advisory. Hummingbird's own NetworkManager (1.58.1-*.hum1) carries Obsoletes: NetworkManager-vpnc{,-gnome}, so a factory build would be obsoleted the moment NetworkManager is installed. Post a decision comment and move both names to [wontfix] linking to it, the same way usbip was handled.
Nit: openpace implements eID and passport-chip protocols (BSI TR-03110); it has nothing to do with VPN gateways. It's here only because opensc needs it to build.
**Summary:** This prepares two pieces of software that help people keep their networks private and secure. openpace lets Linux machines connect to corporate VPN gateways that read electronic travel documents, and opensc lets them use smart cards and security keys to prove who they are. Both add verified build instructions for components that were missing, though they still need a hosted build and a live connection test before users can rely on them. **What I need from you:** Review the two recipes and run the digest-pinned hosted build; the vpnc decision below also needs your call. --- - Import Fedora Rawhide `openpace` 1.1.4 and `opensc` 0.27.1 with `tools/import_rawhide.py`, retaining each recipe, patches, `sources`, tests, and dist-git provenance. `opensc`'s `%package libs` subpackage provides the requested `opensc-libs` output, so one import resolves both outputs. - Lock the upstream archives at SHA-512 (verified against the `sources` manifest for both) and register each recipe in `.packit.yaml`. - Move `openpace`, `opensc`, and `opensc-libs` from `[areas.vpn]` to `[resolved]` in the backlog and regenerate `.packit.yaml`, `docs/architecture.md`, and `reports/factory-build-backlog.json`. - **vpnc left pending (maintainer decision):** `NetworkManager-vpnc` and `NetworkManager-vpnc-gnome` are not imported here. Fedora retired the vpnc plugin for privilege-escalation vulnerabilities, and current NetworkManager (1.58.1) Obsoletes/Conflicts them. Importing a dead, unsafe plugin would contradict repo precedent; an explicit decision is required. Refs projectbluefin#478 -- partial: resolves `openpace`, `opensc`, and `opensc-libs`; the two vpnc outputs remain pending a maintainer decision. Consumer tracking: projectbluefin/utah#120. Validation: - `just check` and `just test` passed (1,401 passed, 2 skipped); each archive was accepted by `python3 tools/source_pipeline.py` against its SHA-512. - `git diff --check` passed. - No hosted build, binary NEVRA, factory publication, dependency transaction, or VPN connection test is claimed. Hive-Run: projectbluefin#478 Hive-Plan: vpn package source families Hive-Spec: factory-build-backlog#closing-a-backlog-gap Signed-off-by: Danathar <berths-purger-0g@icloud.com> — hive: backend=Ornith-1.5-35B-A3B-GGUF-Q6_K
4e02ffa to
2845968
Compare
|
@kylerankin this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Summary: This is a re-check of the pull request that adds build recipes for two security tools (a smart-card toolkit and an electronic-ID cryptography library) after it was rebased onto newer main. The recipes themselves did not change and still look fine. Two problems from the last review are still there: the description still says one of the libraries is a VPN client when it is not, and the closing line would automatically close the larger tracking issue even though two of its items are deliberately left undone. The rebase also rewrote a shared 660-entry source list from top to bottom instead of adding two lines, which will collide with every other open import.
What I need from you: Fix the two wording issues in the PR body and regenerate the source list without reordering it.
Reviewed head 2845968 (rebased; delta vs 4e02ffa is base churn from #773/#774/#775/#813 plus count refreshes). Recipes, patches, sources, and tests under packages/openpace/ and packages/opensc/ are byte-identical to the previously reviewed head.
intent-alignment
-
Still present —
Closes #478auto-closes a still-open batch issue. PR body says "Refs #478 -- partial: … the two vpnc outputs remain pending a maintainer decision", andconfig/factory-build-backlog.toml:81-82still listsNetworkManager-vpnc/NetworkManager-vpnc-gnomeunder[areas.vpn]. Yet the body ends withCloses #478, which GitHub will honour on merge (base ismain) and close #478 (OPEN, "parity(vpn): resolve factory outputs NetworkManager-openconnect through pcsc-lite-libs") with work outstanding. Fix: delete the trailingCloses #478line from the PR body; the existingRefs #478line already links it. -
Still present — PR body misdescribes openpace. Body: "openpace lets Linux machines connect to corporate VPN gateways that read electronic travel documents."
packages/openpace/openpace.spec:4isSummary: Cryptographic library for EAC version 2, and%description(lines 15-21) says it implements BSI TR-03110 PACE/TA/CA protocols for eID/ePassport chips — no VPN role. Suggested replacement sentence: "openpace is a cryptography library that lets software talk securely to electronic ID cards and passports; it is a dependency of the smart-card stack, not a VPN client."
style
- New since last head —
config/upstream-sources.jsonis re-sorted wholesale. Previous head added 14 lines; this head shows +2605/−2591 because every existing entry was reordered into ASCII order (file now startsImageMagick, LibRaw, ModemManager…; base startsjbig2dec, b43-fwcutter, ipset…). Semantic diff against parent304bafeis exactly two added entries (openpace,opensc), nothing else changed. No tool intools/sorts this file (source_pipeline.py:254only reads it;bootstrap_upstream_sources.py:244dumps in insertion order), so this is hand-introduced churn that will conflict with every concurrent import PR touching this registry. Fix: restore the base file and append the two entries, e.g.
- (whole-file reorder)
+ … existing 662 entries in base order …,
+ {
+ "name": "openpace",
+ "version": "1.1.4",
+ "url": "https://github.com/frankmorgner/openpace/releases/download/1.1.4/openpace-1.1.4.tar.gz",
+ "filename": "openpace-1.1.4.tar.gz",
+ "sha512": "962495803b351965ad0d2cda67563ca3f60f36360a1b1523b68715b79b7c6acb413b5bdf483d01a5d11ee936262ff5b45645363bf2857c3e7704a196dc2447a7"
+ },
+ {
+ "name": "opensc",
+ "version": "0.27.1",
+ "url": "https://github.com/OpenSC/OpenSC/releases/download/0.27.1/opensc-0.27.1.tar.gz",
+ "filename": "opensc-0.27.1.tar.gz",
+ "sha512": "1d435938d5db45ffc60e2ac2512c42bc7ee893991d213b19033a60cabca19a7ddd5bf1f71bb172dcb77220bfa87abe92564b3edc878f22a87dfd4e7bcacf662f"
+ }No findings from: correctness, security, docs-currency.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@kylerankin the hive has adopted this PR ( |
Restore the existing entry order of config/upstream-sources.json and append only the openpace and opensc entries, so the change is limited to the two new sources. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
The hive adopted this PR ( Blocker: this PR comes from a fork ( Moving to |
There was a problem hiding this comment.
Read the import at 6e586f5. The recipes look correct to me; the only thing blocking it is a rebase.
Verified:
- Downloaded both upstream archives named in
config/upstream-sources.jsonand hashed them:opensc-0.27.1.tar.gz→1d435938…andopenpace-1.1.4.tar.gz→96249580…, matchingpackages/opensc/sources:1,packages/openpace/sources:1and the JSON locks exactly. .hummingbird-upstream.jsonin both packages records the Rawhide dist-git commit/tree,.packit.yamlgains matchingopenpace/openscentries, andconfig/factory-build-backlog.tomlmoves the three outputs to[resolved]withpr = 825— same shape as the other imports in this repo.opensc.spec:2/openpace.spec:2carry 0.27.1 and 1.1.4 as claimed.- Leaving
NetworkManager-vpnc{,-gnome}pending is the right call to park rather than decide here; the body states why andRefs #478is used correctly for a deliberate partial.
Blocking (not a code problem): a test merge against main conflicts in docs/architecture.md and reports/factory-build-backlog.json — both are generated. This is a fork branch so I cannot push the fix; @kylerankin, rebase onto current main and rerun python3 tools/factory_build_backlog.py to regenerate them, then --check should pass again.
The vpnc decision is a #478 question for the utah-packages approvers, not something this PR needs answered before merging. I have not approved or merged anything.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Keep both sides' new entries in config/upstream-sources.json and regenerate docs/architecture.md (render_architecture_counts.py --write) and reports/factory-build-backlog.json (factory_build_backlog.py). Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
1 of 2 commits on |
|
1 of 2 commits on |
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @kylerankin holds the trusted tier in this hive's contributor registry. |
Summary: This prepares two pieces of software that help people keep their
networks private and secure. openpace is a cryptography library for electronic ID
cards and ePassports that the smart-card stack depends on, and opensc lets Linux machines use
smart cards and security keys to prove who they are. Both add verified build
instructions for components that were missing, though they still need a hosted
build and a live connection test before users can rely on them.
What I need from you: Review the two recipes and run the digest-pinned
hosted build. The vpnc decision below also needs your call before it can be
resolved.
Changes
openpace1.1.4 andopensc0.27.1 withtools/import_rawhide.py, retaining each recipe, patches,sources, tests,and dist-git provenance.
opensc's%package libssubpackage provides therequested
opensc-libsoutput, so one import resolves both outputs.sourcesmanifest for both) and register each recipe in
.packit.yaml.openpace,opensc, andopensc-libsfrom[areas.vpn]to[resolved]in the backlog and regenerate.packit.yaml,docs/architecture.md, andreports/factory-build-backlog.json.vpnc needs a maintainer decision
NetworkManager-vpncandNetworkManager-vpnc-gnomeare intentionally notimported here. Fedora retired the vpnc plugin for privilege-escalation
vulnerabilities, and current NetworkManager (1.58.1)
Obsoletes/Conflictsthem. Importing a dead, unsafe plugin would contradict repo precedent, so this
output is left pending an explicit decision rather than resolved in silence.
Evidence and validation
sourcesSHA-512 locks;python3 tools/source_pipeline.py opensc|openpaceaccepted both.just checkandjust testpassed (1,401 passed, 2 skipped);python3 tools/factory_build_backlog.py --checkpassed;git diff --checkpassed.
openpace,opensc, andopensc-libs; thetwo vpnc outputs remain pending a maintainer decision. Consumer tracking:
chore(deps): update ghcr.io/ublue-os/brew docker digest to 60ada2d utah#120.
or VPN connection test is claimed. After review, run the digest-pinned hosted
build for each recipe, install from Hummingbird plus the factory, and record
a representative connection and authentication result.
— hive: backend=Ornith-1.5-35B-A3B-GGUF-Q6_K
🐝 Hive Agent:
contributor| SHA:bab5a7ea