Skip to content

fix: allow the braille converter build to find its manual tools (adopts #705) - #712

Merged
hanthor merged 2 commits into
mainfrom
adopt/705
Oct 27, 2026
Merged

hanthor merged 2 commits into
mainfrom
adopt/705

Conversation

@hanthor

@hanthor hanthor commented Oct 27, 2026

Copy link
Copy Markdown
Member

Adopts fork PR #705 by @j1mc.

Enable buildroot_icu77 for liblouisutdml so its documentation build can locate required build dependencies.

j1mc and others added 2 commits October 27, 2026 08:47
Allow the documentation-only ICU 77 dependency in the liblouisutdml build root, as already done for liblouis. Preserve the PDF manual and upstream tests; runtime dependencies still require hosted verification.

Assisted-by: openrouter/openai/gpt-6.1-terra via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Run: #480
Hive-Plan: printing-scanning build failure remediation
Hive-Spec: issue-480#implementation
Signed-off-by: j1mc <j1mc@users.noreply.github.com>
Assisted-by: Claude via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@hanthor is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this repository have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change lets the braille document converter build again by allowing one extra library (ICU 77) into its build environment, which the manual-generating tools need. The converter itself does not use that library, so the change is low risk, and a new test guards that the manual and test suite stay in. The only note: the change also quietly refreshes a backlog tally file that was already out of date on the main branch; that refresh is correct and needed for the checks to pass, but the description does not mention it.


intent-alignment

  • info, in-scope — reports/factory-build-backlog.json:1531-1532 changes totals (296→294 backlog, 225→227 resolved) with no matching catalog change in this PR. Verified: python3 tools/factory_build_backlog.py --check exits 1 at merge-base 6e09772 ("totals drift: live {'backlog': 294, 'resolved': 227, ...} vs snapshot {296, 225}") and exits 0 at head 5556742, and origin/main still carries the stale snapshot. So the hunk is the generator's own output and is required for .github/workflows/validate.yml:56 to pass — fine to keep, but it is unrelated to the ICU opt-in and the body does not say so. Suggest one line in the PR body, e.g. "Also regenerates the backlog snapshot, which was stale on main."

Verified in support of the opt-in: packages/liblouisutdml/liblouisutdml.spec:19-28 has no ICU BuildRequires; the flag is read at .github/workflows/build-stage.yml:241,396 and applied at tools/build_container.sh:146-150, matching the liblouis precedent (config/upstream-sources.json:3929, docs/skills/repeated-mistakes.md:545-551). tests/test_liblouisutdml_build.py passes locally.

No findings from: correctness, security, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1

@hanthor
hanthor merged commit 03eedbf into main Oct 27, 2026
169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants