Skip to content

fix: unblock the braille document converter build - #705

Closed
j1mc wants to merge 1 commit into
projectbluefin:mainfrom
j1mc:fix/printing-480-braille
Closed

j1mc wants to merge 1 commit into
projectbluefin:mainfrom
j1mc:fix/printing-480-braille

Conversation

@j1mc

@j1mc j1mc commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary: A tool that converts documents to braille could not be built because a tool used to make its manual was unavailable in the build environment. This change allows that manual tool to be installed during the build, while keeping the manual and the existing tests. The change still needs a hosted build and installation checks before users can rely on the converter.

What I need from you: Review the change and run the hosted build and runtime checks before merging.


Changes

  • Enable the existing buildroot_icu77 opt-in for liblouisutdml, matching the established liblouis approach in merged fix(screen-reader): build liblouis and brltty without Fedora's ICU 77 #470. The opt-in affects the build root, not the runtime repository policy.
  • Preserve the PDF manual and upstream %check; add a regression test for the opt-in, the documentation build and the absence of a direct ICU build requirement.
  • Document the build-root distinction and the remaining runtime verification in the backlog skill.

Refs #480 — partial: the hosted build, RPM requirements, publication and Hummingbird-plus-factory runtime and payload checks remain outstanding. Consumer tracking: projectbluefin/utah#390.

Evidence

The first build after the recipe import in merged #672 failed at build-root resolution: run 40452191497, liblouisutdml job. texinfo-tex pulls texlive-collection-basic, texlive-dvipdfmx, then texlive-xetex, which requires libicuuc.so.77; the default build-root filter excludes ICU 77. The release's configure.ac links liblouis and libxml2 rather than ICU directly. The same run built antiword successfully; this does not establish its runtime behavior.

The new opt-in is a proposed fix, not proof that the resulting RPMs are free of ICU 77. The production hermetic workflow passes this flag to the lock step; #470 used the same approach for the related liblouis recipe.

Validation

  • python3 tools/factory_build_backlog.py --check — passed.
  • just check and just test — passed; each test run reported 1,397 passed and 2 existing skips.
  • git diff --check — passed.
  • pre-commit run --all-files — not run: pre-commit is unavailable in this environment.
  • Hosted package build, binary NEVRAs, dependency solver, publication and representative conversion were not run. After a successful digest-pinned hermetic build, inspect all resulting RPM requirements for ICU 77, resolve the requested outputs using only Hummingbird plus the factory, exercise file2brl and the required antiword conversion, and record the run and published OCI digest. Do not close the batch until all of its acceptance evidence is complete.

— hive: backend=pi model=openrouter/openai/gpt-6.1-terra

Allow the documentation-only ICU 77 dependency in the liblouisutdml build root, as already done for liblouis. Preserve the PDF manual and upstream tests; runtime dependencies still require hosted verification.

Assisted-by: openrouter/openai/gpt-6.1-terra via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Run: projectbluefin#480
Hive-Plan: printing-scanning build failure remediation
Hive-Spec: issue-480#implementation
Signed-off-by: j1mc <j1mc@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@j1mc this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • Canary

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@j1mc

j1mc commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

The Canary failure is the fork-proof gate, not a package build failure: job 122094586205 reports no maintainer-run Canary for head 9678fbe60eba15c310b6d80ac910812a202ebc6f. The workflow requires a maintainer to run “Canary for a fork pull request” for this PR and exact head; the other CI checks passed. No code change can supply that trusted proof.


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@j1mc the hive has adopted this PR (stage/074-adopted-by-hive): CI stayed red for 2h after the nudge and the relay nudge went unanswered. The hive will rebase this branch on main and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hanthor

hanthor commented Oct 27, 2026

Copy link
Copy Markdown
Member

Adopted and merged via #712.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants