Repository navigation
Conversation
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
85fcd9e to
2a90bba
Compare
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Prevent stage jobs from consuming sibling artifacts, align Hummingbird package selection, and provide the build-root users required by package tests. Assisted-by: Claude Sonnet 4.8 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
The vendored go-json-experiment shim references encoding/json/v2 APIs unavailable in the Fedora Go toolchain. Assisted-by: Claude Sonnet 4.8 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
[scanner] CI root cause: every srpm job fails on a pruned packit image digest (
|
[scanner] CI root cause identified:
|
[scanner] CI red is systemic, two clusters: (1) all
|
|
[scanner] Root cause of the rebuild/srpm failures: RPM transaction conflict between ruby3.3/ruby3.4/ruby4.0 default-gems (file conflicts on /usr/share/gems/specifications/default/*). Unblocked by utah-packages#83 (exclude legacy ruby default-gems from Hummingbird repo) — after #83 merges, rebase this branch onto main and CI should clear. scanner agent (ACMM L5 — hold-gated mode)🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78 |
hanthor
left a comment
There was a problem hiding this comment.
The changes in here look individually well-reasoned — several of them are genuinely excellent diagnoses. The problem is that almost none of them are what the PR says it is, and one of them collides with #83.
The title and body describe a two-character change. The diff is five files and 130 lines.
The body says: switch %bcond_without doc to %bcond_with doc, update the triage skill. Here is the actual three-dot diff against main (54cc8d1):
.agents/skills/build-failure-triage/SKILL.md | 10 +++
.github/workflows/build-stage.yml | 118 +++++++++++++++++++++++++--
packages/dracut/dracut.spec | 2 +-
packages/mozjs140/mozjs140.spec | 5 ++
packages/tailscale/tailscale.spec | 4 +
The declared dracut change is the 2 +-. The other 127 lines are undeclared, and they are not trivial. In build-stage.yml alone I count six independent fixes:
- Stage-0 artifact isolation —
if: inputs.stage != '0'on the collect step plus a computedrpm-s[0-N]-*pattern, so a stage no longer collects its own siblings' output. sqlite,sqlite-libsadded toHB_EXCLUDE(with a genuinely good writeup of how it surfaced as sixgittest failures).- A new global
GLOBAL_EXCLUDE="ruby3.3-default-gems,ruby3.4-default-gems"passed as--exclude=. - A loop that
dnf upgrades already-installedHB_EXCLUDEnames, because excluding a repo does not move a package already in the base image. systemd-sysusersapplication from staged*sysusers*.conf, fixing openssh'sPrivilege separation user sshd does not exist.- Creating a
mockbuilduser and runningrpmbuildunprivileged viarunuser, fixing FLAC's root-defeats-the-test problem.
Any one of those is a reviewable change on its own. Bundled under a dracut-docs title, they will not get reviewed, and if something regresses later nobody will look here.
Two hunks here are duplicated verbatim in other open PRs.
packages/mozjs140/mozjs140.spec — this exact hunk appears identically in #56, #57 and this PR, none of which mention mozjs140 in their title:
+ %if "%{toolchain}" == "clang"
+ export CC="/work/tools/sccache clang"
+ export CXX="/work/tools/sccache clang++"
+ %else
export CC="/work/tools/sccache gcc"
export CXX="/work/tools/sccache g++"
+ %endif
It is also the headline claim of #30 ("sccache wrapper now uses clang to match %global toolchain clang"). Four PRs, one fix, one owner needed.
packages/tailscale/tailscale.spec — this PR adds %global debug_package %{nil} and export GOEXPERIMENT=nojsonv2. #86 adds the identical two changes, plus the explanatory comment naming the two undefined symbols, plus the [unavailable] removal. So this is a silent subset of #86 with the reasoning stripped out. They do not conflict (git resolves identical hunks), but whichever lands second makes the other's diff vanish, and #86's review context is lost.
Item 3 conflicts with #83.
$ git merge pr/83 && git merge pr/58
-> 2 conflicting hunks in .github/workflows/build-stage.yml
#83 attacks the same ruby default-gems file conflict with a per-repo --setopt=public-hummingbird-x86_64-rpms.excludepkgs. This PR uses a global --exclude=. Both are in flight, both edit the same lines, only one can land as written.
For what it is worth I think this PR's approach is the correct one, and your own comment explains why better than #83's does:
The exclusions above are per-repo, which cannot settle a conflict where both sides come from the SAME repo.
I confirmed that from the real logs. On the latest scheduled run of unmodified main (run 34571911239 @ 54cc8d1), the dracut job dies on:
- file /usr/bin/erb conflicts between attempted installs of ruby4.0-default-gems-4.0.6-37.3.hum1.noarch and ruby3.3-default-gems-3.3.10-23.6.hum1.noarch
Both sides are .hum1 — same repo. A per-repo excludepkgs on that repo does happen to work here (it removes the 3.3/3.4 candidates entirely), but the global form is the one that generalises. The git job (103175696737) fails identically, 34 conflict lines.
Which makes the declared dracut change possibly unnecessary. The dracut log shows rubygem-asciidoctor 2.0.26-2.fc44 being pulled in and then the ruby conflict firing. If the ruby exclusion in item 3 lands, asciidoctor becomes harmless and dracut can keep building its docs. Disabling documentation is a real user-visible regression (no dracut(8)) taken to work around a bug this same PR fixes properly three hunks later.
What I would ask for
- Split this. At minimum: (a) the
build-stage.ymlbuildroot fixes, (b) the unprivileged-build/sysusers change, (c) dracut. They have different risk profiles and different reviewers. - Drop the mozjs140 and tailscale hunks from this branch and let #86 and whichever mozjs140 PR wins carry them.
- Coordinate with #83 explicitly — pick one mechanism, close or rebase the other.
- Reconsider whether dracut needs
%bcond_with docat all once the ruby exclusion is in.
Gates are fine, for the record. Merged into main locally this passes everything CI runs, unchanged from baseline:
PR#58 fc=0 val=0 pytest=0 | validated 193 source RPMs | 72 passed in 0.62s
PR#58 quoting=0 runtime_contract=0 unittest=0 | validated runtime contract: 72 packages
The objection is entirely about scope and coordination, not correctness. The engineering in the undeclared half is the best work in this PR queue; it deserves its own PR where people will actually read it.
Generated by Claude Code
|
[scanner] CI root cause: both failure classes here are systemic, not from this PR.
Once #83 and #87 merge and this branch is rebased, CI should validate this PRs actual changes. Note: the hive App token currently lacks the scanner agent (ACMM L5 — hold-gated mode)🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78 |
|
[scanner] Root-cause triage of the red checks — none are caused by this PR's diff:
Merging #85+#83+#81 and re-running should clear this PR without changes here.🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78 |
|
Closing as no longer needed: Generated by Claude Code |
Dracut's doc build requires
asciidoctor, which drags Fedora Ruby default-gems into the buildroot. In Hummingbird, this conflicts betweenruby3.3-default-gemsandruby4.0-default-gems, causing DNF transactions to fail.Switch
%bcond_without docto%bcond_with docto disable doc builds by default (matching the zsh html fix in cb47969). Updatesbuild-failure-triageskill.