Skip to content

fix(contract): exclude anaconda-live from runtime transaction and Rawhide import - #57

Closed
castrojo wants to merge 1 commit into
mainfrom
fix/exclude-installer-from-import
Closed

castrojo wants to merge 1 commit into
mainfrom
fix/exclude-installer-from-import

Conversation

@castrojo

@castrojo castrojo commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Utah uses bootc-installer, not Anaconda WebUI or Slitherer (commit 68829f8).

  • Records anaconda-live in config/runtime-contract.toml under [unavailable] alongside slitherer.
  • Filters [unavailable] packages in tools/import_bluefin_rawhide.py to prevent automatically importing unused installer stack sources.
  • Updates reports/bluefin-rawhide-resolution.json.
  • Adds docs/skills/runtime-contract-exceptions.md documenting the convention.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

[scanner] CI root cause: every srpm job fails on a pruned packit image digest (quay.io/packit/packit@sha256:149e6e06… → manifest unknown, exit 125). One-line fix at .github/workflows/packit-srpm-pilot.yml:90: repin to sha256:8a1784251c51eed7a094820c894e2ee7f4ed4bbce4eb78eb172a04de3fae43e1 (verified live). I cannot push it — the hive App token lacks workflows permission for .github/workflows/*. Details: #74

🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3

@hivecommons-hive

Copy link
Copy Markdown
Contributor

[scanner] CI root cause identified: packit-srpm-pilot.yml pins a packit image digest pruned from quay.io — every srpm (*) job dies with manifest unknown (exit 125), on main as well as this branch. Fix (repin to live digest 8a178425…, verified via quay API) is ready as commit 3017fe3 but the hive App lacks the workflows permission to push workflow edits. Tracked in the issue filed on this repo; needs a human push, then rebase this branch.

🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3

@hivecommons-hive

Copy link
Copy Markdown
Contributor

[scanner] CI red is systemic, two clusters: (1) all srpm jobs fail exit 125 — the pinned quay.io/packit/packit digest was pruned upstream, filed #84 (fix ground occupied by #70 which rewrites packit-srpm-pilot.yml); (2) rebuild* / build failures (samba/gpgme hummingbird dep mismatches, fish %check, firefox) are the cluster tracked by #30. No in-branch fix available without colliding with those PRs.

🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3

@hivecommons-hive

Copy link
Copy Markdown
Contributor

[scanner] Root cause of the rebuild/srpm failures: RPM transaction conflict between ruby3.3/ruby3.4/ruby4.0 default-gems (file conflicts on /usr/share/gems/specifications/default/*). Unblocked by utah-packages#83 (exclude legacy ruby default-gems from Hummingbird repo) — after #83 merges, rebase this branch onto main and CI should clear.


scanner agent (ACMM L5 — hold-gated mode)

🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The declared change is fine. The undeclared two-thirds of the diff is the problem — including one hunk that is arguably the most valuable fix in the whole open-PR queue and is buried where nobody will find it.

What the body describes vs. what the diff does

The body describes four things, all in the anaconda-live / runtime-contract area. Three-dot diff against main (54cc8d1):

 config/runtime-contract.toml    | 1 +     <- declared
 tools/import_bluefin_rawhide.py | 5 +     <- declared
 config/upstream-sources.json    | 3 ++-   <- NOT declared
 packages/dracut/dracut.spec     | 2 +-    <- NOT declared
 packages/fish/fish.spec         | 9 ++-   <- NOT declared
 packages/mozjs140/mozjs140.spec | 5 ++    <- NOT declared

(reports/bluefin-rawhide-resolution.json and docs/skills/runtime-contract-exceptions.md are mentioned in the body but do not appear in the diff against current main.)

The fish hunk is the real fix for a failure three other PRs are arguing about

 %check
 export CI=1
-%cmake_build --target fish_run_tests
+if [ "$(id -u)" -eq 0 ]; then
+    useradd --system --create-home fish-tests
+    chown -R fish-tests:fish-tests %{_vpath_builddir}
+    runuser -u fish-tests -- env USER=fish-tests LOGNAME=fish-tests HOME=/home/fish-tests \
+        cmake --build %{_vpath_builddir} --target fish_run_tests
+else
+    %cmake_build --target fish_run_tests
+fi

This is correct, and I can show it is aimed at the right target. From the fish job on the latest scheduled run of unmodified main (run 34571911239 @ 54cc8d1, job 103175696704):

193 / 196 passed (44 skipped)
Failed tests:
    tests/checks/cd.fish
    tests/checks/fish_config.fish
    tests/checks/path.fish
FAILED: [code=1] CMakeFiles/fish_run_tests ...
error: Bad exit status from /var/tmp/rpm-tmp.56yZAa (%check)

Three root-sensitive tests, everything else green. Your hunk fixes exactly that. Meanwhile #79 is open claiming fish fails in the buildroot for want of crate RPMs, rewrites the spec to vendor ~120 crates, does not touch %check at all, and removes fish from [unavailable] on the strength of it. #79 will not turn that job green; this hunk will. But because it is unmentioned here, #79's author had no way to know it existed.

The mozjs140 hunk is in three PRs at once

Byte-identical in #56, #57 and #58, and it is the headline claim of #30:

+  %if "%{toolchain}" == "clang"
+  export CC="/work/tools/sccache clang"
+  export CXX="/work/tools/sccache clang++"
+  %else

Four PRs, one fix. Someone needs to own it.

The dracut changelog hunk is shared with #56 and fixes a real error

-* Mon aug 10 2026 Hans de Goede <johannes.goede@oss.qualcomm.com> - 111-2
+* Mon Aug 10 2026 Hans de Goede <johannes.goede@oss.qualcomm.com> - 111-2

Also byte-identical in #56. And it is not cosmetic — the dracut build log on main (job 103175696635) emits:

error: bad date in %changelog: Mon aug 10 2026 Hans de Goede <johannes.goede@oss.qualcomm.com> - 111-2

right before the buildroot transaction. Worth landing on its own with that log line as justification, rather than riding along unexplained in two different PRs.

The evolution-ews stage bump directly contradicts #70

       "filename": "evolution-ews-3.61.3.tar.xz",
-      "sha512": "617369f9...cf813"
+      "sha512": "617369f9...cf813",
+      "stage": 2

evolution-ews requires libebook/libecal/libedata-* >= 3.61.3, which come from evolution-data-server. On main that builds at stage 1. This PR moves evolution-ews to stage 2 — one stage later, which is the minimum that could work. #70 moves evolution-data-server to stage 9 and evolution-ews to stage 10 instead. Those two are incompatible orderings of the same dependency, sitting in two PRs neither of which mentions the other. If this lands first and #70 later, the merge resolves silently to whichever side git prefers and the stage graph breaks in a way that only shows up hours into a matrix run. evolution-ews is currently a confirmed failure on main (job 103175696652), so this matters.

The declared change itself is good

anaconda-live in [unavailable] plus the [unavailable] filter in import_bluefin_rawhide.py is the right shape — it keeps a package Utah does not use from both the runtime transaction and the Rawhide import, and it uses the mechanism the repo already has rather than inventing one. I confirmed the effect: merged into main, the contract drops from 72 to 71 packages, and all gates stay green:

PR#57 fc=0 val=0 pytest=0 | validated 193 source RPMs | 72 passed in 0.66s
PR#57 quoting=0 runtime_contract=0 unittest=0 | validated runtime contract: 71 packages

What I would ask for

  1. Split the fish %check hunk into its own PR, with the log excerpt above as the justification, and cross-link it from #79. It is valuable and it is currently invisible.
  2. Drop the mozjs140 hunk here; let one PR own it.
  3. Split the dracut changelog fix out (or coordinate with #56, which has the same line).
  4. Resolve the evolution-ews stage question with #70 before either merges.
  5. Leave this PR as the anaconda-live change it says it is — that part is ready.

Generated by Claude Code

@hivecommons-hive

Copy link
Copy Markdown
Contributor

[scanner] CI root cause: both failure classes here are systemic, not from this PR.

  1. srpm jobs fail with docker: manifest unknown (exit 125) — the pinned quay.io/packit/packit@sha256:149e6e06... digest was garbage-collected upstream when latest was republished. Fix already open: ci: repin Packit image to live digest #87 (repins to the live digest 8a178425..., verified still current as of 2026-09-12).
  2. rebuild jobs fail on ruby3.3-default-gems / ruby3.4-default-gems / ruby4.0-default-gems file conflicts in the Hummingbird repo transaction. Fix already open: fix(buildroot): exclude legacy ruby default-gems from Hummingbird repo #83 (excludes the legacy default-gems from the Hummingbird repo).

Once #83 and #87 merge and this branch is rebased, CI should validate this PRs actual changes. Note: the hive App token currently lacks the workflows permission, so agent-authored pushes touching .github/workflows/ are rejected — the repin must land via a human-pushed PR (#87).


scanner agent (ACMM L5 — hold-gated mode)

🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: 860e512

— hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78

@hivecommons-hive

Copy link
Copy Markdown
Contributor

[scanner] Root-cause triage of the red checks — none are caused by this PR's diff:

  1. All srpm (*) jobs: the workflow pins quay.io/packit/packit@sha256:149e6e06…, which upstream has deleted (manifest unknown, HTTP 404 — verified against quay.io). Every srpm job dies at docker run with exit 125. Fix already open and green: ci: repin Packit SRPM image to live digest #85 / ci: repin Packit image to live digest #87 (repin to 8a178425…, verified live). Note ci: repin Packit SRPM image to live digest #85 and ci: repin Packit image to live digest #87 are duplicates — one should be closed.
  2. rebuild* / build failures (firefox, gjs, webkitgtk, samba, dracut, …): two distinct repo-content bugs in the Hummingbird repo — (a) buildroot transactions pull in BOTH ruby3.4 and ruby4.0 default-gems and the rpm transaction conflicts (fix open: fix(buildroot): exclude legacy ruby default-gems from Hummingbird repo #83), (b) missing closure members like libwebrtc-audio-processing-2.so.1 for pipewire-devel (closure fixes open: feat: add Utah's unique @multimedia closure members (PackageKit, alsa-utils, ffmpegthumbnailer, gstreamer1 plugins) #81, ci: publish factory repositories atomically after closure validation #89). The dead srpm lane (1) also blocks republishing fixed packages.

Merging #85+#83+#81 and re-running should clear this PR without changes here.

🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78

Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
@castrojo
castrojo force-pushed the fix/exclude-installer-from-import branch from 8ba2cee to 029b00f Compare September 13, 2026 20:13
castrojo added a commit that referenced this pull request Sep 13, 2026
…e import, and contract (#71, #72, #56, #57) (#92)

* test(quality): unit coverage for validate.py and recalculate_hummingbird_gaps.py

* fix(ci): verify cosign binary sha256 checksum in rebuild-rpms

Verify the downloaded cosign v2.4.1 binary against its release SHA-256
checksum prior to installation and keyless signing.

Closes #46
Closes #66
Closes #68

* fix(tools): validate package and branch inputs in import_rawhide (#56)

* fix(contract): exclude anaconda-live from runtime transaction (#57)

---------

Co-authored-by: castrojo <castrojo@users.noreply.github.com>
@castrojo castrojo closed this in #92 Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants