Skip to content

fix(screen-reader): build liblouis and brltty without Fedora's ICU 77 - #470

Merged
hanthor merged 1 commit into
mainfrom
ccr-6715b6dc-lf5psn-screen-reader-fix
Oct 15, 2026
Merged

hanthor merged 1 commit into
mainfrom
ccr-6715b6dc-lf5psn-screen-reader-fix

Conversation

@hanthor

@hanthor hanthor commented Oct 15, 2026

Copy link
Copy Markdown
Member

Why

The first main build after #466 (run 38798922994) built seven of the ten screen-reader packages. Three failed at lock resolve:

  • liblouis and brltty: their documentation BuildRequires (texlive-xetex; linuxdoc-tools) pull in TeX Live. Its texlive-xetex requires libicuuc.so.77, and the build root excludes ICU 77 by default.
  • orca: it then fell back to Fedora's ICU-77 brlapi, because the factory's brltty didn't exist yet.

What

The fix depends on whether the package itself links ICU.

  • liblouis does not link ICU. It now sets "buildroot_icu77": true in config/upstream-sources.json. This is the documented opt-in libvdpau already uses for the same TeX Live chain (tools/build_container.sh).
  • brltty does link ICU (libicu-devel). Admitting ICU 77 to its root would ship a brltty that the consumer set rejects, which is the failure tests/test_icu_staging.py describes. Instead:
    • the spec drops BuildRequires: linuxdoc-tools. Upstream configure then sets can_make_manual=no, so only the SGML manuals ship.
    • the manual cleanup becomes rm -f.
    • both edits carry # Utah: comments.
  • Skill write-back: a note in docs/skills/repeated-mistakes.md §23. Before reaching for buildroot_icu77, check whether the package links ICU itself.

Validation

  • A targeted rebuild of this branch passed (run 38804044853, packages: ["liblouis", "brltty", "orca"]). brltty and liblouis built, then orca built against them, and the run's publish and install gate passed. That run published under this branch's tag, not :latest.
  • All the gates pass:
    • tools/factory_contract.py
    • tools/validate.py
    • tools/multimedia_closure.py --check
    • tools/check_workflow_quoting.py
    • tools/runtime_contract.py --check
    • tools/factory_build_backlog.py --check
    • pytest: 1226 passed, 2 skipped.

Refs #447

🤖 Generated with Claude Code

https://claude.ai/code/session_01EvvFSAwG7AzVee1EtWLK15


Generated by Claude Code

The first main build of #466 failed liblouis and brltty at lock resolve:
their documentation BuildRequires (texlive-xetex, linuxdoc-tools) pull
TeX Live, whose xetex requires libicuuc.so.77, and the build root excludes
ICU 77. orca then failed on Fedora's ICU-77 brlapi for want of ours.

- liblouis does not link ICU: opt it in with buildroot_icu77, as libvdpau
  does for the same TeX Live chain.
- brltty links ICU, so ICU 77 in its root would ship an unusable brltty:
  drop linuxdoc-tools instead (configure then skips the manuals) and make
  the manual cleanup rm -f.

Refs #447

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EvvFSAwG7AzVee1EtWLK15

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hanthor
hanthor merged commit 62e0465 into main Oct 15, 2026
196 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants