Repository navigation
fix(screen-reader): build liblouis and brltty without Fedora's ICU 77 - #470
Merged
Merged
Conversation
The first main build of #466 failed liblouis and brltty at lock resolve: their documentation BuildRequires (texlive-xetex, linuxdoc-tools) pull TeX Live, whose xetex requires libicuuc.so.77, and the build root excludes ICU 77. orca then failed on Fedora's ICU-77 brlapi for want of ours. - liblouis does not link ICU: opt it in with buildroot_icu77, as libvdpau does for the same TeX Live chain. - brltty links ICU, so ICU 77 in its root would ship an unusable brltty: drop linuxdoc-tools instead (configure then skips the manuals) and make the manual cleanup rm -f. Refs #447 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EvvFSAwG7AzVee1EtWLK15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first
mainbuild after #466 (run 38798922994) built seven of the ten screen-reader packages. Three failed at lock resolve:texlive-xetex;linuxdoc-tools) pull in TeX Live. Itstexlive-xetexrequireslibicuuc.so.77, and the build root excludes ICU 77 by default.brlapi, because the factory's brltty didn't exist yet.What
The fix depends on whether the package itself links ICU.
"buildroot_icu77": trueinconfig/upstream-sources.json. This is the documented opt-in libvdpau already uses for the same TeX Live chain (tools/build_container.sh).libicu-devel). Admitting ICU 77 to its root would ship a brltty that the consumer set rejects, which is the failuretests/test_icu_staging.pydescribes. Instead:BuildRequires: linuxdoc-tools. Upstreamconfigurethen setscan_make_manual=no, so only the SGML manuals ship.rm -f.# Utah:comments.docs/skills/repeated-mistakes.md§23. Before reaching forbuildroot_icu77, check whether the package links ICU itself.Validation
packages: ["liblouis", "brltty", "orca"]). brltty and liblouis built, then orca built against them, and the run's publish and install gate passed. That run published under this branch's tag, not:latest.tools/factory_contract.pytools/validate.pytools/multimedia_closure.py --checktools/check_workflow_quoting.pytools/runtime_contract.py --checktools/factory_build_backlog.py --checkpytest: 1226 passed, 2 skipped.Refs #447
🤖 Generated with Claude Code
https://claude.ai/code/session_01EvvFSAwG7AzVee1EtWLK15
Generated by Claude Code