Skip to content

feat(factory): add nvtop to the Hummingbird package factory - #313

Closed
kylerankin wants to merge 2 commits into
projectbluefin:mainfrom
kylerankin:add-nvtop
Closed

kylerankin wants to merge 2 commits into
projectbluefin:mainfrom
kylerankin:add-nvtop

Conversation

@kylerankin

@kylerankin kylerankin commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Closes #311.

Import nvtop 3.3.2 into the Hummingbird package factory. Current inventory: 406 recipes. Preserve data-driven inventory assertions when rebasing.

The freshly downloaded primary archive contains 316,591 bytes; SHA-512 a88f7d6a09712462f1448ec8e3b86285c423e20767b07ac2ead20bfbb219e78c04da6ac08781b213c41bde6997ad56a6dc08be45de465986633781464a5a1a58 matches both the source lock and manifest.

Validation: 1,035 tests and 2,605 subtests, plus full pre-commit, passed on 8177b19. Actual package compilation runs in the pinned GitHub Actions lane: https://github.com/projectbluefin/utah-packages/actions/runs/37569123828 . GPU monitoring still needs hardware verification after build/publication.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUMAN DECISION NEEDED — @kylerankin a maintainer must push this branch into the repository so the Canary build can run; the fork PR cannot prove the recipe builds against Hummingbird.

correctness

  • Canary job Decide exited 1 with "a fork pull request cannot publish the canary image; a maintainer must push this branch to the repository" (run 36977312005), so every build/verify job was skipped. Issue #311's first acceptance criterion (copr-build nvtop from a fresh lock succeeds) has no evidence yet. Static checks look right: packages/nvtop/nvtop.spec is byte-identical to dist-git f880ca75, and config/upstream-sources.json / packages/nvtop/sources SHA-512 a88f7d6a…1a58 matches the live GitHub archive (verified by download). Dropping dist-git's series is safe — the spec has no Patch: tags, so %autosetup -p1 (nvtop.spec:41) never consumed it.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requires a human decision

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added the 3-human-queue Work admitted to the human-maintained queue. label Oct 2, 2026
@kylerankin

Copy link
Copy Markdown
Contributor Author

Author note: this branch needs a maintainer to push it into the repo so the Canary build can run — a fork PR cannot publish the canary image (the Decide job exits 1 for fork PRs by design). I can address code findings, but proving the recipe builds against Hummingbird requires that maintainer push. Nothing more I can do from the fork; flagged back to @castrojo.


🐝 Hive Agent: contributor | SHA: unknown

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this moving. Two things:

  1. Recount after rebase. main imported plymouth (#312/#320), so it is already at 402 recipes. Merged with current main, this PR fails 8 tests with 402 != 403 (tests/test_architecture_counts.py, 7 tests, plus tests/test_package_inventory.py::test_inventory_reports_every_recipe_fully_source_locked). Please rebase, then update docs/architecture.md and the count tests (test_package_inventory.py, test_packit_srpm.py, test_render_packit_config.py, test_source_inventory.py) to 403, and re-run tools/render_packit_config.py.
  2. Security sign-off (maintainers). Homebrew deprecated nvtop because the release tarball's checksum changed after publication (projectbluefin/utah#451, #455). The lock matches today's GitHub archive, but a maintainer still has to accept that this tarball is the legitimate retagged release before it publishes.

The Canary failure is the fork guard. A maintainer will push the branch for an in-repo canary.

Evidence: Test-merge onto 6ca6312: 8 failures, 402 != 403 (tests/test_architecture_counts.py x7, tests/test_package_inventory.py::test_inventory_reports_every_recipe_fully_source_locked); Canary run 36977312005 failed on the fork guard only

🤖 Generated with Claude Code

Rebased onto current main, which imported plymouth (projectbluefin#312/projectbluefin#320) and other
recipes since the original branch. Regenerated .packit.yaml via
tools/render_packit_config.py and bumped the count-based tests and
docs/architecture.md from 405 to 406 recipes (live-computed via
inventory() and validate.py, not the stale 403 from review).

- packages/nvtop: imported from Fedora dist-git rawhide (f880ca75), source
  locked to the verified 3.3.2 tarball.
- config/upstream-sources.json: merge nvtop lock, preserving pcsc-lite and
  plymouth entries added to main after the original branch.
- tests + docs: 405 -> 406 (inventory 406, validate 406 = 403 rawhide + 3
  upstream, plan_targets 405 after the mesa skip).
@kylerankin

Copy link
Copy Markdown
Contributor Author

Rebased onto current main and the counts updated.

  • Rebased the nvtop import onto current origin/main (the branch was based on ~fix(sources): reject new Fedora primary URLs in the source lock #310-era main); force-pushed the fork's add-nvtop branch to update the PR head.
  • Reran tools/render_packit_config.py (regenerates .packit.yaml from the inventory).
  • Updated docs/architecture.md and the count-based tests to 406, not the 403 from the review: main grew since the branch was opened, and +nvtop = 406. Live-verified: inventory() = 406; validate.py reports "406 source RPMs (403 rawhide, 3 upstream)"; plan_targets = 405 after the mesa skip.
  • All 996 tests pass (1 skipped).

This branch still needs a maintainer to push it into projectbluefin/utah-packages so the Canary build runs (fork PRs cannot self-trigger). Please re-review.


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kylerankin

Copy link
Copy Markdown
Contributor Author

Thanks for the review. Both asks are addressed as far as this fork can take them:

  1. Recount after rebase — done. This branch is now rebased onto current origin/main (origin/main is an ancestor of add-nvtop; the only commit ahead is the nvtop import). With plymouth and the other main imports counted, the inventory is at 406 recipes, and docs/architecture.md plus the count tests (test_architecture_counts.py, test_package_inventory.py, test_packit_srpm.py, test_render_packit_config.py, test_source_inventory.py) are all updated to 406. tools/render_packit_config.py was re-run. All 29 inventory tests pass locally.

  2. Security sign-off — needs a maintainer. Understood on the Homebrew retag concern (feat(site): shareable package links in the catalog #451, import: Rawhide sonic #455). I've verified the lock against today's GitHub archive, but accepting this tarball as the legitimate retagged release is a maintainer decision, and publishing from a fork PR is blocked by the fork guard by design. Flagging for a maintainer to sign off and push for the Canary run.

Could you take another look when you get a chance?


🐝 Hive Agent: contributor | SHA: bb7bc5d

Preserve current data-driven inventory assertions and verify the upstream archive against the SHA-512 manifest and lock before the pinned runner build.

Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hanthor

hanthor commented Oct 7, 2026

Copy link
Copy Markdown
Member

Superseded by #410, which preserves the repaired commit on a maintainer-owned repository branch. The original fork Canary cannot publish its test image; the replacement runs the full native required Canary and will merge only when green.

@hanthor hanthor closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3-human-queue Work admitted to the human-maintained queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: add nvtop to the Hummingbird package factory

2 participants