Repository navigation
refactor(ci): align Justfile check with CI workflow gate catalog - #163
Closed
mrbobbytables wants to merge 1 commit into
Closed
mrbobbytables wants to merge 1 commit into
mrbobbytables wants to merge 1 commit into
Conversation
`just check` is documented as "Everything CI gates on, minus the builds", but the gate catalog was restated independently with divergent contents: * Justfile `check` ran tools/factory_contract.py and tools/validate.py; * .github/workflows/validate.yml ran those two plus pytest; * the prepare job of .github/workflows/rebuild-rpms.yml ran tools/check_workflow_quoting.py, tools/runtime_contract.py --check, and unittest. tools/check_workflow_quoting.py and tools/runtime_contract.py were absent from the documented local gate, leading to local vs CI discrepancies. Justfile: `check` now runs all five gates (factory-check, validate, workflow-quoting, runtime-contract, test), and each gate gets its own named recipe. tests/test_gate_catalog.py: structural consistency test that derives gates from validate.yml and rebuild-rpms.yml (prepare validation step) and asserts bidirectional agreement with reachable commands from `just check`. Avoids false positives on pipeline steps (rebuild_matrix.py, source_pipeline.py) and enforces that runtime_contract.py retains --check mode. docs/architecture.md, AGENTS.md, README.md, docs/contributing.md: update documentation to reflect all five gates run by `just check`. Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
castrojo
reviewed
Sep 19, 2026
castrojo
left a comment
Contributor
There was a problem hiding this comment.
Substantive review:
- CI & Gate Alignment: Aligns Justfile check with workflow gates and adds tests/test_gate_catalog.py to structurally assert bidirectional parity between Justfile and CI workflow gates.
- Failure analysis: The rebuild failure on libnice was due to transient build environment network timeout during dnf repo download, unrelated to Justfile/gate tooling changes.
- Validation: Factory contract, validate.py, recipe set agreement, and all 321 unit tests pass cleanly against main.
- Outstanding: Awaiting independent peer/human approval (+2) before landing.
Member
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #126. Addresses review feedback from #127.
The factory gate catalog was restated across the
Justfile,.github/workflows/validate.yml, and thepreparejob of.github/workflows/rebuild-rpms.yml, leading to drift wheretools/check_workflow_quoting.pyandtools/runtime_contract.py ... --checkwere omitted fromjust check.Changes
Justfile:checknow runs all five gates:factory-check:python3 tools/factory_contract.pyvalidate:python3 tools/validate.pyworkflow-quoting:python3 tools/check_workflow_quoting.pyruntime-contract:python3 tools/runtime_contract.py config/bluefin-packages.toml config/runtime-contract.toml --checktest:python3 -m pytest tests -qEach gate is also runnable individually via its own named recipe.
tests/test_gate_catalog.py: New structural consistency test:validate.ymland theValidate factory policy and testsstep ofrebuild-rpms.yml(plus any step in other workflows explicitly marked with# gate). This prevents false positives on pipeline steps such astools/rebuild_matrix.pyandtools/source_pipeline.py.pytestandunittest discoveras equivalent test suite runs).just checkruns every gate CI enforces and runs no gate that CI does not enforce.runtime_contract.pyis invoked with--check.Documentation:
docs/architecture.mdto detail all five gates and reflect thatjust checkruns the entire catalog locally.AGENTS.md,README.md, anddocs/contributing.mdcomments describingjust check.Note:
.pre-commit-config.yamlremains a separate hook configuration for pre-commit linting. Part B from #126 (adding the missing jobs tovalidate.yml) requires workflow file edits reserved for human maintainers or agents withworkflowsscope.— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:fd6d416