Repository navigation
fix(gaps): drop runtime-contract [unavailable] packages from the parity report - #175
Closed
hivecommons-hive[bot] wants to merge 1 commit into
Closed
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…ty report recalculate_hummingbird_gaps.py built the contract from every section of config/bluefin-packages.toml except [excluded] and never read config/runtime-contract.toml. The six packages Utah deliberately dropped — firefox, slitherer, anaconda-live, evolution-ews-core, fish, zsh — were therefore counted as parity debt Hummingbird still owed, contradicting tools/runtime_contract.py, which already filters the same list out of the resolved transaction. Add a --policy argument defaulting to config/runtime-contract.toml, subtract [unavailable] from the contract, and record the subtraction as excluded_as_unavailable so the exclusions stay auditable rather than silent. The workflow call site relies on argument defaults, so it needs no change. On the real manifest the contract drops from 77 to 71 and firefox no longer appears in missing_from_hummingbird. Assisted-by: Claude Opus 5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "scanner" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
castrojo
reviewed
Sep 19, 2026
castrojo
left a comment
Contributor
There was a problem hiding this comment.
Substantive review:
- Correctness: Subtracts [unavailable] packages from the runtime contract in tools/recalculate_hummingbird_gaps.py and records them under excluded_as_unavailable, properly reconciling gap reporting with runtime contract policy.
- Test Coverage: Unit tests comprehensively cover contract partitioning, exclusion auditing, non-revival on image presence, and end-to-end integration against real config files.
- Validation: Factory contract, validate.py, and unittest suite pass cleanly against current main.
- Outstanding: PR carries the hold label and requires human maintainer review to remove hold before landing.
Member
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
tools/recalculate_hummingbird_gaps.pybuilt the parity contract from every section ofconfig/bluefin-packages.tomlexcept[excluded], and never readconfig/runtime-contract.toml. The six packages Utah has deliberately dropped —firefox,slitherer,anaconda-live,evolution-ews-core,fish,zsh— were counted as parity debt Hummingbird still owed.That contradicted
tools/runtime_contract.py, which already filters the same[unavailable]list out of the resolved transaction. The two measurements disagreed: the runtime contract said firefox was out, the gap report said firefox was owed.Changes
tools/recalculate_hummingbird_gaps.py: add a--policyargument defaulting toconfig/runtime-contract.toml, subtract[unavailable]from the contract, and record the subtraction asexcluded_as_unavailable(plus a matching count) so the exclusions stay auditable rather than silent. Reusesload_policy/package_sectionfromtools/runtime_contract.pyvia thesys.path+from tools.X import Ypattern the other tools already use.tests/test_hummingbird_gaps.py: pin the new rule — exclusions leave the contract, dropped names are reported, an exception for a package the manifest never named does not inflate the audit list, availability does not revive an exception, a policy with no[unavailable]section drops nothing, and a malformed section is rejected. Plus an end-to-end check against the realconfig/pair asserting firefox is absent frommissing_from_hummingbird.The workflow call site (
.github/workflows/recalculate-hummingbird-gaps.yml) passes neither--manifestnor--outputand relies on defaults, so no workflow change is required — nothing in this PR touches.github/workflows/.Verification
On the real manifest the contract drops from 77 to 71, matching what the runtime contract resolves:
Gates run locally on this branch:
Closes #174
Refs #112 — this closes that issue's "verify the current package set against the packages already provided for hummingbird" half. The "drop firefox from the build" half was already done before this PR: there is no
packages/firefoxrecipe, andconfig/runtime-contract.tomlalready lists firefox as[unavailable], soruntime_contract.resolve()yields 71 packages with zero firefox entries. #112 is left open only because closing it is a maintainer's call on whether the Flatpak-vs-RPM request is now fully satisfied.Scope
Touches only
tools/recalculate_hummingbird_gaps.pyandtests/test_hummingbird_gaps.py. Disjoint from the other open utah-packages PRs: #143 (tests/test_rebuild_matrix.py), #152 (tests/test_packit_workflow.py), #171 (tools/rebuild_plan.py), #164 (tests/test_recipe_set_agreement.py), #163 (Justfile,tests/test_gate_catalog.py), #162 (tests/test_architecture_counts.py).Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.78 requested_by=@hanthor