Repository navigation
test: architecture.md inventory-count drift gate - #162
Closed
mrbobbytables wants to merge 1 commit into
Closed
mrbobbytables wants to merge 1 commit into
mrbobbytables wants to merge 1 commit into
Conversation
The Coverage section of docs/architecture.md publishes four numbers as verifiable command output: 'ls -d packages/*/ | wc -l', the .packit.yaml and config/upstream-sources.json entry counts, and the line tools/validate.py prints. Nothing kept them honest. All four claimed stale counts while the repository inventory evolved, so the document stating the factory's coverage contract disagreed with the factory. Correct the counts in docs/architecture.md, and add tests/test_architecture_counts.py, which recomputes each one dynamically from tools.package_inventory.inventory -- the same contract the factory reads -- and compares the quoted validate.py report against tools/validate.py's actual output. The hand-assigned stage count quoted in the review table is gated the same way. Closes projectbluefin#102 Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
castrojo
reviewed
Sep 19, 2026
castrojo
left a comment
Contributor
There was a problem hiding this comment.
Substantive review:
- Correctness & Robustness: The new tests/test_architecture_counts.py introduces automated drift detection for package inventory assertions in docs/architecture.md, checking against tools.package_inventory and tools.validate.
- Validation: All 324 unit tests, factory contract, and validate.py pass cleanly against main.
- Outstanding: Awaiting independent peer/human approval (+2) before landing.
Member
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Coverage section of
docs/architecture.mdpublishes four numbers as verifiable command output (ls -d packages/*/ | wc -l,.packit.yamlpackages count,config/upstream-sources.jsonpackages count, and the output oftools/validate.py). Nothing kept them honest, causing the document's coverage contract claims to drift as recipes were added or removed.This PR:
docs/architecture.mdto reflect current repository state (340 recipes, and 61 packages carrying a hand-assignedstage).tests/test_architecture_counts.pyto dynamically recompute each claim fromtools.package_inventory.inventoryandtools.package_inventory.source_locks.tools/validate.pyin the test to verify that it succeeds (exit 0) and thatdocs/architecture.mdaccurately quotes its output.config/upstream-sources.json.Closes #102
— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:c3931a8