Skip to content

fix: complete the firefox recipe removal and gate partial removals - #131

Closed
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-firefox-removal-drift
Closed

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-firefox-removal-drift

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #130

Fix

0312fbe deleted packages/firefox/ and stopped there. docs/contributing.md § Removing a package requires a recipe removal to reach four places; three were skipped, so main currently holds 191 recipe directories against 192 source locks and 192 .packit.yaml blocks. Three unit tests fail as a result, which is why prepare is red on main and on every PR branched from it.

Reproduced before the change:

FAIL: test_inventory_reports_every_recipe_fully_source_locked (test_package_inventory)
FAIL: test_rendered_config_matches_repository_file (test_render_packit_config)
FAIL: test_hummingbird_supplied_packages_are_skipped_by_default (test_source_inventory)
Ran 181 tests in 2.729s
FAILED (failures=3)

Files and functions this PR claims

  • config/upstream-sources.json — delete the orphaned firefox 155.0 lock (192 → 191 entries).
  • .packit.yaml — regenerated with python3 tools/render_packit_config.py --write, which drops the firefox block (192 → 191 specfile_path: blocks).
  • tests/test_package_inventory.py PackageInventoryTests.test_inventory_reports_every_recipe_fully_source_locked — count 192 → 191.
  • tests/test_render_packit_config.py RenderPackitConfigTests.test_rendered_config_matches_repository_file — count 192 → 191.
  • tests/test_packit_srpm.py PackitSrpmTests.test_workflow_stages_verified_sources_for_every_configured_package — count 192 → 191. This one was passing only because .packit.yaml was also stale; regenerating without touching it would have turned one red test into two.
  • tests/test_source_inventory.py TargetSelectionTests.test_hummingbird_supplied_packages_are_skipped_by_default — count 191 → 190.
  • tests/test_recipe_set_agreement.py — new, RecipeSetAgreementTests.
  • docs/contributing.md § Removing a package — point at the new test, and say to regenerate .packit.yaml rather than hand-edit the block.

Why a new test rather than only bumping the numbers

tests/test_package_inventory.py already carried # 192: gcc was dropped from the rebuild set (...#69). The same partial-removal breakage happened at the gcc removal and was fixed by hand-bumping the magic number, which left nothing behind to catch the next one. The procedure is documented; nothing enforced it.

RecipeSetAgreementTests compares packages/, config/upstream-sources.json and .packit.yaml against each other and fails by name:

  • test_every_recipe_has_a_source_lock — a recipe with no lock is not eligible to build.
  • test_no_source_lock_outlives_its_recipe — the exact state this PR is cleaning up.
  • test_packit_config_covers_exactly_the_recipes — tells you to run render_packit_config.py --write.

Verified it actually catches the failure mode, by deleting packages/fish/ and leaving the other two places alone:

AssertionError: Items in the first set but not the second:
Ran 3 tests in 0.008s
FAILED (failures=2)

The count assertions are kept — they still gate a deliberate change in set size — but they now sit behind a check that says where.

Verification

python3 tools/validate.py          # validated 191 source RPMs
python3 tools/factory_contract.py  # factory contract satisfied (1675 tracked files checked)
python3 -m pytest tests -q         # 184 passed, 27 subtests passed

Scope

firefox is correctly out of the rebuild set — #113 ships it as a Flatpak. This PR does not revisit that decision; it only completes the three steps the deletion did not reach.

It does not touch precedence / detect / verify, which are red on main for an unrelated reason (manifest for quay.io/fedora/fedora@sha256:a58a82ed... not found, exit 125). #116 and #122 already cover that and are awaiting review.


Hold-gated: human review required.

— hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.78

Commit 0312fbe deleted packages/firefox/ and stopped there. docs/contributing.md
requires a recipe removal to reach four places; three were skipped, leaving 191
recipe directories against 192 source locks and 192 .packit.yaml blocks. Three
unit tests fail on main as a result, so prepare is red there and on every PR
branched from it.

Delete the orphaned firefox lock, regenerate .packit.yaml, and move the four
hardcoded package counts to the new set size.

The counts only report that the set changed size. Add
tests/test_recipe_set_agreement.py, which compares packages/,
config/upstream-sources.json and .packit.yaml against each other and names the
place a removal did not reach, and point docs/contributing.md at it.

Assisted-by: Claude Opus 5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added the hold Work is intentionally paused. label Sep 17, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "scanner" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "scanner". If this is an outreach PR, a human must review it and remove the label.

@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

Closing: it conflicts across .packit.yaml, config/upstream-sources.json and the inventory tests since #70, and the hive agent doesn't rebase. The two real leftovers it found — the stale firefox key in config/upstream-sources.json and the reference in tests/test_hummingbird_gaps.py — are a two-line cleanup I'll carry directly; #130 stays open until they're gone.


Generated by Claude Code

@hanthor hanthor closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Work is intentionally paused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] main is red: the firefox recipe deletion skipped 3 of the 4 steps in docs/contributing.md

1 participant