Skip to content

fix(firefox): drop firefox from the rebuild set, ship via flatpak (fixes #112) - #113

Closed
mendezr wants to merge 1 commit into
projectbluefin:mainfrom
mendezr:drop-firefox
Closed

mendezr wants to merge 1 commit into
projectbluefin:mainfrom
mendezr:drop-firefox

Conversation

@mendezr

@mendezr mendezr commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Drops Firefox from the rebuild set — the project ships Firefox via the flatpak, so the RPM rebuild is redundant (issue #112).

The packages/firefox/ recipe directory was already deleted on main; this PR finishes removing Firefox from the build wiring:

  • config/upstream-sources.json: remove the firefox source lock entry
  • .packit.yaml: remove the firefox package block
  • config/bluefin-packages.toml: remove firefox from the base image package list and firefox-langpacks from the exclusion list
  • .github/workflows/build-stage.yml: drop the now-unused Firefox PGO/LTO swap workaround step
  • tests/: track the 192 → 191 package count

Verification

  • tools/validate.py reports validated 191 source RPMs
  • tools/factory_contract.py satisfied
  • All firefox-related unit tests pass with updated counts

closes #112

— hive: backend=goose model=deepseek/deepseek-v4-flash-0731

Firefox is shipped through the flatpak and does not need to be rebuilt
here. The recipe directory was already deleted upstream; finish removing
the firefox references from the build wiring:

- config/upstream-sources.json: drop the firefox source lock entry
- .packit.yaml: drop the firefox package block
- config/bluefin-packages.toml: remove firefox from the base image
  package list and firefox-langpacks from the exclusion list
- .github/workflows/build-stage.yml: drop the now-unused Firefox
  PGO/LTO swap workaround
- tests/: track the 192 -> 191 package counts

closes projectbluefin#112

Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

Closing as superseded: packages/firefox/ was removed in 0312fbe and #70 (5116be9) finished the job — Firefox ships as a Flatpak and the factory doesn't build it. Two leftovers remain on main (a stale firefox key in config/upstream-sources.json and a reference in tests/test_hummingbird_gaps.py), which is what #131 addresses.


Generated by Claude Code

@hanthor hanthor closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WE DO NOT NEED FIREFOX WE USE THE FLATPAK

2 participants