Repository navigation
test(common): skip the layered-RPM check on Utah, which has no rpm-ostree - #1268
Merged
Merged
Conversation
…tree Utah is RPM-based but updates with bootc and ships no rpm-ostree on purpose, like Dakota. Since #1249 the "No RPM packages are layered" scenario skips only on Dakota, so every Utah post-testing E2E run fails common-a with "sudo: rpm-ostree: command not found". Let the @requires_rpm_ostree skip apply to Utah images too. Every other image still runs the check, so a missing rpm-ostree there still fails. Refs projectbluefin/utah#1329 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Looks correct to me.
context.is_utah_imageis populated inbefore_all(tests/common/features/environment.py:148) fromimage_under_test(), the same source asis_dakota_image, so composed runs see the base image's family, not the derivedtestsuite-e2eref.- The new condition still needs the rpm-ostree probe to fail before it skips (
environment.py:244-251). A Utah image that does ship rpm-ostree still runs the check, and non-Dakota/non-Utah images still fail on a missing binary, which keeps the guarantee from #1249. - Setting
is_utah_image=Falseexplicitly intest_non_dakota_image_never_skips_even_when_probe_failsis needed, not cosmetic:_ctxbuilds aMagicMock, so an unset attribute would makegetattr(..., "is_utah_image", False)truthy and the test would pass for the wrong reason. test_skips_on_utah_when_rpm_ostree_is_absentfails without theenvironment.pychange, because withis_dakota_image=Falsethe old code never skips.
I could not run pytest locally; the CI pytest and Behave dry-run checks are green on 2634ebe. Refs projectbluefin/utah#1329 fits, since Utah only picks this up after its pinned testsuite SHA is bumped.
Confidence: 5/5 (safe)
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326
This was referenced Nov 18, 2026
Contributor
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. stage 100-merge-queue → 080-awaiting-merge-admission: native-merge-queue-enqueue |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Utah has no
rpm-ostreeon purpose, so the "No RPM packages are layered" check can't run there. It now skips on Utah the same way it already skips on Dakota.Why
Every Utah Post-Testing E2E run since 2026-11-16 fails
common-aon this one scenario (projectbluefin/utah#1329). The VM log showssudo: rpm-ostree: command not found. Utah updates with bootc only and does not ship rpm-ostree. #1249 limited the skip to Dakota.Example run: https://github.com/projectbluefin/utah/actions/runs/44242685919 (all four flavors:
51 scenarios passed, 1 failed, the failure iscommon_immutable.feature:15).Change
tests/common/features/environment.py: the@requires_rpm_ostreeskip applies when the image is Dakota or Utah and the rpm-ostree probe fails. Other images still run the check and fail if rpm-ostree is missing.is_utah_image=Falseexplicitly.suite-mapskill: documents@requires_rpm_ostree.Checks
ruff check tests/ --select E,F,W --ignore E501: passpython3 -m pytest tests/unit/ -q: 3106 passedbehave --dry-run tests/common/features: okvalidate_docs.py,generate_skill_index.py --check: passUtah picks this up when its pinned testsuite SHA is bumped (Renovate).
Refs projectbluefin/utah#1329
🤖 Generated with Claude Code