Skip to content

test(common): skip the layered-RPM check on Utah, which has no rpm-ostree - #1268

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
fix/common-utah-rpm-ostree-skip
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
fix/common-utah-rpm-ostree-skip

Conversation

@hanthor

@hanthor hanthor commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary: Utah has no rpm-ostree on purpose, so the "No RPM packages are layered" check can't run there. It now skips on Utah the same way it already skips on Dakota.

Why

Every Utah Post-Testing E2E run since 2026-11-16 fails common-a on this one scenario (projectbluefin/utah#1329). The VM log shows sudo: rpm-ostree: command not found. Utah updates with bootc only and does not ship rpm-ostree. #1249 limited the skip to Dakota.

Example run: https://github.com/projectbluefin/utah/actions/runs/44242685919 (all four flavors: 51 scenarios passed, 1 failed, the failure is common_immutable.feature:15).

Change

  • tests/common/features/environment.py: the @requires_rpm_ostree skip applies when the image is Dakota or Utah and the rpm-ostree probe fails. Other images still run the check and fail if rpm-ostree is missing.
  • Unit test for the Utah skip; the "non-Dakota never skips" test now sets is_utah_image=False explicitly.
  • suite-map skill: documents @requires_rpm_ostree.

Checks

  • ruff check tests/ --select E,F,W --ignore E501: pass
  • python3 -m pytest tests/unit/ -q: 3106 passed
  • behave --dry-run tests/common/features: ok
  • validate_docs.py, generate_skill_index.py --check: pass

Utah picks this up when its pinned testsuite SHA is bumped (Renovate).

Refs projectbluefin/utah#1329

🤖 Generated with Claude Code

…tree

Utah is RPM-based but updates with bootc and ships no rpm-ostree on
purpose, like Dakota. Since #1249 the "No RPM packages are layered"
scenario skips only on Dakota, so every Utah post-testing E2E run fails
common-a with "sudo: rpm-ostree: command not found".

Let the @requires_rpm_ostree skip apply to Utah images too. Every other
image still runs the check, so a missing rpm-ostree there still fails.

Refs projectbluefin/utah#1329

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

  • context.is_utah_image is populated in before_all (tests/common/features/environment.py:148) from image_under_test(), the same source as is_dakota_image, so composed runs see the base image's family, not the derived testsuite-e2e ref.
  • The new condition still needs the rpm-ostree probe to fail before it skips (environment.py:244-251). A Utah image that does ship rpm-ostree still runs the check, and non-Dakota/non-Utah images still fail on a missing binary, which keeps the guarantee from #1249.
  • Setting is_utah_image=False explicitly in test_non_dakota_image_never_skips_even_when_probe_fails is needed, not cosmetic: _ctx builds a MagicMock, so an unset attribute would make getattr(..., "is_utah_image", False) truthy and the test would pass for the wrong reason.
  • test_skips_on_utah_when_rpm_ostree_is_absent fails without the environment.py change, because with is_dakota_image=False the old code never skips.

I could not run pytest locally; the CI pytest and Behave dry-run checks are green on 2634ebe. Refs projectbluefin/utah#1329 fits, since Utah only picks this up after its pinned testsuite SHA is bumped.

Confidence: 5/5 (safe)

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot added this pull request to the merge queue Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 18, 2026
Merged via the queue into main with commit 5d942c2 Nov 18, 2026
14 checks passed
@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

stage 100-merge-queue → 080-awaiting-merge-admission: native-merge-queue-enqueue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants