Repository navigation
ci: drop the hardware-only nvidia suite from the CI VM testsuite matrix - #1337
Conversation
Every scenario in the testsuite's nvidia suite is @hardware_blocked, so in the GPU-less CI VM the leg fails as "blocked" on every run for utah-nvidia and utah-nvidia-gaming (projectbluefin/testsuite#706). Run only smoke,common there until the lab has GPU runners (projectbluefin/lab#1182). Refs #1329 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Summary: This change stops the project's automated test runs from trying NVIDIA graphics-card tests on virtual machines that have no graphics card, where those tests can never pass. The change itself is sound and matches what the maintainer asked for in the tracking issue. One sentence in the troubleshooting guide still says the NVIDIA tests are part of the run, which is no longer true after this change.
What I need from you: Apply the one-line doc fix in the inline comment.
docs-currency
docs/skills/ci-workflows/references/testsuite-triage.md:13-14still says "the advisory matrix also includesnvidia". After this PR,config/flavors.json:10,12gives every flavorsmoke,common, andscripts/flavors.py:60-68builds thetestsuitematrix from that map alone. No leg runsnvidianow, so this sentence contradicts line 4 and lines 19-22 of the same file. Fix is in the inline comment.
Checked and found fine: the matrix is built only from the suites map, with no hardcoded nvidia suite in .github/ or scripts/. tests/test_flavors.py:107-131 uses its own fixture config, not the real file, so it is unaffected. The intent matches the maintainer's triage and diagnosis on #1329 ("drop the nvidia suite from the CI-VM matrix ... while projectbluefin/lab#1182 is open"; "Fix: #1337"). The removal of the earlier "do not suppress the hardware suite" line follows that decision.
No findings from: correctness, security, intent-alignment, style.
Findings not on a changed line
-
docs/skills/ci-workflows/references/testsuite-triage.md:12-14: Stale after this PR: no flavor'ssuitesentry inconfig/flavors.jsonincludesnvidiaanymore, andscripts/flavors.py suitesbuilds the matrix only from that map. So the advisory matrix no longer includesnvidia, which contradicts line 4 and lines 19-22.testing-to-main promotion sets `run_e2e: false`. The release gate separately re-runs the `smoke,common` suites against the exact candidate digests, the same suites the advisory matrix runs.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326
|
@hanthor this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (14 waiting): fixes are handed out before new work as soon as you have capacity. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Summary: Stop running the NVIDIA hardware tests in CI VMs that have no NVIDIA GPU. They can never pass there, so they turned every Post-Testing E2E run red.
Why
In every recent run (for example https://github.com/projectbluefin/utah/actions/runs/44242685919) the
nvidialeg forutah-nvidiaandutah-nvidia-gamingends with:Every scenario is
@hardware_blocked, so nothing runs and the leg fails anyway. This is a hardware gap, not an image bug.Change
config/flavors.json:nvidiaandnvidia-gamingrunsmoke,common, same as the other flavors.docs/skills/flavors.md,testsuite-triage.md: say why, and when to add the suite back (GPU runners, Lab-repo infrastructure prerequisites blocking test coverage lab#1182).The NVIDIA images still get
smoke,commonand the LUKS/ISO jobs. The release gate already runs onlysmoke,common.Checks
just checkandpre-commitpass locally.Refs #1329 (one of two causes; the other is projectbluefin/testsuite#1268)
🤖 Generated with Claude Code