Skip to content

ci: drop the hardware-only nvidia suite from the CI VM testsuite matrix - #1337

Merged
hanthor merged 5 commits into
mainfrom
ci/drop-nvidia-suite-from-vm-e2e
Nov 18, 2026
Merged

hanthor merged 5 commits into
mainfrom
ci/drop-nvidia-suite-from-vm-e2e

Conversation

@hanthor

@hanthor hanthor commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary: Stop running the NVIDIA hardware tests in CI VMs that have no NVIDIA GPU. They can never pass there, so they turned every Post-Testing E2E run red.

Why

In every recent run (for example https://github.com/projectbluefin/utah/actions/runs/44242685919) the nvidia leg for utah-nvidia and utah-nvidia-gaming ends with:

Suite 'smoke,common,nvidia' is blocked: every scenario requires hardware the CI VM lacks (see projectbluefin/testsuite#706)

Every scenario is @hardware_blocked, so nothing runs and the leg fails anyway. This is a hardware gap, not an image bug.

Change

The NVIDIA images still get smoke,common and the LUKS/ISO jobs. The release gate already runs only smoke,common.

Checks

just check and pre-commit pass locally.

Refs #1329 (one of two causes; the other is projectbluefin/testsuite#1268)

🤖 Generated with Claude Code

Every scenario in the testsuite's nvidia suite is @hardware_blocked, so in
the GPU-less CI VM the leg fails as "blocked" on every run for
utah-nvidia and utah-nvidia-gaming (projectbluefin/testsuite#706). Run
only smoke,common there until the lab has GPU runners
(projectbluefin/lab#1182).

Refs #1329

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change stops the project's automated test runs from trying NVIDIA graphics-card tests on virtual machines that have no graphics card, where those tests can never pass. The change itself is sound and matches what the maintainer asked for in the tracking issue. One sentence in the troubleshooting guide still says the NVIDIA tests are part of the run, which is no longer true after this change.

What I need from you: Apply the one-line doc fix in the inline comment.


docs-currency

  • docs/skills/ci-workflows/references/testsuite-triage.md:13-14 still says "the advisory matrix also includes nvidia". After this PR, config/flavors.json:10,12 gives every flavor smoke,common, and scripts/flavors.py:60-68 builds the testsuite matrix from that map alone. No leg runs nvidia now, so this sentence contradicts line 4 and lines 19-22 of the same file. Fix is in the inline comment.

Checked and found fine: the matrix is built only from the suites map, with no hardcoded nvidia suite in .github/ or scripts/. tests/test_flavors.py:107-131 uses its own fixture config, not the real file, so it is unaffected. The intent matches the maintainer's triage and diagnosis on #1329 ("drop the nvidia suite from the CI-VM matrix ... while projectbluefin/lab#1182 is open"; "Fix: #1337"). The removal of the earlier "do not suppress the hardware suite" line follows that decision.

No findings from: correctness, security, intent-alignment, style.

Findings not on a changed line

  • docs/skills/ci-workflows/references/testsuite-triage.md:12-14: Stale after this PR: no flavor's suites entry in config/flavors.json includes nvidia anymore, and scripts/flavors.py suites builds the matrix only from that map. So the advisory matrix no longer includes nvidia, which contradicts line 4 and lines 19-22.

    testing-to-main promotion sets `run_e2e: false`. The release gate separately
    re-runs the `smoke,common` suites against the exact candidate digests, the
    same suites the advisory matrix runs.
    

Confidence: 3/5 (needs attention) — 1 perspective requested changes

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@hanthor this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes
  • review finding: docs/skills/ci-workflows/references/testsuite-triage.md:14 Triage runbook still says the advisory matrix includes the nvidia suite

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (14 waiting): fixes are handed out before new work as soon as you have capacity.

@hanthor
hanthor enabled auto-merge (squash) November 18, 2026 17:15
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 18, 2026
@hanthor
hanthor merged commit d67dd76 into main Nov 18, 2026
25 checks passed
@hanthor
hanthor deleted the ci/drop-nvidia-suite-from-vm-e2e branch November 18, 2026 18:50
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant