Skip to content

ci: boot the suites a pull request affects before it merges - #1142

Merged
hivecommons-hive[bot] merged 3 commits into
mainfrom
ci/pr-vm-check
Nov 12, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
mainfrom
ci/pr-vm-check

Conversation

@Danathar

@Danathar Danathar commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary: adds "PR VM check", which boots the test suites a pull request affects before it merges. Today e2e.yml only runs when something calls it, and contributor agents aren't allowed to start workflows. So a VM-related change gets its first VM run either after merge (as a v1 hold) or when a maintainer starts a manual run by hand. On 2026-11-10 every VM question (#827, #838, #908, #1138, #1139) waited on a person starting a run.

How it works

  1. Plan: diffs GitHub's merge commit against its first parent (exactly the PR's own change) and runs the same planner the post-merge v1 gate uses (scripts/vm_validation_plan.py, then scripts/v1_gate.py).
  2. Decision:
    • move: docs, unit tests, repo tooling. Boots nothing; done in seconds.
    • gate: boots the planned suites through e2e.yml on dakota:testing, pinned by digest, with test_ref = the merge commit.
    • hold: a change the gate can't boot (for example, the gnome-e2e composite action). Posts a notice and boots nothing; the skill doc says how to validate it instead (gnomeos-canary.yml for the action, a hand check for suites with no hosted lane).
  3. Not a required check in the ruleset, but the hive merges no PR while any check is red, so in practice it blocks hive merges (see below). Whether to make it required can be decided later, once it has run for a while (finpilot's PR image build went the same way).

Safety and cost

  • pull_request trigger (not pull_request_target), contents: read at the top. The boot job grants packages: write only because e2e.yml's jobs ask for it (a called workflow can't be given less), for the desktop-screenshot push.
  • Fork PRs get a read-only token, so that push (continue-on-error) is skipped there. No secrets are used.
  • Same-repo PRs will update the published "latest" desktop screenshot, as manual runs already do. Stopping that needs an e2e.yml change (a release file), so it's left as a follow-up.
  • Runner time: about 15–25 minutes per booted suite, only on PRs that reach a VM. A newer push cancels the running check (concurrency per PR).

Red means this PR broke something

The check is strict: any failing scenario turns it red, and the hive won't merge a PR with a red check, required or not (FailOnAnyFailedCheck in its merge gate). So it only works if main itself is green on the image:

A PR that runs into a new image failure before the hive handles it will be red until it is. That trade was chosen over a baseline comparison here, because each e2e.yml VM job is its own check and a comparison job can't turn those green.

Proof

This PR changes the workflow itself, which the planner maps to the full lane set. So its own run boots common and smoke (lifecycle stays ungated, as at the gate). Planned locally:

  • this PR → gate (common, smoke);
  • README/runbook only → move;
  • tests/common/...feature → gate (common);
  • .github/actions/gnome-e2e/action.yml → hold.

actionlint is clean. zizmor's only note is the ./ vs $/ self-reference style; every other workflow here uses ./.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn

e2e.yml only runs when something calls it, and contributor agents may
not dispatch workflows, so a VM-related change got its first VM run
after merge (as a v1 hold) or when a maintainer started a manual run.
On 2026-11-10 every VM question (#827, #838, #908, #1138, #1139) waited
on a person starting a run.

Add "PR VM check": on every pull request, plan the PR's own changes with
the v1 gate's planner (vm_validation_plan.py + v1_gate.py) and, when a
VM is needed, boot those suites through e2e.yml on dakota:testing pinned
by digest, testing the merge commit. Docs-only and tooling PRs boot
nothing; a change the gate cannot boot (the gnome-e2e composite action)
gets a notice. Advisory, not required. This PR changes the workflow
itself, so it boots common and smoke as its own proof.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor
9d26e0c

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @Danathar, head 9d26e0c5b3ee) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/pr-vm-check.yml
  • permission_escalation — widens workflow permissions or uses pull_request_target (Widens GitHub Actions permissions or switches to pull_request_target)
    • .github/workflows/pr-vm-check.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@Danathar
Danathar marked this pull request as draft November 11, 2026 01:16
@hivecommons-hive hivecommons-hive Bot removed the stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act label Nov 11, 2026
@Danathar

Copy link
Copy Markdown
Contributor Author

Converted to draft: this PR's own run booted smoke on dakota:testing and found 6 pre-existing failures (power-status-color extension missing from the image; geoclue/nfs-idmapd/rpc-statd failing at boot). The v1 gate tolerates them via its v1 baseline, but a per-PR check would turn every smoke-touching PR red, and the hive won't merge with a red check. Waiting on #1143; this comes out of draft once smoke is green on dakota:testing.

Picks up #1158 (Power panel skip on hardware-free VMs) and #1157 so the
PR VM check's own run boots against today's main.

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added the stage/050-review-pending Review swarm requested; awaiting a verdict for the current head label Nov 11, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: The new guidance sends contributors to a manual test run when automatic testing cannot cover their change. That manual run cannot exercise the separate desktop-testing tool, so following the instruction can still leave the changed code untested.

What I need from you: Correct the manual-validation instructions for changes the automatic check cannot cover.


docs-currency

candidate-vm-validation.md:61–65: The new paragraph recommends the manual run below for hold, including changes to the gnome-e2e composite action. But manual.yml:36–49 only calls e2e.yml, which never executes that action (vm_validation_plan.py:22–26). Point those changes to a workflow that actually invokes the action:

-skipped there. Use a manual run (below) for another image, or for a `hold`.
+skipped there. Use a manual run (below) for another image. For a `hold`
+caused by the `gnome-e2e` composite action, use a workflow that calls that
+action at the PR ref. For a suite without a hosted lane, use its required
+hardware or dedicated validation workflow; the manual run below does not
+supply the missing coverage.

No findings from: correctness, security, intent-alignment, style.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=gpt-6.1-sol copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026
The manual run calls e2e.yml, so it cannot cover a hold. Point
composite_action changes (the gnome-e2e action and the extension
validation gate it runs) at gnomeos-canary.yml on a branch at the PR's
head, and no_hosted_lane suites at their own hardware or a hand check.
Also drop "advisory": the hive merges no PR while any check is red.

Addresses the hive reviewer's docs-currency finding on #1142.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 2497b8e into main Nov 12, 2026
14 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1142337de8f` sha256:d53e62ed692218b8bde471b506f2d7409b6ed766500800b9ab8f0ebb73c6b461 — download from the dashboard or `hivectl review evidence #1142`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @Danathar was auto-promoted after 5 clean merged PRs in this hive's repositories.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant