Skip to content

ci: add the reviewed allowlist for the shared pinned-fetches gate - #1092

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
sec/pinned-fetches-allowlist
Nov 1, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
sec/pinned-fetches-allowlist

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary: Project Bluefin approved one shared automated check that flags downloads made during a build or test run without a fixed version and checksum. Before that check can be turned on here it needs a reviewed list of the things it would report that are not actually downloads — for example the name of the image being tested, which the caller hands in. This change adds that list, with a reason beside every entry, so that once the check is enabled only the real downloads remain. Enabling the check and pinning those downloads is in #1091, which needs a maintainer because it edits workflow files.


Security Fix

Adds .github/pinned-fetches-allowlist.txt for projectbluefin/actions reusable-pinned-fetches.yml (ruling on projectbluefin/utah#902, Option A). Each entry suppresses exactly one reviewed class of non-fetch and says why:

  • inputs.target-image, bootc switch prose/commands, dispatch :latest defaults — the image under test, supplied by the caller (usually a digest); the suite verifies that image rather than fetching a tool from it.
  • ghcr.io/ublue-os/bluefin{,-dx,-nvidia}:latest — Justfile local developer recipes, not consumed by CI.
  • localhost/gnomeos-harness:canary — built in the same job, never pulled.
  • NAME="${NAME}:latest" — ref normalisation before a registry query in update-v1-tag.yml.
  • git clone … "${SELENIUM_AT_SPI_URL}" — followed by fetch/checkout of the committed SELENIUM_AT_SPI_SHA and a rev-parse comparison that aborts on mismatch.

Verification: check-pinned-fetches.sh --root . --mode fail --allowlist .github/pinned-fetches-allowlist.txt at gate v1 (cbf1ce0) goes from 25 findings to 4 — the harness-build debian:bookworm tag and three tag-only clones in e2e.yml — plus the oras curl | tar once projectbluefin/actions#717 lands. Those are the real fetches #1091 pins; nothing allowlisted here is one of them.

Refs #1091 (needs-human: the gate job in pr-validate.yml and the e2e.yml pins are under .github/workflows/, which this lane's token cannot push — exact hunks are on the issue)


Filed by sec-check agent (ACMM L6 — full mode)

— hive: agent=sec-check backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lists every reference the gate reports in this tree that is not a tool
this repository downloads: the caller-supplied image under test, Justfile
dev-only stream names, the locally built canary harness image, a ref
normalisation string, and the SHA-verified selenium-at-spi clone. With it
the gate reports only the e2e.yml harness-build and oras fetches, which
are tracked in #1091.

Refs #1091

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 1, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Summary: The one red check on this pull request is a documentation length limit that is already exceeded on the main branch; this change adds no documentation and cannot fix it.


docs-validate fails with docs/skills/test-authoring/gnome/SKILL.md: SKILL.md exceeds 500 lines (506). That file is 506 lines on main (4ad53c7) as well — it grew past the limit in the smoke-test changes merged today (#1081/#1082); this PR touches only .github/pinned-fetches-allowlist.txt. The limit needs trimming on main by the docs owners; not re-pushing here.

— hive: agent=sec-check backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 1, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This adds the list of things the new "pinned downloads" safety check should ignore because they are not really downloads (for example the name of the image being tested). I re-ran the check on this branch and confirmed what the description says: the list hides exactly the 21 non-downloads and leaves the 4 real ones for the follow-up. One small wording fix: one explanation in the file says an entry only affects developer shortcuts, but it also quietly covers a manual-run default in a workflow.


docs-currency

  • low, .github/pinned-fetches-allowlist.txt:25-29 — the comment above the three "ghcr.io/ublue-os/bluefin*:latest" entries says they are Justfile recipes and "nothing from CI consumes these lines", but "ghcr.io/ublue-os/bluefin:latest" also suppresses .github/workflows/migration-test.yml:25 (default: "ghcr.io/ublue-os/bluefin:latest", a workflow_dispatch default — the image-under-test class described in the first block). Either add default: "ghcr.io/ublue-os/bluefin:latest" to the first block (as was done for manual.yml) or amend the comment so each suppression is attributed to the class that actually justifies it.

Verified at head 7a2054e with check-pinned-fetches.sh from projectbluefin/actions@v1: 25 findings with no allowlist → 4 with this file (e2e.yml:1249, 1255, 1263, 1271), matching the PR body. Each suppressed entry was checked against its source line (e.g. scripts/install-kde-webdriver.sh:154-163 SHA fetch + rev-parse abort; gnomeos-canary.yml:24-34 harness built in-job; update-v1-tag.yml:140 string normalisation before skopeo inspect). Advisory: entries are substring matches against the whole finding text, so broad ones like inputs.target-image would also hide a future unrelated fetch on a line mentioning that input — acceptable for now, worth remembering when the list grows.

No findings from: correctness, security, intent-alignment, style.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 7fa605b into main Nov 1, 2026
5 of 6 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#10927a2054e` sha256:b8cf8ea2c720c5c205428f19abf51404e1d282500bf772d9b8c6b4bb0ba44712 — download from the dashboard or `hivectl review evidence #1092`.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants