Skip to content

[sec-check] Turn on the shared download-pinning check and pin the four tools the end-to-end run still fetches by tag #1091

Closed

Description

@hivecommons-hive

Summary: Project Bluefin recently approved one shared automated check that fails a pull request when a build or test pipeline downloads a tool or source code without a fixed version and checksum, instead of each such slip being reported by hand. This test suite is the pipeline every Bluefin image passes through before it is promoted, and it is the one repository the approval named as still having live cases: a publishing tool and three source trees are fetched during the run by name or tag only. This issue applies the approved check here and pins those four downloads. All of the edits live in workflow files, which this agent's credentials cannot push, so a human or a merge-tier agent has to land them; the one file that can be pushed (the reviewed exceptions list) is in a separate pull request.

What I need from you: Approve, then apply the two hunks below (or let an ISSUES_PRS_MERGE agent do it) — the exceptions list arrives by PR.


Security Finding

Severity: low (hardening; applies the accepted ruling on projectbluefin/utah#902)
Type: unsafe-pattern / supply-chain

Decision taken by hive: applying the ruling on projectbluefin/utah#902 (Option A — shared reusable-pinned-fetches.yml gate, warn-only for one cycle with an allowlist, then required). This is the ordinary "adopt the accepted gate" issue for this repository, not a new finding; the oras and harness-build fetches below are the two live instances the ruling itself cites.

Baseline (gate v1 = projectbluefin/actions cbf1ce0, run on main 4ad53c7 today)

25 findings with an empty allowlist; with the allowlist in the companion PR, 4 remain, all real, all in .github/workflows/e2e.yml — plus one the gate currently misses and will report once projectbluefin/actions#717 lands (curl … \ | tar written across continued lines):

Line Shape Fix
1249 podman run … debian:bookworm — build container by floating tag debian:bookworm@sha256:d74df7598108a173a621eda4d58a2adbf850b2d9a9d81bc2cca1a6c21174a880 (today's library/debian:bookworm index digest; Renovate pinDigest keeps it current)
1255 git clone --branch 0.0.11 …/gnome-ponytail-daemon.git — tag only verify HEAD = 72f222d912de8105208f6faa865b71480c189924 (0.0.11^{})
1263 git clone --branch 1.37 …/wayland-protocols.git — tag only verify HEAD = 4878e025a5fb95d8d14a05088974af60cbafebd0 (1.37^{})
1271 git clone --branch v1.5.0 …/emersion/grim.git — tag only verify HEAD = b7a99854e46945db9f50ba8d2417ac42321173d1 (v1.5.0^{})
1674 `curl -sSfL \ "…/oras_1.2.0_linux_amd64.tar.gz" \ tar xz oras, then oras loginwithgithub.token (packages: write`)

The built gnome-ponytail-daemon and grim binaries are scp'd into the VM and sit on the input/screenshot path; oras pushes the screenshot artifact every consumer's dashboard reads. Tag SHAs resolved with git ls-remote <url> refs/tags/<tag>^{} on 2026-11-01.

The other 21 findings are the image under test (caller-supplied bootc switch targets and :latest dispatch defaults), Justfile dev-only stream names, a locally built harness image, a string normalisation, and the already SHA-verified install-kde-webdriver.sh clone — each allowlisted with its reason in the companion PR.

Hunk 1 — .github/workflows/pr-validate.yml: add the gate job (warn for one cycle)

  pinned-fetches:
    name: Pinned fetches
    # Shared supply-chain gate (projectbluefin/utah#902). Warn-only for the
    # baseline cycle; flip to `mode: fail` once the e2e.yml fetches below are
    # pinned — the allowlist already covers every reviewed non-fetch.
    uses: projectbluefin/actions/.github/workflows/reusable-pinned-fetches.yml@cbf1ce09363db6a09bfaae16fde95c7b8c2874bf # v1
    permissions:
      contents: read
    with:
      mode: warn
      allowlist: .github/pinned-fetches-allowlist.txt

Hunk 2 — .github/workflows/e2e.yml: pin the harness build and the oras install

In the podman run harness build (lines 1249-1283):

-          podman run --rm -v /tmp/ponytail-build:/out:Z debian:bookworm bash -c "
+          podman run --rm -v /tmp/ponytail-build:/out:Z debian:bookworm@sha256:d74df7598108a173a621eda4d58a2adbf850b2d9a9d81bc2cca1a6c21174a880 bash -c "
@@
-            git clone --quiet --depth 1 --branch 0.0.11 https://gitlab.gnome.org/ofourdan/gnome-ponytail-daemon.git /src
+            git clone --quiet --depth 1 --branch 0.0.11 https://gitlab.gnome.org/ofourdan/gnome-ponytail-daemon.git /src && test \"\$(git -C /src rev-parse HEAD)\" = 72f222d912de8105208f6faa865b71480c189924
@@
-            git clone --quiet --depth 1 --branch 1.37 \
-              https://gitlab.freedesktop.org/wayland/wayland-protocols.git /wp
+            git clone --quiet --depth 1 --branch 1.37 https://gitlab.freedesktop.org/wayland/wayland-protocols.git /wp && test \"\$(git -C /wp rev-parse HEAD)\" = 4878e025a5fb95d8d14a05088974af60cbafebd0
@@
-              git clone --quiet --depth 1 --branch v1.5.0 \
-                https://gitlab.freedesktop.org/emersion/grim.git /grim && break
+              git clone --quiet --depth 1 --branch v1.5.0 https://gitlab.freedesktop.org/emersion/grim.git /grim \
+                && test \"\$(git -C /grim rev-parse HEAD)\" = b7a99854e46945db9f50ba8d2417ac42321173d1 && break

(set -e is already in effect inside the bash -c string, so a mismatched test aborts the build; the 40-hex on the git clone line is also what the gate's unpinned-clone rule keys on.)

In the "Push desktop screenshot to GHCR" step (lines 1665-1676), add a step before it and drop the download:

+      - name: Install ORAS CLI
+        if: steps.desktop-screenshot.outputs.found == 'true'
+        uses: oras-project/setup-oras@005458ad77f1c8facd38a094e4af2e69e5607ff4 # v2.0.2
+
       - name: Push desktop screenshot to GHCR
         if: steps.desktop-screenshot.outputs.found == 'true'
         id: upload-screenshot
         continue-on-error: true
         run: |
-          # Install oras — push the screenshot as an OCI artifact so any workflow
+          # Push the screenshot as an OCI artifact so any workflow
           # in the org can pull it with: oras pull ghcr.io/projectbluefin/testsuite/desktop-screenshot:latest
-          ORAS_VERSION="1.2.0"
-          curl -sSfL \
-            "https://github.com/oras-project/oras/releases/download/v${ORAS_VERSION}/oras_${ORAS_VERSION}_linux_amd64.tar.gz" \
-            | tar xz oras
-          sudo mv oras /usr/local/bin/oras
-
           echo "${{ github.token }}" | oras login ghcr.io -u "${{ github.actor }}" --password-stdin

After both hunks, check-pinned-fetches.sh --mode fail --allowlist .github/pinned-fetches-allowlist.txt exits 0 on this tree (verified locally with the gate script at v1 and at projectbluefin/actions#717), so mode: fail can be set in the same change.

Impact

Without the gate, the next unpinned download in this repository is found by hand or not at all; with the four fetches as they stand, a tampered forge tag or registry tag puts an unverified binary on the screenshot/input path of every image promotion, and an unverified oras runs with a token that can write packages.

Recommendation

Apply Hunk 1 and Hunk 2 (both under .github/workflows/, so this lane cannot push them: the contributor-tier App token lacks the workflows permission and GitHub rejects the push server-side). Merge the companion allowlist PR first or together.

Risk: security posture — the change gates every pull request on this repository and alters the shared e2e pipeline's tool provenance; a maintainer should land it.

  • companion allowlist PR merged
  • Hunk 1: pinned-fetches job in pr-validate.yml
  • Hunk 2: e2e.yml harness build digest + three tag SHAs verified, oras via setup-oras
  • gate flipped to mode: fail

Filed by sec-check agent (ACMM L6 — full mode)

— hive: agent=sec-check backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    securitySecurity impact or hardening work.
    agent/sec-checkCreated by Hive for agent-filed issue provenance
    stage/045-needs-decisionIssue parked on a person: needs-human or a maintainer decision is owed before the hive picks it up
    on Nov 1, 2026
  2. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    ContributorAuthor

    The reason this issue is parked may be out of date. It has been parked for a maintainer (stage/045-needs-decision) since 2026-11-01, and since then:

    The park reason was written before these changes. Re-read it against the current state before deciding. This note does not un-park the issue: it stays with a maintainer, and Hive updates this note if more of the referenced work moves.

  3. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    ContributorAuthor

    task-list sweep: 0 of 4 items ticked. Not closing yet — outstanding boxes remain.

    Outstanding items:

    • 🔲 companion allowlist PR merged
    • 🔲 Hunk 1: pinned-fetches job in pr-validate.yml
    • 🔲 Hunk 2: e2e.yml harness build digest + three tag SHAs verified, oras via setup-oras
    • 🔲 gate flipped to mode: fail

    Merged PRs referencing this issue so far:

    This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.

  4. Danathar commented on Nov 5, 2026

    @Danathar
    Contributor

    /hive decision Hand this to scanner, whose token can push .github/workflows: open one PR with Hunk 1 and Hunk 2 (the companion allowlist PR #1092 has merged); use the SHA projectbluefin/actions v1 points to at PR time and re-check the debian:bookworm digest.

  5. added and removed
    stage/045-needs-decisionIssue parked on a person: needs-human or a maintainer decision is owed before the hive picks it up
    on Nov 5, 2026
  6. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Approved by @Danathar. Decision: Hand this to scanner, whose token can push .github/workflows: open one PR with Hunk 1 and Hunk 2 (the companion allowlist PR #1092 has merged); use the SHA projectbluefin/actions v1 points to at PR time and re-check the debian:bookworm digest.

    approved-direction is applied and Hive's own stage/045-needs-decision removed. Any hold label is left exactly as it was.

    This issue is still outside the agent queue: project.issue_filter admits only issues labelled triage/accepted. A maintainer adding it admits this one.

  7. added
    triage/acceptedScope accepted; ready for work. Use `/triage accepted`.
    on Nov 5, 2026
  8. added
    has-open-prAn open PR already links this issue with Fixes/Closes/Resolves; the hive will not dispatch it again
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/sec-checkCreated by Hive for agent-filed issue provenanceapproved-directionhas-open-prAn open PR already links this issue with Fixes/Closes/Resolves; the hive will not dispatch it againhive/workflows-laneHive: routed to the lane that can push workflow filessecuritySecurity impact or hardening work.triage/acceptedScope accepted; ready for work. Use `/triage accepted`.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions