Skip to content

feat(gnome-e2e): check the GNOME OS test machine before it starts and record which build was tested - #1035

Merged
Danathar merged 11 commits into
projectbluefin:mainfrom
codebymarshall:feat/gnomeos-guest-preflight
Oct 28, 2026
Merged

Danathar merged 11 commits into
projectbluefin:mainfrom
codebymarshall:feat/gnomeos-guest-preflight

Conversation

@codebymarshall

@codebymarshall codebymarshall commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary: This project tests Linux desktops by booting them in a virtual machine and clicking through them automatically. We want to use it to check GNOME desktop add-ons on GNOME OS, GNOME's own reference system. This change makes the test run look inside the GNOME OS system before starting it, record exactly which build it is testing, and stop early with a clear message if a needed tool is missing. It also replaces the system version that was locked in our notes: that copy had already been deleted from GNOME's download server, which removes every copy after two weeks.


Refs #908: partial. This does not boot GNOME OS or produce a passing run. Still open: a GNOME OS boot with Wayland/input/AT-SPI evidence, which needs an overlay that supplies gnome-ponytail-daemon, plus a lab run.

What changed

  • scripts/guest_preflight.py (new): inspects the mounted ostree deployment and checks every prerequisite the gnome-e2e action relies on: kernel and initramfs, sshd and its unit, sudo, GDM, gnome-shell, gnome-extensions, gdbus, python3 with ensurepip, PyGObject, at-spi-bus-launcher, uinput (module or built-in), and gnome-ponytail-daemon. It writes a JSON report with the image ref, the resolved digest and the os-release identity (ID, IMAGE_VERSION, GNOMEOS_COMMIT). It exits 1 if a prerequisite or os-release is missing. Paths are checked with lexists and never resolved, so absolute guest symlinks are not followed onto the host.
  • .github/actions/gnome-e2e/action.yml: when suite == 'extensions' only, the install step runs the preflight after the deployment is mounted. The digest comes from podman image inspect, and the report goes to results/guest-provenance.json. The step unmounts and detaches the loop device, then fails before boot. Other suites are unchanged.
  • Docs: the expired static pin is removed from gnome-extensions-validation.md. A new reference, gnomeos-guest-provenance.md, holds the 2-week expiry evidence, how to resolve a digest per run, and the verified image inventory. The e2e-workflow SKILL.md describes the new step.

Evidence

  • The pinned digest is dead. GET /v2/gnome_infrastructure/gnome-build-meta/manifests/sha256:57eeef…ed981 returns 404 MANIFEST_UNKNOWN. The image config carries "quay.expires-after": "2w", and the Quay tag API shows each gnomeos-nightly revision with a 14-day end_ts. gnomeos-51 was re-pushed three times between 2026-10-25 and 2026-10-27.
  • Real-layout run. I downloaded all four layers of gnomeos-nightly @ sha256:9dd3a8589376e2acbc5c1feda88e5b2cee91c134d708aeed9d3e94ca788e824c (IMAGE_VERSION=nightly.20261027.1, GNOMEOS_COMMIT=9c38eabcde1ed15f01f4250323ce6a8ab1b8a3da). I rebuilt the file tree as empty files plus symlinks, with the real os-release, and ran the script on it:
    guest:  NAME=GNOME OS ID=org.gnome.os VERSION_ID=Nightly IMAGE_VERSION=nightly.20261027.1 GNOMEOS_COMMIT=9c38eabc…
    GNOME OS: yes
      ok      kernel  (usr/lib/modules/7.3.0/vmlinuz)
      ... (13 more ok)
      MISSING gnome-ponytail-daemon
    ::error::guest image lacks extension-validation prerequisites: gnome-ponytail-daemon. ... Failing closed.
    rc=1
    
  • Checks (local, Python 3.14): ruff check tests/ scripts/ --select E,F,W --ignore E501 passes. pytest -n auto tests/unit/ gives 2233 passed and 1 xfailed; the new test_guest_preflight.py has 27 tests, including one that checks the action wiring. validate_docs.py and generate_skill_index.py --check pass. No .feature files changed.
  • Not run: the action itself, because this host has no KVM or podman. Not yet known: whether bootc install to-disk --bootloader systemd completes on this image, and whether GNOME OS's gnome-initial-setup gets in the way of GDM autologin. Both are listed as open in the new reference.

Security

No new inputs, permissions, secrets or third-party actions. The preflight reads the guest tree as root (sudo python3) and writes only results/. It does not change the credential-isolation posture that the issue thread asks a maintainer to decide.

— hive: backend=claude model=claude-opus-5-5

🤖 Generated with Claude Code

Refs #908


🐝 Hive Agent: contributor | SHA: 8829d910

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head sentinel-alert labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
8829d91

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @codebymarshall, head 8829d9106b55) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/actions/gnome-e2e/action.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/actions/gnome-e2e/action.yml

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

⚠️ Hold-gate mergeability: Hive could not update this branch

This PR is hold-gated and has fallen behind its base branch. Hive keeps held PRs up to date while they wait on review, but it could not update this one. The branch is in a fork the Hive app cannot push to ("Allow edits by maintainers" is off, or GitHub refused the push).

Hive will not try again until this branch or its base branch changes. To bring it up to date now, ask the author to merge the base branch in, or use Update branch on this PR if GitHub offers it.

@codebymarshall

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged current main tip d07116a (fix(e2e): clone grim from gitlab.freedesktop.org, #1034) into this branch; no conflicts.


🐝 Hive Agent: contributor | SHA: f8cca99f

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds a pre-boot check for the GNOME OS test machine and records which build was tested. The code and docs hold up; the one real problem is that the pull request is written as partial work but also tells GitHub to close the tracking issue when it merges, which would mark unfinished work as done. A documentation example also points at a workflow job that does not exist yet.

What I need from you: Remove the closing line from the PR description (and optionally fix the doc example).


intent-alignment

  • medium — PR body closes #908 while declaring itself partial. The body opens with "Refs #908: partial. This does not boot GNOME OS or produce a passing run" and later ends with Closes #908. On merge GitHub will close #908, whose body says "Do not close this issue on YAML validation alone" and whose acceptance boxes (real Wayland boot, qecore/Behave evidence) are all still unchecked; docs/skills/ci-ops/e2e-workflow/references/gnome-extensions-validation.md:195-199 in this very PR still lists them as [ ]. Fix: replace Closes #908 in the PR description with Refs #908 (or delete the line). Earlier partial PRs for this issue (#991, #1031) were linked without a closing keyword for exactly this reason.
  • info: the issue's plan step 1 says "pin an official GNOME OS image digest"; this PR replaces the static pin with resolve-per-run + a recorded results/guest-provenance.json. I verified the justification — the old pin sha256:57eeef…ed981 returns HTTP 404 from Quay today — so this reads as the right reinterpretation, not scope drift.

docs-currency

  • low — docs/skills/ci-ops/e2e-workflow/references/gnome-extensions-validation.md:82 shows image: quay.io/gnome_infrastructure/gnome-build-meta@${{ needs.resolve.outputs.digest }}, but no resolve job is defined or sketched anywhere in the repo or in the new gnomeos-guest-provenance.md (which gives only the shell commands at lines 32-39). A reader copying the snippet gets a workflow that fails to start. Suggested addition right above the snippet:
    Resolve the digest in a preceding job and pass it through an output, e.g.:
    
    ```yaml
    resolve:
      runs-on: ubuntu-latest
      outputs:
        digest: ${{ steps.d.outputs.digest }}
      steps:
        - id: d
          run: echo "digest=$(skopeo inspect docker://quay.io/gnome_infrastructure/gnome-build-meta:gnomeos-nightly | jq -r .Digest)" >> "$GITHUB_OUTPUT"
    
    
    

Verified at head f8cca99: pytest tests/unit/test_guest_preflight.py 27 passed; validate_docs.py and generate_skill_index.py --check pass; scripts/guest_preflight.py compiles. Preflight is guarded by set -e-safe || PREFLIGHT_RC=$? and the loop device/mount are released before the step exits 1 (action.yml:259-266).

No findings from: correctness, security, style.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 98.10427% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
scripts/guest_preflight.py 96.87% 3 Missing ⚠️
tests/unit/test_guest_preflight.py 99.13% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you. The merge stays manual: the PR edits CI workflow / action files, which the lane never merges unattended; once CI is green a maintainer reviews and merges it (stage 085).

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head 96c04a39b642 has not moved for 1m and the hive has nothing it can push: adoption-stalled:hive-signoff-attribution.

Blocker: 1 commit(s) on 96c04a39b642 carry the App's Signed-off-by while a squash merge would land them as @codebymarshall, so the hive will not squash-merge this head. The hive cannot rewrite that authorship without the contributor, and a superseding PR would carry the same head, so it opened none. The hive selects a merge commit for this shape by itself only on a role/trusted PR or a head a trusted maintainer has approved; this one is neither yet. Ask (maintainer): every commit already carries a sign-off matching its own author, so DCO holds without rewriting history: approve the current head with a GitHub Approve review (the hive then selects the merge commit itself), or merge it by hand with a merge commit (gh pr merge 1035 --merge, not squash).

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 27, 2026
codebymarshall and others added 2 commits October 27, 2026 22:55
…ance before boot

For suite: extensions the install step now runs scripts/guest_preflight.py
over the mounted ostree deployment before the VM boots. It writes
results/guest-provenance.json (image ref, podman-resolved digest, guest
os-release incl. IMAGE_VERSION/GNOMEOS_COMMIT) and fails closed, as a
provisioning error, when a lane prerequisite is missing. Run against the
layer tree of gnomeos-nightly nightly.20261027.1 it passes every check
except gnome-ponytail-daemon, which stock GNOME OS does not ship.

The lane doc's static digest pin is gone: gnomeos-* tags carry
quay.expires-after: 2w and the 2026-09-30 pin now returns
MANIFEST_UNKNOWN. Provenance is resolved per run instead; the verified
image inventory moves to a new gnomeos-guest-provenance reference.

Refs projectbluefin#908

Hive-Run: projectbluefin#908
Hive-Plan: issue projectbluefin#908 implementation plan, steps 1 and 4 (inventory, provenance, fail-closed infra errors)
Hive-Spec: projectbluefin#908#acceptance-provenance-and-fail-closed
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
…xample

The extensions-lane example referenced needs.resolve.outputs.digest without
defining a resolve job. Sketch one in gnomeos-guest-provenance.md (resolving
gnomeos-nightly with skopeo) and point at it from the example's comment,
keeping gnome-extensions-validation.md within the 200-line reference limit
enforced by validate_docs.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
@codebymarshall
codebymarshall force-pushed the feat/gnomeos-guest-preflight branch from 96c04a3 to 9ed29a7 Compare October 27, 2026 22:56
@codebymarshall

Copy link
Copy Markdown
Contributor Author

Addressed the review swarm and the adoption blocker. New head: 9ed29a7a.

  • intent-alignment: the PR body links Refs #908 only. There is no closing keyword, and closingIssuesReferences is empty.
  • docs-currency: the resolve job sketch now lives in gnomeos-guest-provenance.md#resolving-the-digest-in-a-workflow, and the extensions-lane example's comment points to it. The hive's earlier version put the sketch inline, which made gnome-extensions-validation.md 218 lines. That fails validate_docs.py, which caps reference files at 200 lines. The file is now exactly 200 lines and the check passes.
  • sign-off attribution: I rebased onto main (d07116aa) as two linear commits. I authored both and signed both off. The bot-signed commit and the merge commit are gone.

Local results: test_guest_preflight.py 27 passed. validate_docs.py and generate_skill_index.py --check pass.


🐝 Hive Agent: contributor | SHA: 9ed29a7a


🐝 Hive Agent: contributor | SHA: 9ed29a7a

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you (stage/074-adopted-by-hive → stage/072-returned-to-contributor). It will nudge again if CI stays red.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds a pre-boot check for the GNOME OS test machine and drops a hard-coded build identifier that GNOME's download server has already deleted. One copy of that dead identifier is still in the notes, and still tells readers to use it, which contradicts the new "look it up fresh each run" rule this change introduces. A small follow-up edit fixes it.

What I need from you: Remove the stale pin from the second document (patch below).


docs-currency

  • Expired digest pin still documented as the lane contract — docs/skills/ci-ops/ops/references/fedora-version-targets.md:20 ("gnomeos-nightly (pinned digest)") and :52-57 ("Pinned digest (do not float): … @sha256:57eeef917d…ed981") still instruct readers to pass the exact digest this PR proves returns MANIFEST_UNKNOWN (gnomeos-guest-provenance.md:19-21). The PR body says "the expired static pin is removed", but only gnome-extensions-validation.md was updated. Suggested patch:
--- a/docs/skills/ci-ops/ops/references/fedora-version-targets.md
+++ b/docs/skills/ci-ops/ops/references/fedora-version-targets.md
@@ -20 +20 @@
-| **OS under test (extension-validation lane)** | `gnomeos-nightly` (pinned digest) | reproducible GNOME OS build for the developer extension validation lane (#908) |
+| **OS under test (extension-validation lane)** | `gnomeos-nightly` (digest resolved per run; tags expire after 2 weeks) | GNOME OS build for the developer extension validation lane (#908); provenance recorded in `results/guest-provenance.json` |
@@ -52,57 +52,55 @@
-**Pinned digest (do not float):** the lane passes this digest reference — not the
-`gnomeos-nightly` tag — to the `gnome-e2e` action's `image` input.
-
-```
-quay.io/gnome_infrastructure/gnome-build-meta@sha256:57eeef917d057e37d8d5824fab195ebf3b0ad49fc1ca191b7bc02b82418ed981
-```
+**Resolve the digest at dispatch time:** `gnomeos-*` digests expire two weeks after push, so
+no static pin is kept here. The lane resolves `gnomeos-nightly` to a digest per run and passes
+that `@sha256:…` reference — not the tag — to the `gnome-e2e` action's `image` input; see
+[gnomeos-guest-provenance.md](../../e2e-workflow/references/gnomeos-guest-provenance.md).

correctness

  • (low, advisory) "never resolved" is only true for the literal-path checks — scripts/guest_preflight.py:88-90 uses os.path.lexists for plain patterns, but wildcard patterns go through root.glob() (:91-95), and Path.glob follows symlinked directories while walking * components (e.g. usr/lib64/python3*/…, usr/lib/modules/*/…). A guest tree whose usr/lib64 is an absolute symlink would be probed on the host. On a real ostree deployment usr/lib is a plain dir and no host path matches these shapes, so this is a doc-accuracy nit (guest_preflight.py:18-19, gnomeos-guest-provenance.md:79-80) rather than a defect. Optional tightening: skip hits whose relative parents include a symlink.

No findings from: security, intent-alignment, style.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added the stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (4 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on main here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you. The merge stays manual: the PR edits CI workflow / action files, which the lane never merges unattended; once CI is green a maintainer reviews and merges it (stage 085).

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026
Fedora-based guests ship the stdlib under usr/lib64, so the preflight now
accepts ensurepip there too, mirroring python-gi. The status list now
separates per-run recording (done) from the digest resolve job (not yet).

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head 45b3b04cbc9e has not moved for 1m and the hive has nothing it can push: adoption-stalled:hive-signoff-attribution.

Blocker: 1 commit(s) on 45b3b04cbc9e carry the App's Signed-off-by while a squash merge would land them as @codebymarshall, so the hive will not squash-merge this head. The hive cannot rewrite that authorship without the contributor, and a superseding PR would carry the same head, so it opened none. The hive selects a merge commit for this shape by itself only on a role/trusted PR or a head a trusted maintainer has approved; this one is neither yet. Ask (maintainer): every commit already carries a sign-off matching its own author, so DCO holds without rewriting history: approve the current head with a GitHub Approve review (the hive then selects the merge commit itself), or merge it by hand with a merge commit (gh pr merge 1035 --merge, not squash).

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds a pre-boot check that inspects the GNOME OS test system and records which build was tested. The code and its tests are sound, but the documentation lint that runs in CI now fails on one of the edited reference pages, which the PR text says was passing. A two-line trim fixes it; one stale line reference in the same page should move too.

What I need from you: Trim the reference page by two lines and update the line reference, then re-run scripts/validate_docs.py.


docs-currency

  • medium — docs/skills/ci-ops/e2e-workflow/references/gnome-extensions-validation.md is now 202 lines; scripts/validate_docs.py:205-206 errors on any reference over 200 and .github/workflows/docs-validate.yml:30 runs that check. Base was exactly 200 lines, this PR adds a net +2. Reproduced at head 45b3b04: FAIL: ...gnome-extensions-validation.md: reference exceeds 200 lines (202). The PR body's "validate_docs.py … pass" claim does not hold at this head. Fix (lines 187-190, saves 2 lines):
    - [x] Provenance contract: tested build recorded per run in `results/guest-provenance.json`
    - [ ] Provenance contract: per-run digest resolve job (sketched in `gnomeos-guest-provenance.md`; none exists yet)
    
  • low — same file, line 73: the action.yml:384 citation for the in-guest qecore-headless run was left as-is while the sibling action.yml:38-40 → 40-42 citation was shifted for the +21 lines this PR adds. The qecore-headless invocation is now at action.yml:410.

correctness

  • info — action.yml:195: podman image inspect --format '{{.Digest}}' returns the digest of the platform manifest podman pulled; when gnomeos-nightly is published as a manifest list that differs from the list digest skopeo inspect … | jq .Digest returns (the resolve recipe in fedora-version-targets.md:59-60 and the new reference). image_ref is also recorded, so the run is still identifiable; consider noting in gnomeos-guest-provenance.md which digest image_digest is. No code change required.

No findings from: security, intent-alignment, style.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head b5ed2aec9902 has not moved for 1m and the hive has nothing it can push: adoption-stalled:hive-signoff-attribution.

Blocker: 1 commit(s) on b5ed2aec9902 carry the App's Signed-off-by while a squash merge would land them as @codebymarshall, so the hive will not squash-merge this head. The hive cannot rewrite that authorship without the contributor, and a superseding PR would carry the same head, so it opened none. The hive selects a merge commit for this shape by itself only on a role/trusted PR or a head a trusted maintainer has approved; this one is neither yet. Ask (maintainer): every commit already carries a sign-off matching its own author, so DCO holds without rewriting history: approve the current head with a GitHub Approve review (the hive then selects the merge commit itself), or merge it by hand with a merge commit (gh pr merge 1035 --merge, not squash).

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds a pre-boot check for the GNOME OS test machine and records which build was tested. The code and its tests are sound, but one of the project's own documentation checks fails on this branch: a reference page grew two lines past the size limit the repository enforces, so the docs check in CI will go red. A two-line trim fixes it.

What I need from you: Trim two lines from the oversized reference page (suggestion below).


docs-currency

  • validate_docs.py fails on this head: reference exceeds 200 lines. docs/skills/ci-ops/e2e-workflow/references/gnome-extensions-validation.md is exactly 200 lines at merge-base f1743d5 and 202 at b5ed2ae (+31/−29). scripts/validate_docs.py:205-206 errors on > 200, and .github/workflows/docs-validate.yml:30 runs it, so CI will fail. Reproduced locally at b5ed2ae: FAIL: .../gnome-extensions-validation.md: reference exceeds 200 lines (202), exit 1 — the PR body's "validate_docs.py … pass" claim does not hold for this head. Fix (lines 196–199, collapses the two Provenance bullets to one line each → 200 lines):

    - [x] Provenance contract: tested build recorded per run in `results/guest-provenance.json`
    - [ ] Provenance contract: per-run digest resolve job (sketched in `gnomeos-guest-provenance.md`)
    

No findings from: correctness, security, intent-alignment, style.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

Danathar and others added 3 commits October 28, 2026 07:14
…ines

docs-validate failed on gnome-extensions-validation.md at 202 lines (the
reference cap is 200). Rewrap the new provenance paragraph and the
credentials bullet at 100 columns; the words are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SnzFs53Qcer1xDySyxv1Vj
Signed-off-by: Danathar <berths-purger-0g@icloud.com>
Resolve docs/skills/ci-ops/e2e-workflow/SKILL.md: projectbluefin#1040 and this PR
each appended a reference link at the end of the list; keep both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SnzFs53Qcer1xDySyxv1Vj
Signed-off-by: Danathar <berths-purger-0g@icloud.com>
Merging main brought projectbluefin#1040's reference link next to this PR's, taking SKILL.md to 501 lines (cap 500). Join one two-line sentence; same words.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SnzFs53Qcer1xDySyxv1Vj
Signed-off-by: Danathar <berths-purger-0g@icloud.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you (stage/074-adopted-by-hive → stage/072-returned-to-contributor). It will nudge again if CI stays red.

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • 1 commit is signed off as the hive App instead of you, so a squash merge would misattribute it — set git config user.email to your own address, then run git rebase --exec 'git commit --amend --no-edit --reset-author -s' HEAD~6 && git push --force-with-lease

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (4 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Held at stage/085-needs-decision for a maintainer. 1 of 6 commits on 4f768f8b54b5 are the hive's own, signed off as the hive App, so a squash merge would land them as @codebymarshall with the App's sign-off, and the hive will not squash-merge this head. @codebymarshall did not make those commits and has nothing to fix here.

The hive selects a merge commit for this shape by itself only on a role/trusted PR or a head a trusted maintainer has approved; this one is neither yet. Ask (maintainer): every commit already carries a sign-off matching its own author, so DCO holds without rewriting history: approve the current head with a GitHub Approve review (the hive then selects the merge commit itself), or merge it by hand with a merge commit (gh pr merge 1035 --merge, not squash).

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds a pre-boot check for the GNOME OS test machine and records which build was tested. The code and the test wiring look right; the only thing to fix is that the guide for this lane still points readers at the wrong lines in the action file after this change moved them.

What I need from you: Update the three stale line references (fix below).


docs-currency

  • low — docs/skills/ci-ops/e2e-workflow/references/gnome-extensions-validation.md:72,116,175,177 cite action.yml:384, action.yml:215 and action.yml:224-226. The PR corrected the neighbouring 38-40 → 40-42 citation (line 73) and rewrapped the paragraph at 175-177, but left these as-is; after the 21 lines this PR adds to the install step they point at unrelated code. At head 4f768f8: qecore-headless run is action.yml:410, authorized_keys write is action.yml:237, NOPASSWD sudoers block is action.yml:246-248.

    -`tests/<suite>/features/` inside it under `qecore-headless` (`action.yml:384`). `suite` must
    +`tests/<suite>/features/` inside it under `qecore-headless` (`action.yml:410`). `suite` must
    ...
    -Mirrors `action.yml:384`:
    +Mirrors `action.yml:410`:
    ...
    -  `bluefin-test` home, `action.yml:215`) and the `bluefin-test` autologin let the harness drive the
    +  `bluefin-test` home, `action.yml:237`) and the `bluefin-test` autologin let the harness drive the
    -  sudo (`action.yml:224-226`), so extension code **can** read that key and escalate **inside the
    +  sudo (`action.yml:246-248`), so extension code **can** read that key and escalate **inside the

No findings from: correctness, security, intent-alignment, style.

Confidence: 3/5 (needs attention) — 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Held at stage/085-needs-decision for a maintainer. 1 of 6 commits on 3f8067ab8369 are the hive's own, signed off as the hive App, so a squash merge would land them as @codebymarshall with the App's sign-off, and the hive will not squash-merge this head. @codebymarshall did not make those commits and has nothing to fix here.

The hive selects a merge commit for this shape by itself only on a role/trusted PR or a head a trusted maintainer has approved; this one is neither yet. Ask (maintainer): every commit already carries a sign-off matching its own author, so DCO holds without rewriting history: approve the current head with a GitHub Approve review (the hive then selects the merge commit itself), or merge it by hand with a merge commit (gh pr merge 1035 --merge, not squash).

@Danathar

Copy link
Copy Markdown
Contributor

Sentinel reviewed and released at 3f8067a. The flagged change is the gnome-e2e action: the suite input reaches run: through env (GNOME_E2E_SUITE), not inline ${{ }}; no new actions, permissions or secrets; the new preflight step fails closed (exit 1) and only affects suite: extensions. Doc length fixes and the main merge keep both #1040's and this PR's reference links. 6/6 checks green.

@Danathar
Danathar merged commit ecab5e7 into projectbluefin:main Oct 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants