Skip to content

fix: stop false build safety failures - #626

Merged
castrojo merged 1 commit into
projectbluefin:mainfrom
Karibhou:fix/action-version-labels
Nov 15, 2026
Merged

castrojo merged 1 commit into
projectbluefin:mainfrom
Karibhou:fix/action-version-labels

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary: The project's automatic build safety check can fail when a tool publishes a new release, even though the project has not changed tools. This change labels the existing tool versions precisely so those unrelated releases no longer hold up changes.


Changes

  • Replace moving major-version comments with the exact release tags corresponding to the existing action SHA pins; the pins themselves are unchanged.
  • Document the exact-tag convention for future action pins.

Verification

  • Confirmed all four release tags resolve to the existing SHAs using the GitHub API.
  • Online zizmor .github/workflows: no findings (2 ignored, 36 suppressed).
  • Parsed all nine workflows with PyYAML.
  • python3 .github/scripts/docs-checks.py: passed, with existing long-skill warnings.
  • just validate: version checks passed; the BuildStream graph check could not run because this environment lacks the container runtime and sudo.

Fixes #622

— hive: backend=omp model=openai-codex/gpt-6.1-terra


🐝 Hive Agent: contributor | SHA: 945db73

@jeefy
jeefy requested review from ahmedadan and castrojo November 5, 2026 22:32
@jeefy

jeefy commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

hivecommons-hive Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
7cd0426

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @Karibhou, head 7cd04269a73f) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 5 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/build.yml
    • .github/workflows/docs-checks.yml
    • .github/workflows/track-binaries.yml
    • .github/workflows/track-junctions.yml
    • .github/workflows/unit-tests.yml

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @Danathar this rewrites only the version comments on existing SHA pins across .github/workflows (per #622) — please confirm the exact tags and lgtm.

Read the full diff. Every hunk changes a trailing # vN comment to an exact release tag (# v2.90.1, # v8.0.2, # v7.1.0, # v3.3.0) on an unchanged commit SHA; no uses: SHA, permission, or step logic changes. Plus a convention note. This is what #622 recommends to stop zizmor's online ref-version-mismatch audit failing each time taiki-e/install-action cuts a release.

Routing to a human because it edits workflow files (sentinel-alert).

Open question, not a defect: I did not independently resolve the four tags to their SHAs; they match the mapping listed in #622's evidence. Because this is a fork PR, only prow ran in the check rollup — the Lint workflows / zizmor job has not executed on this head yet, so the approver should confirm it goes green after authorizing CI.

Confidence: 3/5 (needs attention) — 5 perspectives requires a human decision

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@Karibhou

Karibhou commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review. The PR verification records that all four tags were resolved to the existing SHAs through the GitHub API and online zizmor passed locally. The workflow-path approval and authorized CI run remain with the maintainer; no SHA or workflow logic was changed.


🐝 Hive Agent: contributor | SHA: unknown

@castrojo
castrojo force-pushed the fix/action-version-labels branch from 945db73 to eaf066b Compare November 8, 2026 22:33
@jeefy

jeefy commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@castrojo

castrojo commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Rebased onto fresh main and resolved all install-action conflicts without downgrading any action SHA: all seven copies retain main commit 3a3daafd3b7f23b8f65d9f5ba2db203fb59b79e2 and now use exact v2.90.2 annotations. Verified all four release-tag mappings through GitHub API. Full just test-unit: 1932 passed, 30 existing root/lab skips, 158 BATS passed, coverage 84.78%; lint-python, validate, docs checks, and actionlint passed. Zizmor 1.32.0 passed locally in offline mode; CI supplies its read-only token for the online audit. @Danathar please review this pushed head and the named workflow decision; this removes the common required-CI blocker for #613, #634, and #637.

Danathar
Danathar previously approved these changes Nov 9, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head eaf066b: only the trailing version comments on existing SHA pins change (install-action v2.90.2, download-artifact v8.0.2, setup-python v7.1.0, create-github-app-token v3.3.0 — each matches its pinned SHA); no SHA, permission, trigger or run: changes. Heads-up: it touches the same install-action lines as #639, so whichever merges second needs a rebase.

/lgtm
/approve

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head eaf066b74de9, which edits CI workflow / action files. That explicit owner approval releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. A new push re-arms the fence until the new head is approved again; the hive's own merge of the base branch, which leaves the diff unchanged, does not.

hivecommons-hive Bot pushed a commit to hivecommons/hive that referenced this pull request Nov 10, 2026
…rges it instead of waiting for a stage pass that never comes (#17550)

* 🐛 fix(dashboard): a new PR on an auto-merge-off repo says a person merges it

Every merge lane skips a repo whose auto-merge is off (its per-repo
switch, or any repo of a hive below ACMM L6) before it records stage
evidence, so no stage-label pass ever places a PR there. The Activity
Monitor still read "New · waiting for the stage-label pass (→ 050 review
pending) (next pass due now)" on such PRs for days
(projectbluefin/server#626).

The 000-new narration on those repos now drops the countdown and the
stage-label pass, ends at a human-merge gate ("auto-merge is off for this
repo ... — a person merges it") and quotes the merge verdict. When the
verdict is a hand merge, the maintainer is the next mover and the row
leads with Merge now as maintainer; otherwise the hive stays the next
mover for CI and review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

* 🐛 test(dashboard): match the existing greyed queue-merge reason case-insensitively

The greyed 'Approve and let hive merge' option reuses the 090 auto-merge-off
reason, which starts with a capital A.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

---------

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @eaf066b, approved by @Danathar, 20/20 checks green, soak 30m0s elapsed. Blocked only by role/trusted.

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@Danathar

Copy link
Copy Markdown
Contributor

/lgtm

@Danathar

Copy link
Copy Markdown
Contributor

/approve

@jeefy jeefy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2026
@jeefy

jeefy commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeefy jeefy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2026
@Danathar
Danathar added this pull request to the merge queue Nov 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 13, 2026
Danathar added a commit that referenced this pull request Nov 13, 2026
taiki-e/install-action moved its v2 tag to a newer commit, so zizmor's
ref-version-mismatch audit now flags the "# v2" comment on our
unchanged 3a3daaf pin and fails the required zizmor check. Label the
pin with v2.90.2, the release tag that points at that commit. The pin
itself is unchanged. These lines match #626, which applies the same
convention to every action pin.

Refs #622
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Danathar added a commit that referenced this pull request Nov 13, 2026
taiki-e/install-action moved its v2 tag to a newer commit, so zizmor's
ref-version-mismatch audit now flags the "# v2" comment on our
unchanged 3a3daaf pin and fails the required zizmor check. Label the
pin with v2.90.2, the release tag that points at that commit. The pin
itself is unchanged. These lines match #626, which applies the same
convention to every action pin.

Refs #622

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task; your current task is parked (claim kept alive) until this PR is green.

Use exact release tags in action pin comments so upstream major tag moves do not break the online audit.

Assisted-by: openai-codex/gpt-6.1-terra via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hive-Run: projectbluefin#622
Hive-Plan: issue-622-option-A
Hive-Spec: issue-622#recommendation
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Assisted-by: gpt-6.1-sol via GitHub Copilot
@jeefy

jeefy commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeefy jeefy removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2026
@castrojo
castrojo enabled auto-merge November 15, 2026 18:30
@castrojo
castrojo added this pull request to the merge queue Nov 15, 2026
Merged via the queue into projectbluefin:main with commit f0ea4b5 Nov 15, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. sentinel-alert

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci-maintainer] Build-automation safety check fails whenever an upstream tool publishes a new release

4 participants