Repository navigation
ci(track-binaries): refresh amd64 and arm64 pins together, with tests - #288
Merged
Merged
Conversation
projectbluefin#279 added arm64 sources under `arch == "aarch64"` in k0s-bin.bst and kubeadm-bin.bst after projectbluefin#272's tracker landed. The tracker already treats every `url:` line carrying a component's marker as a pin, so it rewrites the arm64 refs too, but nothing held it to that. Behavioural tests (mocked HTTP) now do: a runc and a k0s bump rewrite both architectures' refs; a release missing the arm64 asset is not a candidate; a missing arm64 asset or checksum fails the component and writes nothing; a no-op run leaves the files byte-identical; the real elements pin arm64 for every amd64 source. The docstring and the tracker docs say so. Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #272 (binary tracker) and #279 (arm64 pins under
arch == "aarch64"ink0s-bin.bst/kubeadm-bin.bst).Finding: the tracker already refreshes the arm64 refs.
BstComponent.pins()treats everyurl:line carrying the component's marker as a pin, including those under(?):, and_candidates()requires every pin's asset and checksum file. Nothing tested it, though, and the docstring and docs only described amd64. This PR pins that behaviour down. There is no logic change.Changes
tests/unit/test_track_binaries.py: behavioural tests (mockedurlopen, no network) on a fixture with the real(?): arch == "aarch64"layout:runc.arm64is not a candidatetrack-binaries.py,ci-tooling.mdandkubeadm-sysext.mdnow say all pinned architectures move together. ORAS stays amd64-only because it is CI tooling.Evidence
files/boot-keys. bats: 74/74.docs-checks.pypasses. Workflow unchanged, so no actionlint run.check: kubernetes 1.34.3→1.34.12, containerd 2.1.5→2.1.9, runc 1.3.3→1.3.6, k0s 1.36.4+k0s.0→+k0s.1 pending; cri-tools, cni-plugins, oras current.apply runcin a scratch copy, which was then discarded (no version bump committed). It wrote amd643f3921db…023cand arm646be27a06…b747. Both matchsha256sumof the downloadedrunc.amd64/runc.arm64and upstream'srunc.sha256sum.