Skip to content

ci(build): queue main runs instead of cancelling them; upload installer logs - #292

Merged
jeefy merged 1 commit into
projectbluefin:mainfrom
jeefy:ci/main-concurrency-and-installer-logs
Sep 29, 2026
Merged

jeefy merged 1 commit into
projectbluefin:mainfrom
jeefy:ci/main-concurrency-and-installer-logs

Conversation

@jeefy

@jeefy jeefy commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Two CI fixes found while merging the punch-list follow-ups.

  • Main runs were cancelled by later merges. concurrency.cancel-in-progress: true applies to push to main too, so merging docs: follow-ups deferred from #276 #289 cancelled the build/release run for 6d49f9b and that version never shipped. cancel-in-progress is now ${{ github.event_name == 'pull_request' }}: PRs still cancel superseded runs, while main runs queue in the same group and each one releases.
  • Installer boot-test logs weren't uploaded. Upload boot logs collected dist/*/dogfood-*.log and dist/dogfood-install/*.log but not dist/dogfood-installer/, where the ci: boot-test the offline USB installer end to end #277 offline installer test writes its serial and QEMU logs. ci(track-binaries): refresh amd64 and arm64 pins together, with tests #288 hit a 1-enroll: no result within 600s failure there with no logs to inspect. The same test passes locally on current main (cc139eb), so it looks like a runner flake, but the next occurrence should be debuggable.

Tests: two new assertions in tests/unit/test_release_workflow.py. Both fail if the change is reverted. pytest (569 passed, also in a clean tree without files/boot-keys), bats 74/74, docs-checks and actionlint all pass.

…er logs

A push to main cancelled the in-progress run for the previous merge
(projectbluefin#289 cancelled 6d49f9b's run), so that version never released. Only
pull requests now cancel superseded runs; main runs queue in the same
group.

The boot-test log upload also missed dist/dogfood-installer/, so the
offline installer test's serial logs were lost on failure.

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jeefy
jeefy merged commit d1b958c into projectbluefin:main Sep 29, 2026
6 checks passed
@jeefy

jeefy commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Correction to the description: GitHub keeps at most one running and one pending run per concurrency group, and a newer pending run always replaces the older pending one, regardless of cancel-in-progress. So with this change a main run that has started is no longer cancelled (778b4a0's release kept running when #292 and #288 merged behind it). But merges that pile up while a run is in progress collapse into one run for the newest commit (d1b958c's pending run was superseded by 212cd97). Every started release now finishes; not every commit gets its own version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant