Repository navigation
fix(installer): cap root-a SizeMaxBytes to 8G to guarantee /var space - #165
mrbobbytables wants to merge 1 commit into
Conversation
files/installer/repart.d/20-root-a.conf set SizeMaxBytes=16G with GrowFileSystem=yes, causing systemd-repart to expand root-a on 16G target disks and starve the /var partition (which requires SizeMinBytes=4G). This prevented /dev/disk/by-partlabel/var from appearing during boot in QEMU tests. Cap root-a SizeMaxBytes at 8G so that on a 16G target disk, after ESP (1G) and root-a (8G), at least 7G remains for /var, guaranteeing /var's 4G minimum footprint. Update test_repart_layout.py and ddi-installer documentation accordingly. Fixes projectbluefin#161 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
Closing because the premise this change rests on is falsified by evidence that only became available after it was opened. Reopen if you have counter-evidence — I would rather be corrected than have this stay shut wrongly. The PR caps The emergency-mode symptom is real and is currently breaking This PR's own CI agrees: its installer-test log still shows "Dependency failed for /var" with the 8G cap applied, so the change does not fix the failure it was written to fix. Two further reasons not to land it as-is:
Halving the A-slot ceiling is also not cost-free — it directly halves the headroom for the A/B image payload — so it is not a change worth keeping on the theory that it might help. The |
Summary
Fixes #161
In
files/installer/repart.d/20-root-a.conf,SizeMaxByteswas set to16GalongsideGrowFileSystem=yes. On standard 16G target disks (such as inJustfileand CI QEMU installer tests),systemd-repartwould expandroot-ato fill remaining free space, leaving insufficient space to satisfy theSizeMinBytes=4Grequirement for the/varpartition defined in30-var.conf. As a result, the/varpartition was not created or timed out waiting for/dev/disk/by-partlabel/varduring boot.This change:
root-aSizeMaxBytesat8Ginfiles/installer/repart.d/20-root-a.conf.docs/skills/ddi-installer.mdto reflect the 4 GiB – 8 GiB root layout.tests/unit/test_repart_layout.pyto assert thatroot-a'sSizeMaxBytesis capped at 8G or less to preserve space for/varon 16G target disks.Verification
pytest tests/unit: 207 passed, 1 xfailedbats tests/unit: 62 passedpython3 .github/scripts/docs-checks.py: passedpython3 .github/scripts/check-release-version.py: passedpython3 .github/scripts/check-k0s-version.py: passed— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:d8fa8d7