Repository navigation
Conversation
The installer-test 'Install and boot in QEMU' gate fails on main: the second boot drops to emergency mode waiting for /dev/disk/by-partlabel/var. Both 'GrowFileSystem=yes' partitions (root-a and var) split the leftover disk space by default weight, but 20-root-a.conf allowed root-a to grow up to SizeMaxBytes=16G (the full 16G test disk). Depending on the DDI payload's footprint, root-a's elastic growth could consume the space /var needs, so var is never created (or is undersized) and the var.mount unit times out. Bound root-a's SizeMaxBytes to a realistic OS-payload size (8G) instead of the full test-disk size, and give /var an explicit high Weight= so it always retains a dominant share of the leftover space and its SizeMinBytes=4G regardless of how far root-a grows. /var remains the tail partition that grows to fill the disk. Assisted-by: DeepSeek via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
Closing. Both halves of this change turn out to be unsupported — the first by direct runtime evidence, the second by measurement. I want to lay out the evidence properly because the diagnosis here was a reasonable inference from what was visible, and the thing that refutes it only became available from #173's runs. Half one: the The stated cause is that root-a's elastic growth consumes the space PR #173 refutes that directly. Its entire diff is two files — and its comment explains the real mechanism: leaving Flatcar's drop-in in place makes With that one drop-in removed and sizing unchanged, the system boots. I confirmed it on a throwaway integration of #173 + #181 (run 35375246792): zero There is also a logical tell worth keeping: an undersized partition still mounts. Sizing can never explain a mount timeout. Only a missing or unreadable device can, and that is what the udev deadlock produced. For the same reasons I closed #165, which proposed this identical 8G cap. Half two: Your syntax is correct. But measured against the real configs with The reason I was rejecting the 8G cap is that halving the A-slot ceiling halves the headroom available to the A/B image payload. The determinism argument does not survive either: root-a already carries I considered keeping With both halves removed the PR is empty, which is why this is a close rather than a reduction. One correction for the record: None of this was obvious from |
Fixes #161.
The
installer-test / Install and boot in QEMUgate fails onmainitself: the second boot drops into emergency mode waiting for/dev/disk/by-partlabel/var.Root cause
Both
root-aandvarareGrowFileSystem=yespartitions, sosystemd-repartsplits the leftover disk space between them by default weight. But20-root-a.confsetSizeMaxBytes=16G— the full 16G test/VM disk. Combined withGrowFileSystem=yes, root-a's elastic growth can consume the space/varneeds, so thevarpartition is never created (or is undersized) andvar.mounttimes out on the second boot.Fix
20-root-a.conf: boundSizeMaxBytesto a realistic OS-payload size (8G) instead of the full test-disk size, so root-a's growth can no longer starve/var.30-var.conf: give/varan explicit highWeight=10000so it always retains a dominant share of the leftover space and itsSizeMinBytes=4G, regardless of how far root-a grows./varremains the tail partition that grows to fill the disk.Verification
tests/unit/test_repart_layout.py) pass: exactly oneesp/root/var; root keepsGrowFileSystem=yesand aSizeMaxBytes; var staysxfs,GrowFileSystem=yes, noSizeMaxBytes, noFactoryReset, with itsCopyFilesintact.check-release-version.pyandcheck-k0s-version.pypass.just validate(BuildStream merge-contract check) and thejust show-me-the-futureQEMU smoke should be exercised in CI on this PR.— hive: backend=goose model=deepseek/deepseek-v4-flash-0731
🐝 Hive Agent:
contributor| SHA:8bebf54