fix: removing search-light from the enabled extensions until there's a fix

[pfanzola]

Consider to disable the search-light extension until they'll fix this: ublue-os/bluefin#4622
icedman/search-light#161

Normally, I would wait for a fix from upstream (without this PR), but this bug can log the user out or even cause the computer to reboot, resulting in the loss of hours of unsaved work.

Summary by CodeRabbit

• Chores
  • Disabled the "Search Light" GNOME extension from the system default configuration so it will no longer be enabled by default. This changes the out-of-the-box desktop experience by preventing the extension from loading automatically; users may still enable or install it manually if they prefer.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f6899293-3e6e-4975-8338-63bb805ffed5

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6bfea and c0ef342.

📒 Files selected for processing (1)

• system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override

---

📝 Walkthrough

Walkthrough

Removes search-light@icedman.github.com from the org.gnome.shell enabled-extensions list in Bluefin's zz0-bluefin-modifications.gschema.override.

Changes

Extension Removal Configuration

Layer / File(s)	Summary
Remove search-light extension from enabled list system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override	The org.gnome.shell enabled-extensions list is updated to exclude search-light@icedman.github.com.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• projectbluefin/common#323: Both PRs modify the same GNOME Shell enabled-extensions list in zz0-bluefin-modifications.gschema.override, removing different extensions.

Suggested labels

lgtm

Suggested reviewers

• castrojo
• inffy

Poem

🐰 I nudge the schema, soft and bright,
A single light slips out of sight,
Bluefin hums with a quieter tune,
Moonlit code beneath the moon,
I hop away, pleased with the night.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: disabling the search-light extension in the enabled extensions list to address a reported bug.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[castrojo]

I think let's at see least if we can find someone to fix this upstream?

[pfanzola]

I think let's at see least if we can find someone to fix this upstream?

I would agree with u but it seems that the search light extension isn't well actively maintained... The last merged PR was 2 mo ago (gnome 50 support) and before that only the 49 support 8 mo ago with some PRs still open ready to be reviewed and mergerd for several months...

Don't get me wrong I would love to see a fix for this instead of cut it off... in fact my PR was only for disabling it, not for the removal of the extension.
Anyway let's wait a bit and see what will happen in upstream.

[coderabbitai]

🧹 Nitpick comments (1)

system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override (1)

102-109: 💤 Low value

Consider adding a comment explaining why search-light configuration is retained.

Since the extension has been temporarily disabled (line 5) due to upstream bugs, consider adding a brief comment above this section to clarify that the configuration is intentionally kept for easy re-enablement once the upstream issues are resolved. This would help future maintainers understand the context.

Example:

+# search-light extension temporarily disabled (line 5) due to upstream bugs
+# Configuration retained for easy re-enablement when fixed
 [org.gnome.shell.extensions.search-light]

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override`
around lines 102 - 109, Add a brief comment immediately above the
[org.gnome.shell.extensions.search-light] block explaining that the search-light
extension is intentionally retained/kept configured because it is temporarily
disabled upstream due to known bugs and the settings (e.g., shortcut-search,
scale-width/height, border-*, background-color) are preserved to allow easy
re-enablement once upstream issues are resolved; reference the extension name
"org.gnome.shell.extensions.search-light" in the comment so future maintainers
understand the reason.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override`:
- Around line 102-109: Add a brief comment immediately above the
[org.gnome.shell.extensions.search-light] block explaining that the search-light
extension is intentionally retained/kept configured because it is temporarily
disabled upstream due to known bugs and the settings (e.g., shortcut-search,
scale-width/height, border-*, background-color) are preserved to allow easy
re-enablement once upstream issues are resolved; reference the extension name
"org.gnome.shell.extensions.search-light" in the comment so future maintainers
understand the reason.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 54c5aedc-2ddd-450f-89ed-dcb519669d67

📥 Commits

Reviewing files that changed from the base of the PR and between 857c6f6 and 2d6bfea.

📒 Files selected for processing (1)

• system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override

[hanthor]

🤖 AI-Assisted Pull Request Review

Fully support this change. Disabling the search-light extension is a necessary hotfix to prevent the severe upstream bug that triggers sudden user logouts and system reboots, preventing loss of unsaved user work.

Concerning CodeRabbit's Nitpick:
CodeRabbit recommended adding comments explaining why the settings blocks are retained inside @system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override.
However, this is actually bad practice and should be avoided. Comment lines (e.g. starting with #) inside .gschema.override files are parsed by glib-compile-schemas and have historically triggered syntax compilation warnings or errors depending on the specific GLib version on the host. It is much safer to merge this clean diff as-is without adding override comments.

Ready to merge!

[hanthor]

Correct fix -- disabling search-light until the upstream crash/logout bug is fixed is the right call for user safety. CI passes. Approved.

[hanthor]

Approved: Clean docs changes.

[oameye]

This PR should fix it
icedman/search-light#164