Skip to content

ci: bump testsuite SHA to fcbfd6a (fix smoke exit code) - #505

Closed
castrojo wants to merge 8 commits into
mainfrom
fix/bump-testsuite-sha-303e716
Closed

castrojo wants to merge 8 commits into
mainfrom
fix/bump-testsuite-sha-303e716

Conversation

@castrojo

@castrojo castrojo commented Jun 5, 2026 •

Copy link
Copy Markdown
Contributor

Bumps testsuite SHA to fcbfd6a (was 303e716) which adds all e2e workflow fixes including the critical Patch 5 that wraps stop_display_manager() in try/except.

Without this fix, E2E smoke always exits code 1 (CalledProcessError on sudo systemctl stop gdm inside the container — no systemd PID 1), masking all 50 passing scenarios.

Fixes included since 25c9ad0 (previous pin):

This is the minimum required to get green E2E smoke runs in all consumer repos.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Summary by CodeRabbit

  • Chores
    • Updated CI workflow reference to a newer pinned revision of a downstream reusable workflow. This is an internal CI maintenance change with no changes to runtime behavior or public interfaces. User-facing impact is minimal; tests and automation consume the updated workflow reference.

Includes #321-#324:
- dnf brew fallback
- AT-SPI re-query after toolkit-accessibility
- rpm-ostree --apply-live for ostree images
- stop bootc lock before rpm-ostree install

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dosubot dosubot Bot added size:XS labels Jun 5, 2026
@coderabbitai

coderabbitai Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@castrojo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 9 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 26ff2e65-773d-4723-9390-5a335f235e2f

📥 Commits

Reviewing files that changed from the base of the PR and between 6abaafb and 4c7ca28.

📒 Files selected for processing (1)
  • .github/workflows/run-testsuite.yml
📝 Walkthrough

Hidden review stack artifact

Walkthrough

The GitHub Actions workflow run-testsuite.yml updates its downstream dependency reference, bumping the pinned commit SHA for the projectbluefin/testsuite e2e reusable workflow to a newer commit on main.

Changes

Downstream Workflow Reference Update

Layer / File(s) Summary
Downstream workflow commit reference update
.github/workflows/run-testsuite.yml
The uses: directive pinning the projectbluefin/testsuite e2e reusable workflow is bumped to a newer commit SHA on main.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I nudged a SHA from old to new,
A tiny hop the workflows flew,
E2E's called with firmer frame,
Downstream paths still speak the same,
I twitch my nose and clap—huzzah!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating the testsuite SHA to fix the smoke exit code issue, which is the primary objective of this PR.
Description check ✅ Passed The PR description provides detailed context about the testsuite SHA bump, explains the critical fix, and lists all related patches since the previous pin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bump-testsuite-sha-303e716

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@castrojo
castrojo enabled auto-merge June 5, 2026 05:22
Updates from 303e716 to fcbfd6a which adds Patch 5 to the runner
container — wraps stop_display_manager() in try/except so the cleanup
no longer raises CalledProcessError (no systemd in container) and
exits 1, masking all 50 passing smoke test results.

Without this fix, E2E smoke always exits code 1 even when all
scenarios pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo castrojo changed the title ci: bump testsuite SHA to 303e716 (all e2e fixes) ci: bump testsuite SHA to fcbfd6a (fix smoke exit code) Jun 5, 2026
castrojo and others added 6 commits June 5, 2026 05:35
…e_scenario)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Includes all qecore-headless container patches for images where
gnome-session runs as a different UID (lts, dakota, bazzite, gnomeos):
- Patch 4: pgrep UID fallback
- Patch 4b: no-PID env seed from container os.environ
- Patch 6: continue instead of exiting on empty env dict
- Patch 8: seed full container os.environ on IOError reading /proc

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo

castrojo commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by fresh PR with updated SHA 20fb066

@castrojo castrojo closed this Jun 5, 2026
auto-merge was automatically disabled June 5, 2026 11:43

Pull request was closed

@castrojo castrojo added 4-review A pull request is awaiting review. and removed area/testing labels Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4-review A pull request is awaiting review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants