fix(e2e): add plugin-name input and pnpm support to plugin-e2e.yaml#168
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
fix(e2e): add plugin-name input and pnpm support to plugin-e2e.yaml#168privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
- Add plugin-name input: passed to deploy script as E2E_PLUGIN_NAME env var - Add e2e-namespace input (was hardcoded) - Add pnpm detection and support (corepack + action-setup) - Detect and use correct package manager for install/build/test steps - Fix kubectl setup to use latest version - E2E_PLUGIN_NAME env var enables dynamic ConfigMap naming in deploy scripts This enables all plugin repos to use @main for the reusable workflow, with proper plugin-name parameterization and pnpm support. Fixes: PRI-809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
plugin-e2e.yamlreusable workflow to:plugin-nameinput (enables ConfigMap naming and mount path parameterization)e2e-namespaceinput (was hardcoded toheadlamp-dev)Changes
plugin-nameinput: passed to deploy script asE2E_PLUGIN_NAMEenv vare2e-namespaceinput: passed to deploy script asE2E_NAMESPACEenv var (was hardcoded)Why
Without pnpm support, the
plugin-e2e.yaml@mainworkflow cannot build pnpm-based plugin repos (rook, sealed-secrets, polaris, etc.).Without
plugin-nameinput, the deploy script must hardcode ConfigMap names and mount paths per-plugin, making the reusable workflow less reusable.Test Plan
plugin-e2e.yaml@mainand passesplugin-e2e.yaml@mainand passescc @cpfarhood