fix(e2e): add pnpm support and e2e-namespace/plugin-name inputs#171
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
Conversation
…ugin-e2e Backported from PRs #168, #169, #166 (all passing CI). Adds: - pnpm detection with pnpm/action-setup and pnpm store caching - e2e-namespace input (default: headlamp-dev) - plugin-name input (default: empty string) - Conditional install/build/test steps: pnpm --frozen-lockfile | npm ci - E2E_PLUGIN_NAME env var passed to deploy-e2e-headlamp.sh Fixes startup_failure on tns-csi plugin (and all pnpm-based plugins) caused by 'npm ci' being called where 'pnpm install --frozen-lockfile' required. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pnpmsupport and two new inputs (e2e-namespace,plugin-name) toplugin-e2e.yaml. This fixes thestartup_failureonheadlamp-tns-csi-pluginwherenpm ciwas called on a pnpm-based project.Problem
The
plugin-e2e.yamlreusable workflow hardcodednpm cias the install step. When tns-csi (and other pnpm-based plugins) invoke the workflow:npm cifails becausepnpm-lock.yamlis not a npm lockfilenpm run e2euses the wrong package managere2e-namespaceinput, so all plugins must hardcodeheadlamp-devin their caller workflowFix
Detect package managerstep — detectspnpm-lock.yamlpresenceSetup pnpmstep usingpnpm/action-setup@v5with store cachinge2e-namespaceinput (default:headlamp-dev)plugin-nameinput (default: empty string) for ConfigMap/mount path flexibilitypnpm install --frozen-lockfilevsnpm cipnpm run buildvsnpx @kinvolk/headlamp-plugin buildpnpm run e2evsnpm run e2eE2E_PLUGIN_NAMEenv var to Deploy stepTesting
.githubrepo: passed (PR fix(e2e): add plugin-name input and pnpm support to plugin-e2e.yaml #168, fix(e2e): add plugin-name and e2e-namespace inputs #169, feat(e2e): add e2e-namespace input to plugin-e2e workflow #166 all green)runners-privilegedescalation: monitored for recurrenceheadlamp-tns-csi-pluginwhich haspackageManager: pnpm@10.32.1Related Issues
cc @cpfarhood