Skip to content

chore(examples): the auth example records auth extension 0.28.0 - #343

Merged
wmadden-electric merged 1 commit into
mainfrom
chore/auth-example-0.28.0
Oct 7, 2026
Merged

wmadden-electric merged 1 commit into
mainfrom
chore/auth-example-0.28.0

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

The auth example's committed contract records the auth extension at the version Composer ships:

-      "version": "0.27.0"
+      "version": "0.28.0"

This commit was meant to land in #342, as the fix for the review comment there, but #342 auto-merged seconds before it was pushed. It is the contract emitted again after the 0.28.0 bump and a rebuild, in examples/auth/contract.json and contract.d.ts. Storage, execution and profile hashes do not change.

Agent: grendel-61

🤖 Generated with Claude Code

Re-emitted after the bump, so the version the example contract embeds matches the release. Hashes do not change.

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@prisma-gizmo

prisma-gizmo Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

✅ Gizmo reviewed 233c061 — posted 0 inline comment(s) this pass.

Open findings: none

Change walkthrough

Change walkthrough

This PR refreshes the auth example's committed contract so it records the auth extension at the version Composer now ships: 0.27.0 → 0.28.0 in both examples/auth/contract.json:59 and examples/auth/contract.d.ts:311. It's a regenerated-artifact commit — the output of prisma contract emit re-run after the workspace-wide 0.28.0 version bump — meant to close out a review comment from #342 that landed just after that PR auto-merged.

Where the value comes from. The extension record in the example's app-space contract mirrors the version emitted by the auth extension pack, which reads its own package.json version (packages/1-prisma-cloud/2-shared-modules/auth/src/pack/index.ts, version: packageJson.version). That pack version is 0.28.0 at this head, so the new recorded value matches the source of truth exactly. The previously committed 0.27.0 was the stale artifact from before the bump.

Consistency across the change. The two files stay in sync as a pair: the readonly version: '0.28.0' literal type in the .d.ts matches the JSON value, which keeps the typed JSON import in examples/auth/src/contract.ts (dataContract<Contract>(contractJson)) type-correct. contract.prisma in the same example records no extension version, so there is no third file to touch, and no 0.27 references remain anywhere under examples/auth.

Deliberately untouched neighbors. The auth extension pack ships its own contract files under packages/1-prisma-cloud/2-shared-modules/auth/src/pack/, but those describe the Better Auth contract space with readonly extensions: {} — no version record — so they are a different artifact shape, not a copy that could drift with this bump. The example's committed contract is the "dedicated database" shape: an empty public namespace plus the single auth extension record, whose only role here is to name the pack version the example consumes.

Nothing else changes: storage, execution and profile hashes are unaffected, and no code imports the version literal beyond the typed import noted above.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6fd3b51f-7c3e-41ef-a736-0b4e90ecdc05
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@prisma-gizmo prisma-gizmo Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New findings: none · trace

@prisma-gizmo prisma-gizmo Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No critical or major Gizmo finding is open and the head commit has been reviewed. Approving.

@pkg-pr-new

pkg-pr-new Bot commented Oct 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@prisma/composer@343
npm i https://pkg.pr.new/@prisma/composer-cli@343
npm i https://pkg.pr.new/@prisma/composer-prisma-cloud@343

commit: 233c061

@wmadden-electric
wmadden-electric merged commit 5f1e28f into main Oct 7, 2026
25 checks passed
@wmadden-electric
wmadden-electric deleted the chore/auth-example-0.28.0 branch October 7, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants