Repository navigation
chore(release): v0.29.0 - #346
Conversation
Signed-off-by: Kristof Siket <siket@prisma.io>
|
✅ Gizmo reviewed 1a9f984 — posted 0 inline comment(s) this pass. Open findings: none Change walkthroughThis PR ships Composer Version bump. Every touched manifest moves to Engine/ORM alignment (#345). Effect range policy (#348). The exact |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Summary by CodeRabbit
WalkthroughPackage versions and workspace dependency references were updated from 0.28.0 to 0.29.0 across the root package, framework and Prisma Cloud packages, public packages, examples, integration tests, and website. The core concepts skill documentation and auth extension contract were also updated to name version 0.29.0. Priority: ⬆️ High Merge Risk: ⚪ Minimal · up to The reviewed release changes show no actionable merge-blocking behavior; the documented node migration is not introduced by this change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
There was a problem hiding this comment.
New findings: 🟡 1 minor · trace
Findings outside the diff
- 🟡 Minor · consistency examples/auth/contract.json — Auth example contract still records extension 0.28.0 after the workspace bumped to 0.29.0
This release stamps every workspace manifest to 0.29.0, including the auth extension pack at packages/1-prisma-cloud/2-shared-modules/auth/package.json, but the auth example's committed contract still embeds the extension version as0.28.0(examples/auth/contract.json:59 and the mirror at examples/auth/contract.d.ts:311). The previous release cycle handled exactly this: after the 0.28.0 bump, the contract was re-emitted in a follow-up ("Re-emitted after the bump, so the version the example contract embeds matches the release"), which is what the release notes refer to as "the auth example records auth extension 0.28.0 (#343)". So as merged, 0.29.0 ships an example whose recorded extension version does not match the extension actually shipped. If the #343-style re-emit is planned as a separate post-merge PR this is a known follow-up; otherwise runprisma contract emitfor examples/auth so the embedded version tracks the release (the commit message notes hashes do not change).
Recommended fix: After the version bump lands, re-emit the example contract (prisma contract emitin examples/auth) soextensions.auth.versionreads0.29.0, matching the lockstep version ofpackages/1-prisma-cloud/2-shared-modules/auth.
Re-runs pnpm bump-minor on top of main to resolve the version conflicts with #348. Signed-off-by: Kristof Siket <siket@prisma.io>
Re-runs pnpm bump-minor on top of main to resolve the version conflicts with #345. Signed-off-by: Kristof Siket <siket@prisma.io>
The auth example's contract emitted again after the 0.29.0 bump and a rebuild, so the version it embeds matches the release. Storage, execution and profile hashes do not change. Signed-off-by: Kristof Siket <siket@prisma.io>
|
Fixed in 1a9f984: |
Composer
0.29.0, on Prisma ORM8.0.0-rc.17and CLI engine0.7.0. Merging this PR ships0.29.0.What's in it
node()takesdependencies: 'bundled' | 'external', and the default isbundled(feat(node)!: add dependencies: 'bundled' | 'external' to node(), default bundled #341). The directory form no longer tracesnode_modulesunless it setsdependencies: 'external'. A build that relied on the trace, for example the Astro, SvelteKit or React Router server output, now setsdependencies: 'external'. Otherwise it fails at boot with a missing-package error.8.0.0-rc.17and CLI engine0.7.0(chore(deps): move Composer to Prisma ORM 8.0.0-rc.17 and CLI engine 0.7.0 #345). ORM rc.17 is the first ORM release on engine0.7.0, the engine the Prisma CLI ships, so the CLI can ship this Composer with no engine exception.310f206d→0df0ef09): its foreign keys now name their backing indexes. The schema is unchanged. An auth database deployed with an earlier Composer stops its next deploy withMIGRATION_PATH_NOT_FOUNDuntil you runprisma db signagainst it.prisma devandprisma deployno longer fail in pnpm projects withDEPLOY.ALCHEMY_BIN_MISSING(prisma dev and prisma deploy no longer fail in pnpm projects with DEPLOY.ALCHEMY_BIN_MISSING #332).2.0.0-beta.81, andeffectis a^4.0.0range instead of an exact pin (Upgrade alchemy to beta.81 and use effect ^4.0.0, dropping the @effect/vitest runtime dependency #348).0.28.0(chore(examples): the auth example records auth extension 0.28.0 #343).Checks
mainafter chore(deps): move Composer to Prisma ORM 8.0.0-rc.17 and CLI engine 0.7.0 #345. The merge commit is a freshpnpm bump-minorrun on top ofmain, not hand-resolved conflicts.pnpm bump-minorchanged only versions: 41 manifests from0.28.0to0.29.0, the skill'slibrary_version, andpnpm-lock.yaml.pnpm install --frozen-lockfilepasses on the result.examples/authis emitted again, so its contract records auth extension0.29.0. Only the version lines change.pnpm check:publish-deps: noworkspace:orcatalog:leaks in the 3 publishable packages.