Skip to content

Note why the _estack extern stays in the chip crate #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppannuto merged 1 commit into from
Aug 28, 2026
Merged

Note why the _estack extern stays in the chip crate #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions chips/qemu_arm_mps2/src/vectors_m3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ use cortexm3::{CortexM3, CortexMVariant, initialize_ram_jump_to_main, unhandled_
extern "C" {
// _estack is not really a function, but it makes the types work.
// You should never actually invoke it!!
//
// Keep this in the chip crate: `process_console` declares `_estack` as
// data, and LTO can't hold both types in one unit -- it renames ours to
// `_estack.1` and the link then fails, blaming an unrelated line.
fn _estack();
}

Expand Down
4 changes: 4 additions & 0 deletions chips/qemu_arm_mps2/src/vectors_m4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ use cortexm4::{CortexM4, CortexMVariant, initialize_ram_jump_to_main, unhandled_
extern "C" {
// _estack is not really a function, but it makes the types work.
// You should never actually invoke it!!
//
// Keep this in the chip crate: `process_console` declares `_estack` as
// data, and LTO can't hold both types in one unit -- it renames ours to
// `_estack.1` and the link then fails, blaming an unrelated line.
fn _estack();
}

Expand Down