Note why the _estack extern stays in the chip crate - #4
Merged
ppannuto merged 1 commit intoAug 28, 2026
Merged
Conversation
ppannuto
force-pushed
the
qemu-arm-mps2
branch
from
August 28, 2026 17:00
da0d4c0 to
efff4e3
Compare
Breaking this rule produces `undefined symbol: _estack.1` attributed to an unrelated line, which gives a reader nothing to go on. Record the cause where the declaration actually lives. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ppannuto-claude
force-pushed
the
qemu-arm-mps2-review-fixes
branch
from
August 28, 2026 17:02
a1d383e to
11c45ea
Compare
ppannuto-claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto the squashed branch; everything else here has landed.
What's left is a replacement for the
Cargo.tomlfeature comment you pushed back on — that version was too long and in the wrong file, so it's dropped. Three lines at theexternblock instead, invectors_m3.rsandvectors_m4.rs.The fact is worth keeping only because the failure isn't self-explaining: LTO renames one of the two
_estackdeclarations and you getundefined symbol: _estack.1blamed on an unrelated line, with nothing pointing atprocess_console. The comment exists so that error string is greppable from the declaration that causes it.Both boards build clean;
make formatpasses.