Repository navigation
docs(export-import): drop stale iii 180s timeout rationale - #52
Merged
Merged
Conversation
added 3 commits
September 22, 2026 20:51
Generated-By: Claude Opus 5.5 (1M context)
…in-process Engine State is synchronous node:sqlite with no invocation timeout and no remote backend, so the fan-out and ~20x wallclock claims do not hold here. Generated-By: Claude Opus 5.5 (1M context)
Owner
Author
Code review: basic scanAxes run: Standards, Spec. Every hard violation is corrected, every judgement call is resolved, and both reviewers signed off on the fixes to their own findings. Reviewed-Head: c6ece2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of #31, surfaced by the #50 review. ADR 0001 says any remaining iii-derived ceiling is a defect; one comment still budgeted against "the 180s function timeout".
src/functions/export-import.ts: theIMPORT_CHUNK_SIZEcomment no longer cites the timeout. It also drops the "not to overwhelm the state backend" and "~20x wallclock" claims: State is synchronousnode:sqlitewith no remote backend, so neither holds on the in-process Engine. The comment now says only what chunking does: cap how many State calls are in flight per step. The constant is unchanged..env.example: verified, not edited.SUMMARIZE_CHUNK_TOKENS=50000andSUMMARIZE_CHUNK_CONCURRENCY=2already match the post-fix(summarize): token-budget chunking, Session Summary reuse, noop predicate, per-operation breaker #45 defaults andSUMMARIZE_CHUNK_SIZEis gone.The remaining 180 s mentions are three lines across two files in
src/, and each describes a bound this fork imposes or removed:src/providers/agent-sdk.ts:51and:61(the Agent SDK budget,AGENTMEMORY_AGENT_SDK_TIMEOUT_MS) andsrc/engine/inproc/sdk.ts:8(states the ceiling no longer exists).Test plan
grep -rn "180s" src/ .env.examplereturns nothingnpm run typecheck— 0 errorsnpm test— 2092 passed, 1 skippedCloses #51. Refs #31.
🤖 Generated with Claude Code