Skip to content

docs(export-import): drop stale iii 180s timeout rationale - #52

Merged
possiblyneal merged 3 commits into
mainfrom
fix/stale-180s-rationale
Oct 3, 2026
Merged

possiblyneal merged 3 commits into
mainfrom
fix/stale-180s-rationale

Conversation

@possiblyneal

@possiblyneal possiblyneal commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

Cleanup of #31, surfaced by the #50 review. ADR 0001 says any remaining iii-derived ceiling is a defect; one comment still budgeted against "the 180s function timeout".

  • src/functions/export-import.ts: the IMPORT_CHUNK_SIZE comment no longer cites the timeout. It also drops the "not to overwhelm the state backend" and "~20x wallclock" claims: State is synchronous node:sqlite with no remote backend, so neither holds on the in-process Engine. The comment now says only what chunking does: cap how many State calls are in flight per step. The constant is unchanged.
  • .env.example: verified, not edited. SUMMARIZE_CHUNK_TOKENS=50000 and SUMMARIZE_CHUNK_CONCURRENCY=2 already match the post-fix(summarize): token-budget chunking, Session Summary reuse, noop predicate, per-operation breaker #45 defaults and SUMMARIZE_CHUNK_SIZE is gone.

The remaining 180 s mentions are three lines across two files in src/, and each describes a bound this fork imposes or removed: src/providers/agent-sdk.ts:51 and :61 (the Agent SDK budget, AGENTMEMORY_AGENT_SDK_TIMEOUT_MS) and src/engine/inproc/sdk.ts:8 (states the ceiling no longer exists).

Test plan

  • grep -rn "180s" src/ .env.example returns nothing
  • npm run typecheck — 0 errors
  • npm test — 2092 passed, 1 skipped

Closes #51. Refs #31.

🤖 Generated with Claude Code

neal added 3 commits September 22, 2026 20:51
…T_CHUNK_SIZE

ADR 0001 says any remaining iii-derived ceiling is a defect. The constant
stands on its own (per-chunk fan-out, ~20x wallclock); only the timeout
sentence was stale. .env.example already matches the post-#45 defaults.

Closes #51

Generated-By: Claude Fable 5.1
…in-process Engine

State is synchronous node:sqlite with no invocation timeout and no remote
backend, so the fan-out and ~20x wallclock claims do not hold here.

Generated-By: Claude Opus 5.5 (1M context)
@possiblyneal

Copy link
Copy Markdown
Owner Author

Code review: basic scan

Axes run: Standards, Spec. Every hard violation is corrected, every judgement call is resolved, and both reviewers signed off on the fixes to their own findings.

Reviewed-Head: c6ece2e

@possiblyneal
possiblyneal merged commit bd77a96 into main Oct 3, 2026
6 checks passed
@possiblyneal
possiblyneal deleted the fix/stale-180s-rationale branch October 19, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale iii 180s-timeout rationale in export-import.ts and .env.example

1 participant