Repository navigation
docs: drop stale engine-timeout rationales - #112
Merged
Merged
Conversation
added 2 commits
October 3, 2026 16:02
The in-process Engine has no invocation timeout (ADR 0001); the traversal cap bounds how long a request spends walking a tree, which still holds. Generated-By: Claude Opus 5.5 (1M context)
Seven more comments justified a bound by an iii invocation timeout or the 30s state::set timeout. The in-process Engine has neither (ADR 0001); each bound still holds because the unbounded work is slow, so the comments now say that. Upstream issue references on the touched lines are written as rohitg00/agentmemory#N. Generated-By: Claude Opus 5.5 (1M context)
Owner
Author
Code review: standard scanAxes: Standards, Spec, Correctness/Logic. Every hard violation is fixed and every judgement call is resolved. Each axis signed off on the fixes to its own findings. Reviewed-Head: 4805335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Eight comments justify a bound with an engine invocation timeout: "the 30s function timeout", the 30s
state::settimeout, or the iii invocation timeout or deadline. The in-process Engine has no invocation timeout (ADR 0001), so those rationales are stale, in the same way as the one #52 fixed.Change
Comments only. Each bound still holds, because the work it limits is slow when left unbounded. The comments now give that as the reason:
src/functions/replay.ts:traversalCapstops a tree full of non-jsonl files from stalling the request that walks it.src/index.ts: theunhandledRejectionsafety net is kept, so that one stray rejection cannot terminate the service.src/state/schema.ts,src/types.ts,src/functions/graph.ts: the graph snapshot and the live-enumeration budget exist because a fullkv.listover a large graph is slow. Removed: the "8s engine invocation deadline" headroom note.src/functions/graph-import.ts: the import bounds stop a very large graph from stalling the request.src/triggers/api.ts,src/viewer/index.html: export pagination and the viewer's memory cap.Upstream issue references on the lines this PR touches are now written as
rohitg00/agentmemory#N.grep -rniE "invocation (timeout|ceiling|budget|window|deadline)|iii (engine )?invocation|30s timeout" srcnow finds onlysrc/engine/inproc/sdk.ts:8, which records that the ceiling was removed. The remainingiiimentions are not about timeouts, so they are left as they are:graph.ts:1258andgraph.ts:1328describe a past "Invocation stopped" failure.obsidian-export.ts:284is about error serialization.Verification
npm run typecheck: 0 errors.npm test: 2113 passed, 1 skipped.🤖 Generated with Claude Code