Repository navigation
analyze: prove document offsets past a non-ASCII character - #5
Merged
Merged
Conversation
Every html/markdown offset assertion added with .analyze was ASCII-only, so none of them discriminated a code-point document offset from a byte one through the span adapter — the place a byte-oriented runtime actually gets it wrong. Ruby's String#index is character-based, so this runtime was never at risk, but the five ports share one proof set. "café" in the first span puts the UTF-8 byte offset one ahead of the code-point offset, and the example now asserts both numbers. Test-only. 19 examples pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only, closing a proof gap left by #4, in parallel with polytypo/polytypo-js#14, polytypo/polytypo-python#5 and polytypo/polytypo-go#5.
Every
html/markdownoffset assertion that landed with.analyzewas ASCII-only, in all five runtimes — so none of them separated a code-point document offset from a byte one through the span adapter. Ruby'sString#indexis character-based and this runtime was never at risk; the five ports share one proof set, so the assertion should discriminate here too.caféin the first span puts the UTF-8 byte offset one ahead of the code-point offset, and the example asserts both numbers.Checks: 19 examples pass on Ruby 3.3.8.
🤖 Generated with Claude Code