Skip to content

analyze: prove document offsets past a non-ASCII character - #5

Merged
rogulia merged 1 commit into
mainfrom
test/analyze-span-offsets
Sep 19, 2026
Merged

rogulia merged 1 commit into
mainfrom
test/analyze-span-offsets

Conversation

@rogulia

@rogulia rogulia commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Test-only, closing a proof gap left by #4, in parallel with polytypo/polytypo-js#14, polytypo/polytypo-python#5 and polytypo/polytypo-go#5.

Every html/markdown offset assertion that landed with .analyze was ASCII-only, in all five runtimes — so none of them separated a code-point document offset from a byte one through the span adapter. Ruby's String#index is character-based and this runtime was never at risk; the five ports share one proof set, so the assertion should discriminate here too.

café in the first span puts the UTF-8 byte offset one ahead of the code-point offset, and the example asserts both numbers.

Checks: 19 examples pass on Ruby 3.3.8.

🤖 Generated with Claude Code

Every html/markdown offset assertion added with .analyze was ASCII-only, so none
of them discriminated a code-point document offset from a byte one through the
span adapter — the place a byte-oriented runtime actually gets it wrong. Ruby's
String#index is character-based, so this runtime was never at risk, but the five
ports share one proof set.

"café" in the first span puts the UTF-8 byte offset one ahead of the code-point
offset, and the example now asserts both numbers.

Test-only. 19 examples pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@rogulia
rogulia merged commit 3da524c into main Sep 19, 2026
3 checks passed
@rogulia
rogulia deleted the test/analyze-span-offsets branch September 19, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant