Skip to content

analyze: prove document offsets past a non-ASCII character - #5

Merged
rogulia merged 1 commit into
mainfrom
test/analyze-span-offsets
Sep 19, 2026
Merged

rogulia merged 1 commit into
mainfrom
test/analyze-span-offsets

Conversation

@rogulia

@rogulia rogulia commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Test-only, closing a proof gap left by #4, in parallel with polytypo/polytypo-js#14, polytypo/polytypo-python#5, polytypo/polytypo-go#5 and polytypo/polytypo-ruby#5.

Every html offset assertion that landed with analyze() was ASCII-only, so none of them separated a code-point document offset from a byte one through the span adapter. In PHP that is not hypothetical: strings are bytes, and on an ASCII document mb_strpos and strpos return the same number, so the existing assertion would pass over a byte offset.

café in the first span puts the byte offset one ahead of the code-point offset. The test asserts that premise first, then the offset — so the discriminating property can't quietly stop discriminating.

Checks: 17 tests, 52 assertions; PHPStan level 8 clean; phpcs clean — PHP 8.3.32.

🤖 Generated with Claude Code

Every html offset assertion added with analyze() was ASCII-only, so none of them
discriminated a code-point document offset from a byte one through the span
adapter. That is the mistake available to PHP specifically: strings here are
bytes, and on an ASCII document mb_strpos and strpos return the same number.

`café` in the first span puts the byte offset one ahead of the code-point one,
and the test asserts that premise before asserting the offset, so a byte offset
leaking out of the span adapter fails loudly rather than passing quietly.

Test-only. 17 tests, 52 assertions; PHPStan level 8 and phpcs clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@rogulia
rogulia merged commit 7318176 into main Sep 19, 2026
3 checks passed
@rogulia
rogulia deleted the test/analyze-span-offsets branch September 19, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant