Repository navigation
analyze: prove document offsets past a non-ASCII character - #5
Merged
Merged
Conversation
Every html offset assertion added with analyze() was ASCII-only, so none of them discriminated a code-point document offset from a byte one through the span adapter. That is the mistake available to PHP specifically: strings here are bytes, and on an ASCII document mb_strpos and strpos return the same number. `café` in the first span puts the byte offset one ahead of the code-point one, and the test asserts that premise before asserting the offset, so a byte offset leaking out of the span adapter fails loudly rather than passing quietly. Test-only. 17 tests, 52 assertions; PHPStan level 8 and phpcs clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only, closing a proof gap left by #4, in parallel with polytypo/polytypo-js#14, polytypo/polytypo-python#5, polytypo/polytypo-go#5 and polytypo/polytypo-ruby#5.
Every
htmloffset assertion that landed withanalyze()was ASCII-only, so none of them separated a code-point document offset from a byte one through the span adapter. In PHP that is not hypothetical: strings are bytes, and on an ASCII documentmb_strposandstrposreturn the same number, so the existing assertion would pass over a byte offset.caféin the first span puts the byte offset one ahead of the code-point offset. The test asserts that premise first, then the offset — so the discriminating property can't quietly stop discriminating.Checks: 17 tests, 52 assertions; PHPStan level 8 clean; phpcs clean — PHP 8.3.32.
🤖 Generated with Claude Code