fix: disable unsafe historical Hermes reconciliation - #199
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync --reconcile-hermesis requestedWhy
Live verification of #197 showed that mapping cumulative long-running session totals to
last_seenmoved 2.448B tokens into one current-day bucket.session_model_usagehas cumulative totals, not timestamped per-model deltas, so historical daily/hourly repair cannot be reconstructed safely.Verification
node --test test/sync-unsafe-hermes-reconciliation.test.jsnode --test test/rollout-parser.test.js(169/169)npm test(1063/1063)npm run ci:localReopens #169.