Repoint static analysis to reusable-static-analysis-unified - #167
Repoint static analysis to reusable-static-analysis-unified#167berfinyuksel wants to merge 3 commits into
Conversation
berfinyuksel
added
the
Skip Milestone Check
There was a problem hiding this comment.
Pull request overview
Restores static analysis by migrating to the unified reusable workflow.
Changes:
- Generates and passes the unified PHPStan matrix.
- Restricts triggers and ignores non-code changes.
- Cancels superseded workflow runs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rebased to 6.2 per the platform-version line map (2024.4/2025.4/2026.2/2026.x are the valid lines; the previous base was not on a valid line). The caller referenced a reusable retired on 2025-12-09, so every run start-failed with zero jobs. Convergence lands on the 2025-line only; 2024-line workflows keep their own matrices per policy. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
3f08f0c to
3f64363
Compare
|
Converting to draft: both legs execute and PHPStan finds exactly one real error on 6.2 — arrayNode() on an unknown generic NodeBuilder class (Symfony Config type generics). One baseline entry or a one-line type-hint fix unblocks this; code decision, not workflow. The workflow change itself is validated (same pattern green on newsletter-bundle#93, system-info-bundle#61, web2print-tools). |
Per review of the drift map: .bak files removed, obsolete frontend/npm workflows removed, cla/docs/poeditor/cs-fixer/copilot-setup/stale synced to the 2026.x content and filenames, and static analysis gets the uniform paths-ignore (assets, assets-customized, doc, install, src/Resources/public, **.md). Matrix-bearing workflows keep their era-specific content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Fix for the silently-dead static analysis (pimcore/DevOps-Tasks#47): this branch's caller references
reusable-static-analysis-centralized.yaml, retired from workflows-collection-public on 2025-12-09 — every run since start-failed with zero jobs. Replaced with the unified pattern validated on pimcore/web2print-tools#121 and green on pimcore/system-info-bundle#61 / pimcore/opensearch-client#59.This lands on the lowest 12-era branch: the older branches of this repo cannot install any Pimcore ^10/^11 release under Composer 2.9's Packagist advisory policy (verified in PR runs), so their static analysis stays documented on #47 pending the workflows-owner decision. Forward-merge up the remaining chain follows after merge.
Also carries pimcore/DevOps-Tasks#44 ideas 1–3 in the same file: push scoped to version branches,
concurrencykeyed by PR number (cancels superseded runs, no cross-fork collisions), paths-ignore for docs/assets/markdown.Expected on this PR: static analysis runs real matrix legs.