Repoint static analysis to reusable-static-analysis-unified - #166
Closed
berfinyuksel wants to merge 5 commits into
Closed
Repoint static analysis to reusable-static-analysis-unified#166berfinyuksel wants to merge 5 commits into
berfinyuksel wants to merge 5 commits into
Conversation
The previous caller referenced a reusable workflow retired in workflows-collection-public on 2025-12-09, so every run start-failed with zero jobs. Replace it with the unified pattern validated in pimcore/web2print-tools#121, with paths-ignore, push scoped to version branches, and a concurrency group with cancel-in-progress. Refs pimcore/DevOps-Tasks#47, pimcore/DevOps-Tasks#44. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Restores PHPStan execution through the unified reusable workflow and streamlines CI triggers.
Changes:
- Migrates to
reusable-static-analysis-unified.yaml. - Adds concurrency cancellation and path filters.
- Generates the reusable workflow’s PHPStan matrix format.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| run: | | ||
| php_versions="${{ steps.parse-php-versions.outputs.php_versions }}" | ||
| MATRIX_JSON=$(cat reusable-workflows/phpstan-configuration/matrix-config.json) | ||
| FILTERED_MATRIX_JSON=$(echo "$MATRIX_JSON" | jq --arg php_versions "$php_versions" '{ include: [ .configs[] | select(.php_version == $php_versions) | .matrix[] ] }') |
berfinyuksel
added
the
Skip Milestone Check
Pimcore ^10/^11 releases are all blocked by Packagist security advisories under Composer 2.9 policy, so the unified workflow cannot install on this version line (verified in this PR's runs). The dead-reference repoint moves to the lowest 12-era branch instead; the state of this branch's static analysis is documented on pimcore/DevOps-Tasks#47. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DevOps-Tasks#44 ideas 1-2: push runs limited to long-lived version branches so PR-branch pushes no longer double-run the suite, and a concurrency group cancels superseded runs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DevOps-Tasks#44 ideas 3 and 5: paths-ignore for docs/markdown where no path filter existed (no required checks gate these workflows on this branch - verified), and timeout-minutes on inline jobs so a hanging job cannot burn the 6h default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Final consolidated adjustments per review: the concurrency group uses the PR number as DevOps-Tasks#44 specifies (head_ref collides across same-named fork branches - Copilot review), pre-existing branch filters are preserved verbatim, and timeouts on test/analysis jobs are 60 minutes so no legitimate long leg is ever killed (setup jobs stay short). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Contributor
Author
|
Closing per the platform-line decision: 5.2 is the 2024.4 line, which expires end of year — the DevOps-Tasks#44 trigger reduction starts from the 2025.4 line upward and nothing new lands on 2024-line branches. This repo's 2025-line PR is #167 (draft, one real PHPStan finding). The 5.2 state (php-style running on every push to every branch, static-analysis paths unfiltered) goes into the 2024.4-line failure report for the new-pipeline work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR now carries only trigger hygiene for
5.2(pimcore/DevOps-Tasks#44 ideas 1–2):php-style.ymlranon: [push]— every push to every branch — now scoped to version branches with a concurrency group.Scope note: the static-analysis repoint originally in this PR was reverted:
5.2(pimcore/pimcore ^11.2 || ^12.0, PHP key 8.2,8.3,8.4) cannot install its 8.2/lowest leg — Pimcore 11 releases are blocked by the Composer advisory policy and Pimcore 12 needs PHP 8.3+. The repoint landed on6.0instead: #167. The 5.2 static-analysis state is documented on pimcore/DevOps-Tasks#47.