Skip to content

Converter: preset L in the preset table, with a synthetic two-preset test - #94

Merged
phantoslayer21 merged 1 commit into
mainfrom
model-l/converter-map
Nov 13, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
model-l/converter-map

Conversation

@phantoslayer21

@phantoslayer21 phantoslayer21 commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #90; merge after #90. #90 (the map's preset by name) is merged, and this pull request now targets main.
Its diff is only its own commit.

Preset L (Model L, #89) is a further preset of the same family as M. Its maps use preset M's record kinds and map
versions, and its parameters are a block of their own in the same library file as M's. With #90 that makes it one row
in the converter's preset table.

  • clean/converter/src/map.cpp known_presets: row L, map versions 1 and 4. M comes first, so a map without the
    "preset" field is never read as L.
  • clean/converter/src/api.cpp / .h: kMsgNoPresetL, the exit-12 message "This DLSS file has no preset-L model.
    Version 310.9 or newer is needed." The version line is provisional, pending confirmation of the first DLSS
    version that ships a preset-L model; it is one line to change then.
  • tests/cases.py preset_pair_case: a synthetic library file (our own sizes and bytes) with an L-like parameter block
    directly before an M-like one, each with its own dither table and keyed constants elsewhere. The L map
    ("preset": "L") has one stage more, standing in for L's extra blocks. The M map has no "preset" field, as the
    shipped one.
  • tests/run_tests.py test_preset_l:
    • each map converts its own block from the shared file (every tensor and digest checked against the reference), and
      its key source is found at the offset where it was placed;
    • the extra stage is only in L's output;
    • each map against a file without its preset's block exits 12 with its own preset's message;
    • the L map without its "preset" field reads as M (M's message) and still converts the same tensors;
    • "preset" values K, F, X and l in a version-1 map are converter data damaged.
  • tests/unit_tests.cpp: the L row (versions, message), "preset":"L" in the version-1 and version-4 unit maps.
  • clean/converter/README.md: the L row in the exit-code table and a short "Preset L" paragraph.

Not in this pull request: the preset-L map file itself (data/preset-L.v1.map.json). It is converter data from the
spec side and comes separately. Until then, preset L is covered by the synthetic case above. Wiring L into the
runtime, launcher and model folder is separate Model L work.

Refs #89

Tested

Run locally on Windows, CPU only, Ninja Release /MT with MSVC. "Main" is d9c697e.

  • Converter ctest (unit, decompression-vectors, synthetic, synthetic5): 4/4 passed.
  • run_tests.py: 3757 checks passed, 0 failed (main: 3663; the 94 more are test_preset_l).
  • Byte-identical output for the existing cases: after the synthetic and synthetic5 tests, every output file
    outside the new preset-l folder was hashed: 1615 files (63 model.wgcm plus raw tensors), SHA-256 identical to
    main's.
  • Public gates (secrets, personal data, licence, chunks) pass.

Not tested

…reset test

Preset L uses preset M's map versions and record kinds; a map names it with
"preset": "L" and gets its own no-model message (exit 12; the DLSS version named
is provisional). run_tests.py adds a synthetic library file with an L block
directly before an M block and maps for both: each converts its own block only,
and a file without a preset's block fails with that preset's message. The real
preset-L map file is not part of this change. Existing synthetic outputs are byte
for byte those of main.

Refs #89

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Base automatically changed from model-l/converter-preset-name to main November 13, 2026 21:59
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 13, 2026 22:05
@phantoslayer21
phantoslayer21 merged commit 3a6d9e7 into main Nov 13, 2026
2 checks passed
@phantoslayer21
phantoslayer21 deleted the model-l/converter-map branch November 13, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant